From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: Help with pdumper Date: Thu, 04 Jul 2024 05:46:53 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13620"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Helmut Eller , emacs-devel@gnu.org, Daniel Colascione To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 04 05:47:56 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPDRs-0003Dz-Bz for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Jul 2024 05:47:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPDQy-00060e-Jv; Wed, 03 Jul 2024 23:47:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPDQw-00060U-Sz for emacs-devel@gnu.org; Wed, 03 Jul 2024 23:46:59 -0400 Original-Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPDQv-0001Ev-GO for emacs-devel@gnu.org; Wed, 03 Jul 2024 23:46:58 -0400 Original-Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-a72585032f1so13920566b.3 for ; Wed, 03 Jul 2024 20:46:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720064815; x=1720669615; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9JInkuq0a1gm4RRprpNJehR+A8hZSeHebipCW2sBrYQ=; b=Ey5PnHJpeOGplSfIF8U+gi3H4xVpX/pbNiA2+5aZ8/bZWrT88/ZypZU+ZE3I3WIXOh INW6Rh5bncnUV1ysNUfJp8MOolO1Kf9SSrRVOOfkBnH4xvNsTF698EwvLErr+0YPjVkh 4fYMit1aQdps+tzSRKNaROnpcWe8/Af3U+pLJfuldJtQBGxGNxhDHmIRpXbigMmHdxe8 w4V1UZbcWT4muV86QwJwnsYregpqrJd9g8M9feMVRnZYjyPWyT8UfjOrpjU1NRE/ICXB 2srS6TSocwFlUJutXXWIBGAPuaDJgtRmO4hH/iFanNurpSuW3Gx3GBIymywJbshIp19/ L8kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720064815; x=1720669615; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9JInkuq0a1gm4RRprpNJehR+A8hZSeHebipCW2sBrYQ=; b=s6tuC7FWQjqUEjA10Lv+PtpqSrkkSOVLkEgmWZpkWC3Uhi4/rTAJZwm1L8pH9BJrst cohKogBGpTEw8UgtJI0U6RZADKbDjjR2m/E7P/zE6KzhL0N8JlnSs7Q0q+ibBodtnGgz aGsmfJXpOB2ADlYM1YvRTpI1/PXm28qE3Xj4ILZpREUdwECq+AHMypbpxKBbyD3zLdMu wLVn7nHiar/pMrvLisviJRAJbjya6NJC6GJga0KabZEAS4ICQEldf8dhkVWY8aekd774 S6S79qKECSw//IBEz8g5FGq58lAg+8TkXR94y6jOSuQo/XkCAzkItZSotej0cds4t3zX c/zg== X-Forwarded-Encrypted: i=1; AJvYcCX/2iVaQ4JvSMqMV/wfIudDySxTEveFAb0DST+2qREXSAJ728Ws6HW3wV1lKRK27Qfsk5yme0dPoXHRZE6jPBxBek71 X-Gm-Message-State: AOJu0YwBgvUMT1CAhiTWK2X1lpmRbUG6NJSRKrloIJcNSV+0d7HcKO27 AvV6zrIWqAzSkB5qlA4o9+DwF9fhK+4cFBA8udzfPrlfPGA6Yze0 X-Google-Smtp-Source: AGHT+IHG7gBx6GlmMlwnCQhtVBZqkxmUW7x3IrodtYyIYKanY8xs1SjRceMlyZd15NEV9PPe6bqIsQ== X-Received: by 2002:a17:906:84f:b0:a75:13b9:22d6 with SMTP id a640c23a62f3a-a77ba70bb11mr20000366b.62.1720064815232; Wed, 03 Jul 2024 20:46:55 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e36fa8.dip0.t-ipconnect.de. [217.227.111.168]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7518578c23sm403836566b.127.2024.07.03.20.46.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jul 2024 20:46:54 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Wed, 03 Jul 2024 16:12:37 -0400") Received-SPF: pass client-ip=2a00:1450:4864:20::62e; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321291 Archived-At: Stefan Monnier writes: > Gerd M=C3=B6llmann [2024-06-30 07:16:43] wrote: >> Stefan Monnier writes: >>> +static dump_off >>> +dump_markers (struct dump_context *ctx, const struct Lisp_Markers *t) >>> +{ > [...] >>> + dump_object_start (ctx, out, bytesize); > [...] >>> + dump_off offset =3D dump_object_finish (ctx, out, bytesize); > [...] >>> return offset; >>> } >> >> Is the returned offset right? > > I don't know. I just cargo-culted that code from other examples around. > But AFAICT, it should: `dump_object_start` sets `ctx->obj_offset` which > is what `dump_object_finish` returns. Ok.