From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#71912: [Gerd =?UTF-8?Q?M=C3=B6llmann]?= Re: bug#71912: 30.0.50; Inaccurate window-absolute-pixel-position Values on macOS After Sleep and During Fullscreen Mode Date: Sun, 11 Aug 2024 13:25:04 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15964"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 71912@debbugs.gnu.org To: Jones Stephen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 11 13:26:59 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sd6iv-0003tm-Sa for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Aug 2024 13:26:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sd6ib-0007MK-Af; Sun, 11 Aug 2024 07:26:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sd6iZ-0007Ln-3k for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2024 07:26:35 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sd6iW-00045M-Tn for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2024 07:26:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=v8Zmb9LqW7On6fDRSDifGrRu2rbn5TJu3eGyUbI2bww=; b=YP3VA2Ta8dyQpY6UbX9bk9asRLaZiq6m4PGAUfPFpydS6XLrLxLwjvcSYB8VCgY6zjTcKkbSGteLXfP/wsX2Q6GPCCtMFKINimTguw94vBsVZLh8K7ihWkRhQXlqkOOuq2ylLPvCW4GCxUg+ZZSLoU0zQ0fw6GbCV9U/w1wacCo4Q0xhmQZxHVHTby4GT1mysXSn1Wkg/LX2G4gGkLyS2w5DkJ7vVvrvfYuWAQ13O7N5LzCJRv7lnogw/PCzUg8BZF97KvqjYxEys92wumAk2O/ngvZ082a4sD2nAoguqfT1ciNm2umg3ieCkCf2Bd/VZu2n+njECrX6OmYjlQq9eQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sd6j0-000152-Gj for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2024 07:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Aug 2024 11:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71912 X-GNU-PR-Package: emacs Original-Received: via spool by 71912-submit@debbugs.gnu.org id=B71912.17233756064118 (code B ref 71912); Sun, 11 Aug 2024 11:27:02 +0000 Original-Received: (at 71912) by debbugs.gnu.org; 11 Aug 2024 11:26:46 +0000 Original-Received: from localhost ([127.0.0.1]:40853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd6ik-00014M-CP for submit@debbugs.gnu.org; Sun, 11 Aug 2024 07:26:46 -0400 Original-Received: from mail-wr1-f52.google.com ([209.85.221.52]:50537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sd6ih-000146-Md for 71912@debbugs.gnu.org; Sun, 11 Aug 2024 07:26:44 -0400 Original-Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3683f56b9bdso2283249f8f.1 for <71912@debbugs.gnu.org>; Sun, 11 Aug 2024 04:26:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723375507; x=1723980307; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=v8Zmb9LqW7On6fDRSDifGrRu2rbn5TJu3eGyUbI2bww=; b=cUTGEo9XnWh21VqlwN6pdf/1Fn+bH7qvT5e6bCOzwvLjdlS/G3DSgV47+UK7oxRW1b ShfnvXk1Rvwq3OnsoOGvQeICi52h3xTM6R/Eqgmb+B3/3hGlwa0yEdph1vJV0GVhD9G9 jhnjPAQv+QvKH973R1qCdUsAnyXnbiCVXpd+ZZFeELkSL69PHrefKVLppyJoGgjmesZ9 DPFwAlLXDIrhpass7al3pel4zXWHO/y3GI/81G4U2zmzmDXZxX9MXTAY9+KLVvnP9/18 plukzejctZLr+ftGQ+YDP8B8shABkCt8R92Qma30NUB19Yksxs+SQTsFDi62vQftTkPM LiGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723375507; x=1723980307; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v8Zmb9LqW7On6fDRSDifGrRu2rbn5TJu3eGyUbI2bww=; b=AdbW7U5S8EO85GvyvnfAh2niJGf+zuBZZholtiu7a+sVREbK71dxpweeU7l2UTZkTl ldtrq3ogdS7CW1eg+mQiM/W8TTuavbXr6kmgD79J/rix/SLs3wIOD6eReUKx+8qoYXg9 Is84z8JEzC8kpnfOPdy+LLToLCzXJY0Rsz4OVhv9VWjcjxizExVAAM3CW9WO4kgpubZF GXDUECkOVfIZ52alLj+mBt+2aaNRLx5h4buFPJpfyJ5hDaB/ZTkBWmnJjxcw+6+W45a6 C+4Cqa8BH5VIhlmEHfWNW48Y9gHjiH5jrJ0pANEndE2gHQf4tp3gKXrNXvkB6atn9pkT 3GKA== X-Gm-Message-State: AOJu0YwgyRgXNQZV6giSc5xyKDdLxSJl5+9MLE6lgB7mlrJzXEXB8+UB oa/CRELAxwgb5QXu35Fe8VOgYQ+fuRVacfvWek5zImbsOf6WlqyXQKROHA== X-Google-Smtp-Source: AGHT+IGCK+uxdlrXaUwABFJc6L9sxqIWcqBeyYy4Ooxno2tZVdhT7m229bw5rqmDW8ndpMawmVzedA== X-Received: by 2002:a05:6000:136f:b0:368:48e6:5059 with SMTP id ffacd0b85a97d-36d60063f3fmr3908443f8f.32.1723375506505; Sun, 11 Aug 2024 04:25:06 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e36a91.dip0.t-ipconnect.de. [217.227.106.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36e4ebd372fsm4662118f8f.108.2024.08.11.04.25.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Aug 2024 04:25:05 -0700 (PDT) In-Reply-To: (Jones Stephen's message of "Sun, 11 Aug 2024 18:39:53 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290014 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jones Stephen writes: > Thank you for the patch. I=E2=80=99ve tested it, and it does help, but I > noticed there=E2=80=99s still a slight issue. > > Here=E2=80=99s what I found: if I leave my Mac idle for a while and it en= ters > sleep mode, when I wake up the Mac and click to focus on Emacs, the > frame position sometimes appears to be incorrect. However, if I put > the Mac to sleep again and then immediately wake it up, the frame > position is correct when I return to Emacs. > > Interestingly, when I moved the `adjustEmacsFrameRect` call to the > `windowDidBecomeKey` method, the issue was completely resolved. After > making this adjustment, the frame position remains correct regardless > of the sleep duration or how the system is woken up. > (Please keep the list in CC, I've added it for this reply.) Thanks. So an a complete patch would look like the attached patch, right? Could you please confirm? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-macOS-Wrong-frame-rectangle-after-wake-bug-71912.patch >From 44fabe5f1267fc0498e76173987ab4801c732d48 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gerd=20M=C3=B6llmann?= Date: Sun, 11 Aug 2024 13:22:45 +0200 Subject: [PATCH] macOS: Wrong frame rectangle after wake (bug#71912) * src/nsterm.m ([EmacsView windowDidBecomeKey]): Call adjustEmacsFrameRect. --- src/nsterm.m | 1 + 1 file changed, 1 insertion(+) diff --git a/src/nsterm.m b/src/nsterm.m index 905707dace4..97b829d0e4c 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -7968,6 +7968,7 @@ - (void)windowDidBecomeKey /* for direct calls */ dpyinfo->ns_focus_frame = emacsframe; ns_frame_rehighlight (emacsframe); + [self adjustEmacsFrameRect]; event.kind = FOCUS_IN_EVENT; XSETFRAME (event.frame_or_window, emacsframe); -- 2.46.0 --=-=-=--