bug#72818: 29.4; Cannot hook with use-package if variable is not `-hook'$

[John Wiegley <johnw@gnu.org>]

>>>>> Eli Zaretskii <eliz@gnu.org> writes:

>> From: Marc Fargas <telenieko@telenieko.com>
>>
>> -- Variable: after-make-frame-functions
>> An abnormal hook run by ‘make-frame’ after it created the frame.
>> Each function in ‘after-make-frame-functions’ receives one
>> argument, the frame just created.
>> 
>> This hook cannot be configured with `use-package' :hook keyword as it
>> does not end in `-hook'.

> Maybe I'm missing something, but how can use-package configure
> abnormal hooks?  It doesn't know which arguments to pass to them,
> right?
>
> John, am I missing something?

I think the behavior should be that if the variable name exists at the time
the use-package macro is encountered, it should use it directly. Only if the
named hook variable has no ‘symbol-value’ — at that time — should it try
appending the name ‘-hook‘ to find a place to append the function.

I.e., the definition could be:

(defun use-package-handler/:hook (name _keyword args rest state)
  "Generate use-package custom keyword code."
  (use-package-concat
   (use-package-process-keywords name rest state)
   (cl-mapcan
    #'(lambda (def)
        (let ((syms (car def))
              (fun (cdr def)))
          (when fun
            (mapcar
             #'(lambda (sym)
                 (if (boundp sym)
                     `(add-hook (quote ,sym) (function ,fun))
                   `(add-hook
                     (quote ,(intern
                              (concat (symbol-name sym)
                                      use-package-hook-name-suffix)))
                     (function ,fun))))
             (use-package-hook-handler-normalize-mode-symbols syms)))))
    (use-package-normalize-commands args))))

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2