From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#74274: [PATCH] Revert part of d3f8ed730f to avoid segmentation fault Date: Sun, 10 Nov 2024 11:56:07 +0100 Message-ID: References: <20241108063148.30423-3-gongqijian@gmail.com> <86cyj4om7g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12169"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: gerd@gnu.org, gongqijian@gmail.com, 74274@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 10 11:58:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tA5eG-0002vv-Gh for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Nov 2024 11:58:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tA5e1-0005LZ-H4; Sun, 10 Nov 2024 05:58:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tA5ds-0005IY-2g for bug-gnu-emacs@gnu.org; Sun, 10 Nov 2024 05:58:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tA5dr-0004sn-Qw for bug-gnu-emacs@gnu.org; Sun, 10 Nov 2024 05:58:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=ahens6pbGRcVT6JQRwsnviBR1m+STY8zbVo000zC2nA=; b=ZpZrdqIXd7brVDya2ge6CcXdmoMaR06FpRabuU+qGErAl5aXqJpWOkaEG6rZrK1baIslMgt8vPe6crRjZIXwgac3he1xEx2WVbAEtRympRvzdX8lS2HFY90Aa+tucumeC2DjovwMGDSF5iHyHtmjeY60oVGZAceRltDDHFenXn9514gpuWS9e+lpcZyGr2ag/DPxpMygfJpVQ+DPXTEt0Ey8rp1azNSady73DwNrFyW1PzmESy9CZJga/GbaRNGPZmZyOTE4ph6Q8SCaydQGnblgl8SZVmRGYLU7e7n+/VpqI8JB/MuvY7Ed21G5UEqhRnF37hbdjBcdvcz9Uruvyw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tA5dq-0003aq-MZ for bug-gnu-emacs@gnu.org; Sun, 10 Nov 2024 05:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Nov 2024 10:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74274 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74274-submit@debbugs.gnu.org id=B74274.173123623313747 (code B ref 74274); Sun, 10 Nov 2024 10:58:02 +0000 Original-Received: (at 74274) by debbugs.gnu.org; 10 Nov 2024 10:57:13 +0000 Original-Received: from localhost ([127.0.0.1]:55889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tA5d2-0003Ze-Uu for submit@debbugs.gnu.org; Sun, 10 Nov 2024 05:57:13 -0500 Original-Received: from mail-wm1-f45.google.com ([209.85.128.45]:48362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tA5d0-0003ZV-UE for 74274@debbugs.gnu.org; Sun, 10 Nov 2024 05:57:12 -0500 Original-Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4315e9e9642so29550455e9.0 for <74274@debbugs.gnu.org>; Sun, 10 Nov 2024 02:57:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731236170; x=1731840970; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ahens6pbGRcVT6JQRwsnviBR1m+STY8zbVo000zC2nA=; b=HF8WRhEqHAi0r+owQviUcnw9LDZarIZg210+30G8sWWLCtv/qfd2Guxg5KisluLFRh W/UhuFBJaD9o2X37UKZNxWZfCEy9akNSWuBKtonYdBDJIQj904Gu06PXTUyxHRhdOeIU o7KVHQtqwJE92siX2QOyWXS3rxBUOLysDbC57u0QAOBXpgR7H8/ns+dP5b+VTdd1fJuA HLhNqJAZPCuVw+rXC9V7LvJw5pcusPox1w/DbmX9b7bWQdhPWcfbN8lQcXC5PUgNlZ7t kmbm6CCj2X7njJPT29c7nwZYfhpGd57QPgW9dAhcVbiM6OARKhpAN1ejbJxXWUNnpnlO lL9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731236170; x=1731840970; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ahens6pbGRcVT6JQRwsnviBR1m+STY8zbVo000zC2nA=; b=JGZ48jpHwk1G6sJokTAib1xij9jIX80LFArK93pLBAXSlWA561LXp/K+5WMsfHhb4n MNPB5seKvmBPGvmxtTKw7yXb3gF2qfmaiXZzaXXRs+jukTznCsu9BqlaB/41PuP49zQ2 OgXxaoeajKY2jslhwdEWSZlyOvzxxv4aB7K8HXKyMqsyIhTHT/qeG/HzvNq6xTMlMS7L /zjZ15hrOoQDWnfgbROkR6Y/OXxpgh2TMedaO4zrUFs43avAw8X7gJU13QCvf3wfFSEe aD0ca/5qmqn/zE3rjPpEmxbOXTeZYLqYfszBkSeJT7fwKy0Rf+zLF0F791YAzuPjlsoZ 1TJQ== X-Forwarded-Encrypted: i=1; AJvYcCXXtRtCGy9fzMaZ9yKNYzPktVMfrxlAAKKvjPJflOaUtzWE+zXhaN9KnL2TrZaHmMzMzU2XNA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwAq8wLYQ+VyBfZ3zFf7wEEGSPpTtPRmyIbfPEt7RY/5gDe3tj1 /8Qay/2DbMZ8VE1fVqe6nUayj6ADrwOoSbUCCpGOrKorI7nt+7MwIqF5cg== X-Google-Smtp-Source: AGHT+IHBCUiNDHAYpiM4z3Gfbicgp7TKPL/7zsledZL/WoHulf8IEJUegT5TffTdbJnltNUMkNvY1g== X-Received: by 2002:a05:600c:138a:b0:431:5c17:d575 with SMTP id 5b1f17b1804b1-432b750274fmr67964395e9.11.1731236169649; Sun, 10 Nov 2024 02:56:09 -0800 (PST) Original-Received: from pro2 (p4fe3a255.dip0.t-ipconnect.de. [79.227.162.85]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432b05c2161sm136523675e9.31.2024.11.10.02.56.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Nov 2024 02:56:09 -0800 (PST) In-Reply-To: ("Gerd =?UTF-8?Q?M=C3=B6llmann?="'s message of "Sat, 09 Nov 2024 09:26:23 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295178 Archived-At: Gerd M=C3=B6llmann writes: > Eli Zaretskii writes: > >> Should this perhaps have an eassert which verifies that every glyph >> has a valid frame pointer? At the very least please add a comment >> there explaining the need for the enabled_p test and mentioning the >> frame pointer of the glyphs. > > I don't know. It's one of the most basic things about the meaning of > enabled_p in current glyphs, and it's not limited the frame pointer in > any way. Found another case of copying from non-enabled glyphs. Reproducable with emacs -q -l with a file containing (with-current-buffer (get-buffer-create "1") (setq header-line-format '((:eval (format "*package*: - symbol-packages: - lexical-bindin= g: %s" lexical-binding))))) (with-current-buffer (get-buffer-create "2") (insert "something")) (let ((w1 (selected-window)) (w2 (split-window-right))) (set-window-buffer w1 (get-buffer "1")) (set-window-buffer w2 (get-buffer "2")) (message "message")) It's a 30 years old bug, so it isn't something urgent to fix. I'll port something to savannah as soon as I find the time.