From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#74966: 31.0.50; Crash report (using igc on macOS) Date: Fri, 20 Dec 2024 09:43:26 +0100 Message-ID: References: <87y10b99nj.fsf@protonmail.com> <87plln9376.fsf@protonmail.com> <874j2z8ook.fsf@protonmail.com> <86a5cqkc2g.fsf@gnu.org> <86o716ah09.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17282"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: spd@toadstyle.org, pipcet@protonmail.com, acorallo@gnu.org, Stefan Monnier , 74966@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 20 09:45:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tOYdP-0004K6-AB for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Dec 2024 09:45:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOYd7-00048N-BX; Fri, 20 Dec 2024 03:45:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOYd5-000466-7b for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2024 03:45:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOYd4-0000Si-Uh for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2024 03:45:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=7l2mHmOXHDgMW4kq+cNW+VKmsypmQtxrWyJ5x78wx58=; b=ltN5uf/1amGBGLVr8zXWXKxSKJnq06e/PnRCnRNOZzlcQ9SkWPerVKVBiLM+0qyqiW17iWQw4AD0Ic+AN+hWC11VGPQdoyjmLYVn7MYra9fRTkzWupUPEYf5UdmhyMpzB2Yi3bUo+M7LkdtvrfllvC4oMVYA6QSQKf5Tj0JuAW+Qx1zJDlYoD5arrjaKl2Xz/5BE68K0JBtP3s/jzzg6rEArEGvzgH9LvJE8LyayS+fDjuv4daxT/sbGpfS7G0sUvoL8D9gdjijOdLhF827p8lxFuMBNrGTB9a4Dr8uIVxV9bFn2RtIgk6ks4VMl4f2yW5h7Xhyg5O3h0nrOFuB97A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tOYd3-0003vK-OU for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2024 03:45:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Dec 2024 08:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74966 X-GNU-PR-Package: emacs Original-Received: via spool by 74966-submit@debbugs.gnu.org id=B74966.173468427715032 (code B ref 74966); Fri, 20 Dec 2024 08:45:01 +0000 Original-Received: (at 74966) by debbugs.gnu.org; 20 Dec 2024 08:44:37 +0000 Original-Received: from localhost ([127.0.0.1]:41607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOYce-0003uN-Qr for submit@debbugs.gnu.org; Fri, 20 Dec 2024 03:44:37 -0500 Original-Received: from mail-ej1-f49.google.com ([209.85.218.49]:57390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOYcc-0003u5-Ce for 74966@debbugs.gnu.org; Fri, 20 Dec 2024 03:44:35 -0500 Original-Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-aab6fa3e20eso283479066b.2 for <74966@debbugs.gnu.org>; Fri, 20 Dec 2024 00:44:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734684208; x=1735289008; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7l2mHmOXHDgMW4kq+cNW+VKmsypmQtxrWyJ5x78wx58=; b=aphC/qvIXjKdinFitUzXd3AyANQ5lIjBgRYDFlpL4jwfemL360+EK6roFUHNNKtSZy B2jEI8aNn8y8gBTIoKFLSIYoSL2o6O0iUFWDx1o4PVQjWYb2hHtJMXAmV7LiYGlchMS2 lU/63Til4h5qIAZoW7NfVrW34RxYSbmbYUfBF48xEEzQWJ/vogAB0pJGw9IvJlMQEq1G KfgDUv9n6HnC2gME7Ut+d24WP0gl8GVRVYhC5stLfhZfWwVYEq9PsHaEEDHkmAk3vewE KOVh7ODNl4KmPaqTYFcNJBsjfp9SYqC4sbCTUaMq/8ywZZu40KyK25FfBOUPGASW+QqQ KHQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734684208; x=1735289008; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7l2mHmOXHDgMW4kq+cNW+VKmsypmQtxrWyJ5x78wx58=; b=V1Un3DEwti3E7EKR0rMVgXpSFgrAnrcVS5UDFnAklxOEu1wMyjKJyRfAusVmTcSPLg wMMIW7M8dnL9Vmdzp4j3xUqR+vpVJ+6RqA1WU5LPzhOB15AiV4nYLjuJELM9INuSyyDs l2QI5q9jn7rl272v+LDel22pYpOJCRB+MA8K2tEbeq3NPKu/XWbQ7JhIttmU5TNieOcn LAilQ+2v6bG2e0SFIlC3gsoI0s3fuGRNmr5/V4DWMl46MzFLUUAcEJBxrfR/VihdZheG WoTplJvd1DkwK6cwtaiCsS6GL64NoBB6T6er/yMCCqJnMIdykjpJDHLK6YSVZ0vEtvvP hSaw== X-Forwarded-Encrypted: i=1; AJvYcCVXslSo31+tgEOXb0uwvigfYBNomPfRtufSJNAUR0oSjymsO3uA4IJlAUTeCXsr0pu+1gwUhg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwbAOpvnF6g/7gDT1B9ZbYT2Ba+WbUyMkbv509BB/73T/EhUBrT U4thZvtmJXCTEooJ25q4WgvIt6L+jo10JpnSajdHqRNFjC5qPIYVnbHleA== X-Gm-Gg: ASbGnctTRNazlH61a1JbqomQ/tJYyxqZs0rRn40vRnBJa2tPre+fsbzUMYeFRMZ8ITQ Kux0gkqt4GfVnJnDW3Ql1/98ShNeKmSKR9dzdFZc7u3OFR2prHZ8NclqGzU+ZS3L8d1iygU6ggs cfSiq1bFcGtwRUvLWlYn5KmDedH0THzAcQo8YMlNp6zaSmIzkDUjeX45Ax9jU/RfSL34mZzpBUq K7Ev0Z1PdDKm4+bASc+22M8ACTMSaJQjUOhtKO6mu82k6uT7/nyI0CVnTa3piQK4H/rOAmrupd0 zrqlHO5uP9U2B/crvl2q85EK2ykraVHJx1m9LqIcmNZPZxq9bdPNIcnHnxmScNWWPQ== X-Google-Smtp-Source: AGHT+IG96JFpDCZhlsPeUnIvPFjYhEnKFK5VO3VreUVAEWTkR1hduPb3N1dyjm4EaLgwPwNZ4hgGDw== X-Received: by 2002:a17:906:c145:b0:aa6:832b:8d76 with SMTP id a640c23a62f3a-aac2d447677mr151946966b.12.1734684207997; Fri, 20 Dec 2024 00:43:27 -0800 (PST) Original-Received: from pro2 (p200300e0b70a560050feb175441df3ce.dip0.t-ipconnect.de. [2003:e0:b70a:5600:50fe:b175:441d:f3ce]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0e8953b6sm154321866b.65.2024.12.20.00.43.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Dec 2024 00:43:27 -0800 (PST) In-Reply-To: <86o716ah09.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Dec 2024 10:35:50 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297443 Archived-At: Eli Zaretskii writes: >> From: Gerd M=C3=B6llmann >> Cc: Andrea Corallo , pipcet@protonmail.com, >> spd@toadstyle.org, 74966@debbugs.gnu.org >> Date: Fri, 20 Dec 2024 09:21:38 +0100 >>=20 >> Eli Zaretskii writes: >>=20 >> >> Cc: spd@toadstyle.org, 74966@debbugs.gnu.org >> >> From: Gerd M=C3=B6llmann >> >> Date: Fri, 20 Dec 2024 08:30:55 +0100 >> >>=20 >> >> Gerd M=C3=B6llmann writes: >> >>=20 >> >> > I think I'll read the code a bit now. >> >>=20 >> >> BTW, does C-h f x-file-dialog work on platforms !=3D macOS? >> > >> > In what version of Emacs? and with or without native compilation? >>=20 >> master with native compilation, if possible with --enable-checking. >>=20 >> > >> > It works here as follows: >> > >> > . On MS-Windows: >> > - emacs 31 without native compilation >> > - emacs 30 with and without native compilation >> > . On GNU/Linux: >> > - emacs 31 with and without native compilation >> > - emacs 30 with and without native compilation >> > >> >> It aborts here for the same reason. >> >>=20 >> >> And I'm asking myself now why the heck it lands in native_function_do= c in >> >> the first place. Isn't x-file-dialog a C function everywhere? >> > >> > It is a C function, yes. >>=20 >> My current theory is that one needs to C-h f a function with a doc >> string lie this one: >>=20 >> (defun x-file-dialog (prompt dir &optional default-filename >> mustmatch only-dir-p) >> "SKIP: real doc in xfns.c." >> (ns-read-file-name prompt dir mustmatch default-filename only-dir-p)) >>=20 >> And the function must be native-comp-function-p. >>=20 >> I can't see so far how/where such "redirections" are handled. > > AFAIR, the doc string is in etc/DOC, and is collected by > lib-src/make-docfile. That program scans the C source according to > what src/Makefile tells is (see the $(etc)/DOC rule there), so it > doesn't care whether xfns.c is or isn't compiled into the binary. Yes, that matches what I remember from the old times. > But we had many changes lately in how etc/DOC is handled, and maybe my > memory is no long accurate. So I added Stefan to this discussion, who > made at least some of those DOC-related changes. Maybe the problem is in store_doc_string (doc.c:469 here), not sure. That function does if (SUBRP (fun)) XSUBR (fun)->doc =3D offset; without checking if it's a native compiled function. That does look like a place where an invalid offset could land in the subr. I have no idea what's the right thing to do to fix this. Just not doing anything for native compiled function certainly isn't right.