From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: CHENG Gao Newsgroups: gmane.emacs.devel Subject: Re: Carbon port emacs-unicode-2 build problem under MacOSX Date: Thu, 08 Nov 2007 02:30:45 +0800 Organization: cyberhut.org Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1194462118 1233 80.91.229.12 (7 Nov 2007 19:01:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 7 Nov 2007 19:01:58 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 07 20:02:02 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IpqA5-0000YB-PC for ged-emacs-devel@m.gmane.org; Wed, 07 Nov 2007 20:02:02 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ipq9u-00051s-JE for ged-emacs-devel@m.gmane.org; Wed, 07 Nov 2007 14:01:50 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ipq99-0004OS-Gc for emacs-devel@gnu.org; Wed, 07 Nov 2007 14:01:03 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ipq98-0004ME-1U for emacs-devel@gnu.org; Wed, 07 Nov 2007 14:01:02 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ipq97-0004Ls-RN for emacs-devel@gnu.org; Wed, 07 Nov 2007 14:01:01 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IppgP-0003SP-Bh for emacs-devel@gnu.org; Wed, 07 Nov 2007 13:31:21 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1IppgH-0000vW-Po for emacs-devel@gnu.org; Wed, 07 Nov 2007 18:31:13 +0000 Original-Received: from 222.94.199.252 ([222.94.199.252]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 07 Nov 2007 18:31:13 +0000 Original-Received: from chenggao by 222.94.199.252 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 07 Nov 2007 18:31:13 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 59 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 222.94.199.252 User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.0 (darwin) Cancel-Lock: sha1:4CWHdGcFRid16qmDJITz1O4fEK8= X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82766 Archived-At: > I reported twice before about failing owing to undefined symbols in > macterm.c. The problem is from new mac_set_unicode_keystroke_event > introduced by June 7 checkin (revision 1.47.2.56, Wed Jun 7 18:04:51 > 2006 UTC). > > The code: ,---- > | static void mac_set_unicode_keystroke_event (code, buf) UniChar code; > | struct input_event *buf; { int charset_id, c1, c2; > | > | if (code < 0x80) { > | buf->kind = ASCII_KEYSTROKE_EVENT; > | buf->code = code; > | } > | else if (code < 0x100) { if (code < 0xA0) charset_id = > | CHARSET_8_BIT_CONTROL; else charset_id = charset_latin_iso8859_1; > | buf->kind = MULTIBYTE_CHAR_KEYSTROKE_EVENT; > | buf->code = MAKE_CHAR (charset_id, code, 0); > | } > | else { if (code < 0x2500) charset_id = > | charset_mule_unicode_0100_24ff, code -= 0x100; else if (code < 0x33FF) > | charset_id = charset_mule_unicode_2500_33ff, code -= 0x2500; else if > | (code >= 0xE000) charset_id = charset_mule_unicode_e000_ffff, code -= > | 0xE000; c1 = (code / 96) + 32, c2 = (code % 96) + 32; > | buf->kind = MULTIBYTE_CHAR_KEYSTROKE_EVENT; > | buf->code = MAKE_CHAR (charset_id, c1, c2); > | } > | } > `---- > > CHARSET_8_BIT_CONTROL, charset_mule_unicode_0100_24ff, > charset_mule_2500_33ff, charset_mule_unicode_e000_ffff used here are > defined in any place. > > I reverted this funciton to previous as: ,---- > | static void mac_set_unicode_keystroke_event (code, buf) UniChar code; > | struct input_event *buf; { int charset_id, c1, c2; > | > | if (code < 0x80) > | buf->kind = ASCII_KEYSTROKE_EVENT; > | else > | buf->kind = MULTIBYTE_CHAR_KEYSTROKE_EVENT; > | buf->code = code; } > `---- I did another test. I checked out Aug. 8 source (right before multi-tty merge), and reverted mac_set_unicode_keystroke_event as described above. It builds and works well. So: 1. The culprit is multi-tty merge It's reconfirmation to confirmed suspicion. 2. Function mac_set_unicode_keystroke_event should be reverted. 3. I am glad I upgraded my emacs-unicode-2 Carbon port from June 6 source to Aug. 28. 83 days after D-day brought me more peace. -- Volo, non valeo