From: CHENG Gao <chenggao@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: Carbon port emacs-unicode-2 build problem under MacOSX
Date: Thu, 08 Nov 2007 02:30:45 +0800 [thread overview]
Message-ID: <m2bqa5nc16.fsf@news.cyberhut.org> (raw)
In-Reply-To: m21wb3vayb.fsf@news.cyberhut.org
> I reported twice before about failing owing to undefined symbols in
> macterm.c. The problem is from new mac_set_unicode_keystroke_event
> introduced by June 7 checkin (revision 1.47.2.56, Wed Jun 7 18:04:51
> 2006 UTC).
>
> The code: ,----
> | static void mac_set_unicode_keystroke_event (code, buf) UniChar code;
> | struct input_event *buf; { int charset_id, c1, c2;
> |
> | if (code < 0x80) {
> | buf->kind = ASCII_KEYSTROKE_EVENT;
> | buf->code = code;
> | }
> | else if (code < 0x100) { if (code < 0xA0) charset_id =
> | CHARSET_8_BIT_CONTROL; else charset_id = charset_latin_iso8859_1;
> | buf->kind = MULTIBYTE_CHAR_KEYSTROKE_EVENT;
> | buf->code = MAKE_CHAR (charset_id, code, 0);
> | }
> | else { if (code < 0x2500) charset_id =
> | charset_mule_unicode_0100_24ff, code -= 0x100; else if (code < 0x33FF)
> | charset_id = charset_mule_unicode_2500_33ff, code -= 0x2500; else if
> | (code >= 0xE000) charset_id = charset_mule_unicode_e000_ffff, code -=
> | 0xE000; c1 = (code / 96) + 32, c2 = (code % 96) + 32;
> | buf->kind = MULTIBYTE_CHAR_KEYSTROKE_EVENT;
> | buf->code = MAKE_CHAR (charset_id, c1, c2);
> | }
> | }
> `----
>
> CHARSET_8_BIT_CONTROL, charset_mule_unicode_0100_24ff,
> charset_mule_2500_33ff, charset_mule_unicode_e000_ffff used here are
> defined in any place.
>
> I reverted this funciton to previous as: ,----
> | static void mac_set_unicode_keystroke_event (code, buf) UniChar code;
> | struct input_event *buf; { int charset_id, c1, c2;
> |
> | if (code < 0x80)
> | buf->kind = ASCII_KEYSTROKE_EVENT;
> | else
> | buf->kind = MULTIBYTE_CHAR_KEYSTROKE_EVENT;
> | buf->code = code; }
> `----
I did another test. I checked out Aug. 8 source (right before multi-tty
merge), and reverted mac_set_unicode_keystroke_event as described above.
It builds and works well.
So:
1. The culprit is multi-tty merge
It's reconfirmation to confirmed suspicion.
2. Function mac_set_unicode_keystroke_event should be reverted.
3. I am glad I upgraded my emacs-unicode-2 Carbon port from June 6
source to Aug. 28. 83 days after D-day brought me more peace.
--
Volo, non valeo
prev parent reply other threads:[~2007-11-07 18:30 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-06 12:02 Carbon port emacs-unicode-2 build problem under MacOSX CHENG Gao
2007-11-06 12:14 ` CHENG Gao
2007-11-06 12:29 ` Kenichi Handa
2007-11-06 13:52 ` CHENG Gao
2007-11-06 19:28 ` Ted Zlatanov
2007-11-06 23:27 ` Glenn Morris
2007-11-07 4:59 ` Ted Zlatanov
2007-11-07 13:19 ` Carbon port vs. Emacs.app plus Emacs.app problem report w/test-case Mike Mattie
2007-11-07 13:54 ` Ted Zlatanov
2007-11-07 15:45 ` Mike Mattie
2007-11-06 12:34 ` Carbon port emacs-unicode-2 build problem under MacOSX Jason Rumney
2007-11-06 13:58 ` CHENG Gao
2007-11-06 19:26 ` Ted Zlatanov
2007-11-07 4:13 ` YAMAMOTO Mitsuharu
2007-11-07 5:24 ` Ted Zlatanov
2007-11-07 5:52 ` YAMAMOTO Mitsuharu
2007-11-07 6:03 ` YAMAMOTO Mitsuharu
2007-11-07 14:19 ` Ted Zlatanov
2007-11-07 14:34 ` Jason Rumney
[not found] ` <m2abpqt5mm.fsf@lifelogs.com>
2007-11-07 16:40 ` Adrian Robert
2007-11-08 4:42 ` Richard Stallman
2007-11-08 1:27 ` YAMAMOTO Mitsuharu
2007-11-08 2:31 ` YAMAMOTO Mitsuharu
2007-11-24 9:18 ` YAMAMOTO Mitsuharu
2008-02-12 0:59 ` YAMAMOTO Mitsuharu
2007-11-07 14:15 ` Adrian Robert
2007-11-07 15:05 ` Jason Rumney
2007-11-07 16:09 ` Stefan Monnier
2007-11-08 4:42 ` Richard Stallman
2007-11-08 15:56 ` Dan Nicolaescu
2007-11-09 4:12 ` Richard Stallman
2007-11-09 7:47 ` Dan Nicolaescu
2007-11-09 10:34 ` Eli Zaretskii
2007-11-09 15:09 ` Dan Nicolaescu
2007-11-10 17:54 ` Richard Stallman
2007-11-12 5:17 ` How to re-orgranize ChangeLog.unicode for merging Kenichi Handa
2007-11-12 20:22 ` Eli Zaretskii
2007-11-12 22:17 ` Andreas Schwab
2007-11-13 4:08 ` Eli Zaretskii
2007-11-18 22:47 ` Richard Stallman
2007-11-18 22:47 ` Richard Stallman
2007-11-07 16:14 ` Carbon port emacs-unicode-2 build problem under MacOSX Dan Nicolaescu
2007-11-08 4:42 ` Richard Stallman
2007-11-07 18:30 ` CHENG Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2bqa5nc16.fsf@news.cyberhut.org \
--to=chenggao@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.