From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.bugs Subject: bug#28818: kmacro stepping: void-variable kmacro-step-edit-active Date: Mon, 16 Oct 2017 20:39:39 +0200 Message-ID: References: <83a80ukgsp.fsf@gnu.org> <83infff3p7.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1508179217 14322 195.159.176.226 (16 Oct 2017 18:40:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 16 Oct 2017 18:40:17 +0000 (UTC) Cc: 28818@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 16 20:40:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4AJ3-0002BE-6m for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Oct 2017 20:40:05 +0200 Original-Received: from localhost ([::1]:34665 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4AJA-0000W4-N4 for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Oct 2017 14:40:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4AJ5-0000Vz-Cb for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 14:40:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4AJ1-0001vb-9C for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 14:40:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35558) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e4AJ1-0001u5-4Z for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 14:40:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e4AJ0-00008b-Jf for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 14:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Oct 2017 18:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28818 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28818-submit@debbugs.gnu.org id=B28818.1508179189506 (code B ref 28818); Mon, 16 Oct 2017 18:40:02 +0000 Original-Received: (at 28818) by debbugs.gnu.org; 16 Oct 2017 18:39:49 +0000 Original-Received: from localhost ([127.0.0.1]:44239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4AIn-000086-25 for submit@debbugs.gnu.org; Mon, 16 Oct 2017 14:39:49 -0400 Original-Received: from sinyavsky.aurox.ch ([37.35.109.145]:55019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4AIk-00007q-In for 28818@debbugs.gnu.org; Mon, 16 Oct 2017 14:39:47 -0400 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 352C222578 for <28818@debbugs.gnu.org>; Mon, 16 Oct 2017 18:32:57 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1508178774; x=1509042775; bh=9AJkJtyTbMPcw 9+YgUGDt/6U++wMpFMNp1ysU4Ebb6c=; b=EZFb7xRiDwooQx1chZfl90AzzXsH+ 0J+nVdBu47xmQvPSgbqcmkkrQOpZgli5yl1XP5m1fHmMFNshRMF9OXsDGaUtxNKv 5mVl5FDKMyeswUe370Kc14nv1lNGrVa1gsed5cuegqDCMUKwtnRaySeAQfcgbX1n 7i8EnPogCBAzI8= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id UTMmaenhUh0R for <28818@debbugs.gnu.org>; Mon, 16 Oct 2017 18:32:54 +0000 (UTC) Original-Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 6494C22567; Mon, 16 Oct 2017 18:32:54 +0000 (UTC) In-reply-to: <83infff3p7.fsf@gnu.org> (message from Eli Zaretskii on Mon, 16 Oct 2017 19:38:28 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138547 Archived-At: > Date: Mon, 16 Oct 2017 19:38:28 +0300 > From: Eli Zaretskii > > merge 18708 28818 > close 28818 > thanks > > > Date: Sun, 15 Oct 2017 20:40:49 +0200 > > From: charles@aurox.ch (Charles A. Roelli) > > CC: 28818@debbugs.gnu.org > > > > > Does the below fix this? > > > > > > diff --git a/lisp/kmacro.el b/lisp/kmacro.el > > > index 582a58e..4abc571 100644 > > > --- a/lisp/kmacro.el > > > +++ b/lisp/kmacro.el > > > @@ -937,7 +937,7 @@ kmacro-edit-lossage > > > > > > ;;; Single-step editing of keyboard macros > > > > > > -(defvar kmacro-step-edit-active) ;; step-editing active > > > +(defvar kmacro-step-edit-active nil) ;; step-editing active > > > (defvar kmacro-step-edit-new-macro) ;; storage for new macro > > > (defvar kmacro-step-edit-inserting) ;; inserting into macro > > > (defvar kmacro-step-edit-appending) ;; append to end of macro > > > > Yes it does. Thanks. > > Thanks, pushed. As a nice bonus, one more kmacro test now succeeds, > as this bug is a duplicate of bug#18708. Good catch! Thanks for your help with this.