From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.bugs Subject: bug#34723: 27.0.50; customize and improve diff-mode recentering Date: Tue, 05 Mar 2019 20:49:13 +0100 Message-ID: References: <8336o1e33w.fsf@gnu.org> Reply-To: charles@aurox.ch Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="42823"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34723@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 05 20:38:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1FtC-000B16-OE for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Mar 2019 20:38:10 +0100 Original-Received: from localhost ([127.0.0.1]:48290 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1FtB-0001UO-PL for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Mar 2019 14:38:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1Ft5-0001Su-Dy for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2019 14:38:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1Ft4-0007Xl-Lk for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2019 14:38:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48160) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1Ft4-0007XE-HL for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2019 14:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h1Ft4-000628-27 for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2019 14:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Mar 2019 19:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34723 X-GNU-PR-Package: emacs Original-Received: via spool by 34723-submit@debbugs.gnu.org id=B34723.155181463423130 (code B ref 34723); Tue, 05 Mar 2019 19:38:02 +0000 Original-Received: (at 34723) by debbugs.gnu.org; 5 Mar 2019 19:37:14 +0000 Original-Received: from localhost ([127.0.0.1]:33471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h1FsH-000610-Qj for submit@debbugs.gnu.org; Tue, 05 Mar 2019 14:37:14 -0500 Original-Received: from nestroy.aurox.ch ([82.195.237.20]:35006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h1FsF-00060k-CX for 34723@debbugs.gnu.org; Tue, 05 Mar 2019 14:37:12 -0500 Original-Received: from nestroy.aurox.ch (nestroy.aurox.ch [127.0.0.1]) by nestroy.aurox.ch (Postfix) with ESMTP id 44DRwx2Sv4zlps for <34723@debbugs.gnu.org>; Tue, 5 Mar 2019 19:37:05 +0000 (UTC) Authentication-Results: nestroy.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:reply-to:subject:subject:in-reply-to:to:from:from :message-id:date:date; s=dkim2; t=1551814623; x=1554406624; bh=0 TJWtsK43LWXafFE9u3aV4NpzDfwyLI2JLF7A9YA6Bw=; b=iM0OZPpD+cD26dZVD xqiEZdgyqxbm9ZrdPiUyYnfE+re8k4cd29Lbp+Fs2GFp5ulk7wFPP7QdsDOtsg8o n4WNdOaRwtWL+InnZx0oEMgPKoFbVKMrn+YG81AX2GCIGw//LftefZA9QcRfAB8e eP3kyRE1RiNrhraSwFefX7OYHk= X-Virus-Scanned: Debian amavisd-new at nestroy.aurox.ch Original-Received: from nestroy.aurox.ch ([127.0.0.1]) by nestroy.aurox.ch (nestroy.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id BlwKwJjW6GDK for <34723@debbugs.gnu.org>; Tue, 5 Mar 2019 19:37:03 +0000 (UTC) Original-Received: from gray (unknown [IPv6:2a02:1206:4512:5f50:c62c:3ff:fe30:b864]) by nestroy.aurox.ch (Postfix) with ESMTPSA id 44DRwv3pqVzlpd; Tue, 5 Mar 2019 19:37:03 +0000 (UTC) In-reply-to: <8336o1e33w.fsf@gnu.org> (message from Eli Zaretskii on Tue, 05 Mar 2019 17:46:11 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156066 Archived-At: > Date: Tue, 05 Mar 2019 17:46:11 +0200 > From: Eli Zaretskii > CC: 34723@debbugs.gnu.org > > I've read this description and that in bug#32991, several times, and I > still cannot figure out whether you are saying that there's a problem > in recentering per se (and in the related redisplay code), or you are > saying that diff-mode does something in its application code that > indirectly and inadvertently causes unwarranted recentering. Could > you please clarify which is the case here? Depending on that, the > solution should be either in diff-mode or in the display engine > (however, I have hard time believing that we have use cases where the > display engine ignores scroll-related variables). > > Thanks. The function diff-hunk-next is defined using the macro easy-mmode-define-navigation, and its definition calls (recenter '(0)) too liberally. The call also ignores settings like 'scroll-conservatively'. The display engine is not at fault, and we should be able to fix the issue either in easy-mmode or in diff-mode.