From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#37221: 27.0.50; gnus fails to open connection post-NSM update Date: Wed, 04 Sep 2019 17:04:37 +0200 Message-ID: References: <87k1avgbb8.fsf@gmail.com> <871rwxfd7w.fsf@gmail.com> <87sgpcdx0p.fsf@gmail.com> <87ftlcdvxh.fsf@gnus.org> <87h85sduuw.fsf@gmail.com> <87sgpccdk8.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="176800"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37221@debbugs.gnu.org, Alex Branham To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 04 17:05:50 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i5Wqz-000jok-QM for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Sep 2019 17:05:49 +0200 Original-Received: from localhost ([::1]:34200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5Wqy-0000Sr-No for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Sep 2019 11:05:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56150) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5WqG-0008OR-B3 for bug-gnu-emacs@gnu.org; Wed, 04 Sep 2019 11:05:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i5WqF-0003oY-8Q for bug-gnu-emacs@gnu.org; Wed, 04 Sep 2019 11:05:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53577) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i5WqF-0003o2-4Z for bug-gnu-emacs@gnu.org; Wed, 04 Sep 2019 11:05:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i5WqE-0004f7-UR; Wed, 04 Sep 2019 11:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Wed, 04 Sep 2019 15:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37221 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 37221-submit@debbugs.gnu.org id=B37221.156760948917878 (code B ref 37221); Wed, 04 Sep 2019 15:05:02 +0000 Original-Received: (at 37221) by debbugs.gnu.org; 4 Sep 2019 15:04:49 +0000 Original-Received: from localhost ([127.0.0.1]:34162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i5Wq0-0004eC-Mg for submit@debbugs.gnu.org; Wed, 04 Sep 2019 11:04:48 -0400 Original-Received: from mail-wm1-f45.google.com ([209.85.128.45]:34792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i5Wpx-0004dm-2m for 37221@debbugs.gnu.org; Wed, 04 Sep 2019 11:04:45 -0400 Original-Received: by mail-wm1-f45.google.com with SMTP id y135so2746484wmc.1 for <37221@debbugs.gnu.org>; Wed, 04 Sep 2019 08:04:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=ZhyGetIEk02QYu5AYsoYobVyC9q9t+/Mk/92iB91Zh0=; b=Hzae+qjEqw5qmEq3cWUi1DU6KUCGsEGW4dkn81izfxrg2gdsAACVwco78UAUKzevph sFcQpOnQZmxmkdzkUD0PYKMd+RC/Qx4B+K5CaJGKsnqp8or2I7pW3CvoZRc2H1RgsEq8 yxIOsh90FucNjUbe8TQuIeK3SNGGwTxfDrKVzf3zrKS5AyFdowQwAJO0MC5HeBvmH7Cd BWKlv+X6Orz13P134LWG1a0icYBbKW00515rGDrSnqS3mlMxC+xEG/jyDOqcZbFaMbdO 2UR3/N+olJf9lWyrYc3tpCGZrfq22/4FxgVFoCbQ7UkZGncS9Go3dNDICbdS7ygY8NXZ 7fxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=ZhyGetIEk02QYu5AYsoYobVyC9q9t+/Mk/92iB91Zh0=; b=lbwaePx414zYSp0fzIZJABzoIKRRdEytLdNaddbPP6jyiFsnve/wZ1hKDhL+T9Iewr 80v3wK0chjLgzS+hQ5ZiCRxvisD/TV+s28Ap0YJLrH6XpsRIc6PbEFsYceWD81iWTp7e 6IJJDHd8nBEKrxS3Yxl2sf46TxhIbl8+AKMxScSPjWdza221bQ3DjpYZIde6VY88o1Cd BPbdLLYKsgR2lwJW/4kn1qMA+ZoF+jr40Jw0IIfdIL7snYO+OLhlPLEyMlStaZfpwi5f 3D4Fhk+rD67p4yC43iVVpBrAM/VPFabMe0PI4HRD0KNcqnKbTPcQl4beVBthJpUYRJnO GFAg== X-Gm-Message-State: APjAAAXbCnhaHxn7arDHcPWD4FdV9+UfCm6XYByZGOPlwdqWfZnG6X/a YFe8j91wLeG/M/+z6vX/+ojc6yus X-Google-Smtp-Source: APXvYqxu2siEosdiXYUVN0kj4fOp5/UtyV+jgYn4f7UTx24jVWotUwEUssi30XEqXay2qb5JgwXkCA== X-Received: by 2002:a1c:f703:: with SMTP id v3mr4695910wmh.107.1567609478952; Wed, 04 Sep 2019 08:04:38 -0700 (PDT) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id m17sm22427056wrs.9.2019.09.04.08.04.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2019 08:04:37 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <87sgpccdk8.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 04 Sep 2019 16:59:35 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166206 Archived-At: >>>>> On Wed, 04 Sep 2019 16:59:35 +0200, Lars Ingebrigtsen said: Lars> Robert Pluim writes: >> I=CA=BCve spotted one possible problem: nsm-query runs even when the >> connection is unencrypted, which ends up doing (insert nil), which >> aborts the connection. Does the following help? (Lars, why is nsm >> prompting for unencrypted connections?) Lars> It runs for all kinds of connections -- a non-encrypted one could= , for Lars> instance, be one that's a result of a downgrade attack. Lars> So if it now assumes that the connection is always encrypted, tha= t's a Lars> new bug. Hm... anybody know of a server that absolutely not doe= sn't Lars> have STARTTLS that I can test with? :-) Not quite. nsm-query-user assumes that status is non-nil, which is not the case in my test, which was imap to localhost. It never gets the chance to emit STARTTLS, since nsm has already killed the connection: (defun nsm-query-user (message status) (let ((buffer (get-buffer-create "*Network Security Manager*")) (cert-buffer (get-buffer-create "*Certificate Details*")) (certs (plist-get status :certificates))) (save-window-excursion ;; First format the certificate and warnings. (with-current-buffer-window buffer nil nil (insert (nsm-format-certificate status)) <=3D status is nil here, which gives us "(wrong-type-argument char-or-string-p nil)", which causes nsm-query to kill the connection. Robert