From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Allow hiding stashes from vc-dir Date: Fri, 18 Oct 2019 16:07:33 +0200 Message-ID: References: <831rvegnub.fsf@gnu.org> <871rvex9ue.fsf@mail.linkov.net> <87eezdpjh4.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="232897"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Lars Ingebrigtsen , Juri Linkov , Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 18 16:11:42 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iLSyj-000yTZ-Q5 for ged-emacs-devel@m.gmane.org; Fri, 18 Oct 2019 16:11:41 +0200 Original-Received: from localhost ([::1]:40656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLSyi-0006Zb-De for ged-emacs-devel@m.gmane.org; Fri, 18 Oct 2019 10:11:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58183) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLSuq-00013v-BP for emacs-devel@gnu.org; Fri, 18 Oct 2019 10:07:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLSup-00066n-B6 for emacs-devel@gnu.org; Fri, 18 Oct 2019 10:07:40 -0400 Original-Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:39377) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iLSup-00065K-4p; Fri, 18 Oct 2019 10:07:39 -0400 Original-Received: by mail-wr1-x443.google.com with SMTP id r3so6437139wrj.6; Fri, 18 Oct 2019 07:07:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=fszpc8PWWnS2MjrBgp+6nFGnw0LqfstZfgD0Rdis3T0=; b=Ld7qvMPgGl9Xa9Ok365QEMwPi2oM8ygrApqORsZQ2nNIYloaQeNCNQthwVGk8abRrL obmpDG2DKiWNbcwk5ggsfWEFSKCWAOrewRj4eJDAlNHlDVXs2U8sjEuZ9h4Bjx3dusLJ WYfAevYxEaVVhgjK8QCk5oZ5ZbuLDbYGb/Tbak0ZPnM9RZDATPXyuugJ/Kynqtd2YEIt Cg622kiChRmqC9GqZjCbMQ/sC03mmZlGNCNzFFamhtlish4P4qjZ0DDmmIHgcdpXEL9h Ze3RcO+dY9FsrzwvVbyzbveKsBRdl8/54gXpiDuekkOklqKQinds3UpGWsE7pRqoSulz k49A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=fszpc8PWWnS2MjrBgp+6nFGnw0LqfstZfgD0Rdis3T0=; b=M1dSKqbxK9fg86m8yhfbZH0Uq48VNLL1cfdOqvuaVM6CNIoNu0sYM4K2tUkOsqAE0R QxX0EG1KTgBLA50vvU2tcFCfwyyFEj8sFotZStasyGEYz0tz/cCkXeZRtZNN5G+8Ur3A m7jjzkCjep9nv5kyaM6MQLoWfyyFJUcESY1T8ScZZoxdMVaJOgsGVq7VdPPPKeyV5FvD jDl08SlTOi9GeebgzxNXpAvKMal4a4jZ39i7wftni2YzxqIK70gjNUBxYrFWsyQHECid VyK9Cw0P365ZDiHvIpmX8VudJW4Z54iClTztA+sZV2CDuhPchHpImRCJuAxmXqU7oHPV 6TcQ== X-Gm-Message-State: APjAAAXVye/1e7ApVBVqUjRVa2/QNyWawvn1TJ9ljLKuzSr9imrQ+9ff s+SLqmnVjQpit1LME/U22h8= X-Google-Smtp-Source: APXvYqynCV0lf+ByNMJ+nDEBlLIpy+HLnFlqD+21bD9lJTOlC8KD17+2jrKW5+vJFU65O8sFAF3zuw== X-Received: by 2002:adf:f24c:: with SMTP id b12mr8636039wrp.82.1571407657422; Fri, 18 Oct 2019 07:07:37 -0700 (PDT) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id q66sm6488188wme.39.2019.10.18.07.07.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 07:07:36 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: (Stefan Monnier's message of "Fri, 18 Oct 2019 09:22:22 -0400") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241208 Archived-At: >>>>> On Fri, 18 Oct 2019 09:22:22 -0400, Stefan Monnier said: >> +(declare-function cl-subseq "cl-extra" (seq start &optional end)) Stefan> Wrong fix: if you want to use cl-lib functions, then you need to Stefan> (require 'cl-lib) outside of an eval-when-compile. IOW you nee= d: Stefan> diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el Stefan> index 9715aea1fd..aa3b41454d 100644 Stefan> --- a/lisp/vc/vc-git.el Stefan> +++ b/lisp/vc/vc-git.el Stefan> @@ -102,8 +102,8 @@ =20=20=20=20=20 Stefan> ;;; Code: =20=20=20=20=20 Stefan> +(require 'cl-lib) Stefan> (eval-when-compile Stefan> - (require 'cl-lib) Stefan> (require 'subr-x) ; for string-trim-right Stefan> (require 'vc) Stefan> (require 'vc-dir)) I believe you [1]. Although in my mind the whole point of the autoload cookies is that you don=CA=BCt need to require the whole of cl-lib just to use one of its functions. I guess with that it=CA=BCs ready to push from my end. Lars, does it work the way you want? Footnotes: [1] I did test that it works, though :-)