From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#58158: 29.0.50; [overlay] Interval tree iteration considered harmful Date: Thu, 29 Sep 2022 13:33:25 +0200 Message-ID: References: <83h70qhez0.fsf@gnu.org> <83edvuhaby.fsf@gnu.org> <831qruh67o.fsf@gnu.org> <83y1u2foli.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35618"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) Cc: 58158@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 29 14:19:01 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odsVJ-00099B-1e for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Sep 2022 14:19:01 +0200 Original-Received: from localhost ([::1]:50734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odsVI-0000td-1G for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Sep 2022 08:19:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51216) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odrnm-0001rM-O2 for bug-gnu-emacs@gnu.org; Thu, 29 Sep 2022 07:34:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37364) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odrnm-0008DX-7z for bug-gnu-emacs@gnu.org; Thu, 29 Sep 2022 07:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1odrnm-00083O-3f for bug-gnu-emacs@gnu.org; Thu, 29 Sep 2022 07:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Sep 2022 11:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58158 X-GNU-PR-Package: emacs Original-Received: via spool by 58158-submit@debbugs.gnu.org id=B58158.166445121530926 (code B ref 58158); Thu, 29 Sep 2022 11:34:02 +0000 Original-Received: (at 58158) by debbugs.gnu.org; 29 Sep 2022 11:33:35 +0000 Original-Received: from localhost ([127.0.0.1]:36442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odrnL-00082j-Gw for submit@debbugs.gnu.org; Thu, 29 Sep 2022 07:33:35 -0400 Original-Received: from mail-ej1-f52.google.com ([209.85.218.52]:46910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odrnJ-00082V-CC for 58158@debbugs.gnu.org; Thu, 29 Sep 2022 07:33:34 -0400 Original-Received: by mail-ej1-f52.google.com with SMTP id bj12so2120806ejb.13 for <58158@debbugs.gnu.org>; Thu, 29 Sep 2022 04:33:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date; bh=5UAdfhp4C+9xiu/qGj/hxHwL9WJDd7evJ2B9fv5Vy6s=; b=YjEXiE6YScsZPzt9Lb5DFQfGWUHDm2xZLwtwVqYtSpRHd6QeX81bUEzyLDD0l+n7jx eMMofzyV4cq422SBA/kpMIJM1F88HIpnNhAcNBEgMoENrHOpHz6K7dZUWeNRZNlXNZIH lMP2XjesxsrXaHc77fzoVfZ4iYZyD0NokcDhIhshFje2TX+a3EDAfu98MCdWvBpvBc56 eNjWVHPDCl4uf5ruJYgKY1RBnKWVE3cleAY0O3c9ETHgtyxPbLAtqVdA+pLAA5N5gIPH h3cStztOJHk8yVrTePqZHgqTtcFtu0X0oH7s5YnWzCBAKbCCmw8Q3+gmD09n2Ijye73o rfWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=5UAdfhp4C+9xiu/qGj/hxHwL9WJDd7evJ2B9fv5Vy6s=; b=UwxPFiQMn5fZb1efDjcsCBUwG2lYZck7B/iAcTaK8qNCDum3UML6Xn3OAzKDlEJRP/ ynYGR7mod+SG6Ew4tpaN9G731iAVV9ZOrh1OMsY49Oqhus+gpMqpOr7/EVE9gM/Fg6+O RjxzOd+g80HILVg6vT+rdy/uQzNmf4jXQsUJr31d0mjTxbDXF6+HfJan6eioOVleLBIa oPurhLPwQ1fD3WJL6pOxtaBQ+Ou7czZCOv2iVxaTF3dCHkWs+WWTWmj4/irP1rUI7LUR ap+gomT04zoYPLDYjrv6oqyosyQb8B5vv/slS4Ujx+zoCTf2AwVsFdtXmtxbBjMqhOPD hXOA== X-Gm-Message-State: ACrzQf07AvdYVZS6IyZRcx9bxc+qyWwDW9FP0jlA4DVQwP32WI8IO1qA x2kmNDp4pfoZ7IHdKdrOkRB33J9arTRfig== X-Google-Smtp-Source: AMsMyM7LlAZTA6ty02DmhV8n8xlw3mhupBGyiKcnDxGoXMiHpgrdf7FPCQYpXiGc7VU99GXWtQ7Lcw== X-Received: by 2002:a17:907:6089:b0:783:592a:5d3f with SMTP id ht9-20020a170907608900b00783592a5d3fmr2425783ejc.385.1664451207149; Thu, 29 Sep 2022 04:33:27 -0700 (PDT) Original-Received: from Mini.fritz.box (pd9e36935.dip0.t-ipconnect.de. [217.227.105.53]) by smtp.gmail.com with ESMTPSA id j2-20020a17090623e200b0078080a97edbsm3895393ejg.111.2022.09.29.04.33.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 04:33:26 -0700 (PDT) In-Reply-To: <83y1u2foli.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 29 Sep 2022 13:43:05 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243898 Archived-At: Eli Zaretskii writes: >> I find it very hard to tell why this is done the way it is. If someone >> knowing the code can think of a reason, please speak up. > > I may be missing something, but it looks like the sole purpose of the > iter_start/iter_finish dance is to ensure only one iteration per tree > is running at any given time, and that's because the iteration uses > some state variable(s) of which there's only one instance per tree. BTW, It currently uses a "visited" flag in tree nodes, which is kind of such a state, but something like that is normally not needed when walking an rb-tree.