From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arash Esbati Newsgroups: gmane.emacs.devel Subject: Re: master 6aa5068ac71 1/3: Improve treatment of touch screen input by rmc and its callers Date: Wed, 19 Jun 2024 13:42:17 +0200 Message-ID: References: <171861761168.16246.1990246088317606554@vcs2.savannah.gnu.org> <20240617094652.69EE0C1FB5F@vcs2.savannah.gnu.org> <878qz141ux.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27616"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 19 13:43:45 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJtj5-0006wd-CS for ged-emacs-devel@m.gmane-mx.org; Wed, 19 Jun 2024 13:43:43 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJtht-0004DQ-6I; Wed, 19 Jun 2024 07:42:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJthp-0004Ck-2y for emacs-devel@gnu.org; Wed, 19 Jun 2024 07:42:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJthm-0004S5-Uu; Wed, 19 Jun 2024 07:42:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=gx9DVQf5871V/zJMa7Wr6LW/U+x5MEG64KOmfQwWwmE=; b=bvtz8uz4atnU2cIkNywE rPeKVJx99VlhblwhySWKFdUuyyCNiNrb+PLuaavoJMzcawbGVG3q1ChI6me1kHVA2SJ1qvswvB7EG 25hrpwep4k7lPz/kTCl29jnHH0e6Mgaei5ZHC1uH58RkxqG+TdBfbuGuc7R9Y5dhOFPDAyPJ8SgD4 TKl5b4HME3JILy/9vPI13EZpumzGagRmu+8z8tfWkOw1UumBRaK1BNanFX7zrkAAGb01XR5KP4vrH XyJT6uLrgZuwp1X5fWLSxsKY5Cg2u29CSBTEZE7R12ENCTduOsGd4frR0ycAhAUd+lV/PwhH9GZK3 6QxYed8pKUP74g==; In-Reply-To: <878qz141ux.fsf@yahoo.com> (Po Lu's message of "Wed, 19 Jun 2024 19:18:46 +0800") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320286 Archived-At: Po Lu writes: > OK, what if you replace in: > >>> + ;; Respond to scroll and pinch events as if RMC were >>> + ;; not in progress. >>> + ((eq (car-safe command) 'touchscreen-scroll) >>> + (funcall #'touch-screen-scroll command)) >>> + ((eq (car-safe command) 'touchscreen-pinch) >>> + (funcall #'touch-screen-pinch command)) > > #'touch-screen-scroll and #'touch-screen-pinch with 'touch-screen-scroll > and 'touch-screen-pinch? "Hiding" them from the compiler didn't work, the following change did: --8<---------------cut here---------------start------------->8--- diff --git a/lisp/emacs-lisp/rmc.el b/lisp/emacs-lisp/rmc.el index 883f8bf187f..a9142a8b46b 100644 --- a/lisp/emacs-lisp/rmc.el +++ b/lisp/emacs-lisp/rmc.el @@ -179,6 +179,9 @@ read-multiple-choice (read-multiple-choice--short-answers prompt choices help-string show-help))) +(declare-function touch-screen-scroll "touch-screen" (event)) +(declare-function touch-screen-pinch "touch-screen" (event)) + (defun read-multiple-choice--short-answers (prompt choices help-string show-help) (let* ((dialog-p (use-dialog-box-p)) (prompt-choices --8<---------------cut here---------------end--------------->8--- Best, Arash