From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] new package: clangd-inactive-regions Date: Sat, 02 Nov 2024 10:13:30 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21680"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Filippo Argiolas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 02 10:14:31 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t7ADG-0005aD-Su for ged-emacs-devel@m.gmane-mx.org; Sat, 02 Nov 2024 10:14:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t7ACQ-0002gz-Fy; Sat, 02 Nov 2024 05:13:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t7ACO-0002gf-D7 for emacs-devel@gnu.org; Sat, 02 Nov 2024 05:13:37 -0400 Original-Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t7ACM-0001Os-GE for emacs-devel@gnu.org; Sat, 02 Nov 2024 05:13:35 -0400 Original-Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4314c4cb752so23235095e9.2 for ; Sat, 02 Nov 2024 02:13:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730538812; x=1731143612; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=kTpbmI9Hmx6pKA2UvVTIzYyULAGkct0hexpNmV6phT8=; b=BYnuK0hc/IBczrMPU51ieTvarZIWDZwJhANERKei7hLYEEhM20XtNB+Y+hENvLOe8V hZzLGcfiOKtwKgIO38+YHwUHP69v6YNFoRzJDrrKcx/s6drYMtCT9jq+OtpFmhUsnlKu fz+njxPx9s80P5QHMtNVCN4gQEo8A8FO2bxCupe06/7dgWN61gOQjQx0aHnhU1uNSVXV PliVPWgFGy2DyS6xPDcPJaABZsfcyDsV5Ql46AJwzB3+7nMhySZVO4KDnouZ56gaCXGA VnCjph2wMhtV7vpbh+wYFRjxV4IyVAtSrbEb13btZrI6WVhXzUtsjVKF28DtkUb69i3Z +zgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730538812; x=1731143612; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kTpbmI9Hmx6pKA2UvVTIzYyULAGkct0hexpNmV6phT8=; b=CW6IYbkQApdj1b99uuO6q4j3UOuqRbMyIafyTr7HFEf0GyVhkZ9zd2PX1CTTQKHSo3 eIMQvFjV0YsYL4uREYcpDaL1xZm2HXzRd2o8DvUn+dF/Hoh+lDxotEyOyndS/F7kAOqD rhX6pBzn25rEQujNolCvX9X4JnpKVbrdGKKy3dslrEqR4tzcEpCwFhrRR6wy+f+5qcTr ApMvi61/xTczQHaxP5R2MKE9zWJYR3+/U7iqKyweeYKQ29YjdAssFi+gDCKhLNMZMDW9 ncUnLD508onBi9BZzX60k+D8vN6cxGz2i+WmWzOD9oUCjRyLnO6ci+IJp5hoX/yWNR/w L5og== X-Gm-Message-State: AOJu0YwL2m/19oYx4PSXwTDfFdh4LZUEcWDr+W+UQquW2FHJDOIh8CJT FoaFI0j9QySxE5BQ/9kP0dNTqJo0yOjO7GEnFmaa7oXJjEUtcAzvHN3/Vw== X-Google-Smtp-Source: AGHT+IH909GL/lVA6gT1Pd9Efr7e/hmXtChqQrNOLlBYNZpfgcGR4712lW8hQYJTk+aPojf7e8dEBw== X-Received: by 2002:a05:600c:4511:b0:42f:8515:e490 with SMTP id 5b1f17b1804b1-4327b6f959emr82343945e9.5.1730538811951; Sat, 02 Nov 2024 02:13:31 -0700 (PDT) Original-Received: from pro2 (p4fe3a3af.dip0.t-ipconnect.de. [79.227.163.175]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381c10b7c38sm7490870f8f.24.2024.11.02.02.13.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 02:13:31 -0700 (PDT) In-Reply-To: (Filippo Argiolas's message of "Fri, 1 Nov 2024 10:02:16 +0100") Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=gerd.moellmann@gmail.com; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325005 Archived-At: Filippo Argiolas writes: > I'm not exactly an elisp expert, so feedback is very welcome! Works fine for me on macOS 15.1/tty with clangd 19.1 from Homebrew. Thanks, that's a nice feature! You said you are interested in feedback, so here's my wishlist :-). - I'd preferred a global minor mode to turn this on and off. Which would replace the manual adding to the Eglot hook. - I think something is to be up with the faces? If I remove (clangd-inactive-regions-set-method "darken-foreground") (clangd-inactive-regions-set-opacity 0.55)) from the use-package in my init file, which is (use-package clangd-inactive-regions :straight (:host github :repo "fargiolas/clangd-inactive-regions.el" :branch "master" :files ("*.el")) :init (add-hook 'eglot-managed-mode-hook #'clangd-inactive-regions-mode) :config (clangd-inactive-regions-set-method "darken-foreground") (clangd-inactive-regions-set-opacity 0.55)) the inactive regions are not shown, I think. If I put them in, they are. - Maybe some of the defvar could be defcustoms?