From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] new package: clangd-inactive-regions Date: Sun, 03 Nov 2024 09:43:34 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30941"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Filippo Argiolas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 03 09:44:23 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t7WDf-0007yv-KU for ged-emacs-devel@m.gmane-mx.org; Sun, 03 Nov 2024 09:44:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t7WD0-0002kg-I6; Sun, 03 Nov 2024 03:43:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t7WCy-0002jt-DM for emacs-devel@gnu.org; Sun, 03 Nov 2024 03:43:40 -0500 Original-Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t7WCw-000782-S0 for emacs-devel@gnu.org; Sun, 03 Nov 2024 03:43:40 -0500 Original-Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-a99f646ff1bso409151866b.2 for ; Sun, 03 Nov 2024 01:43:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730623416; x=1731228216; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P033CSp9jI/rJKfJGPKaAeHpUGW55ON6vXZa3C/Db7Q=; b=mt/El5wYYJDfC0+wmPsGYWV7P62fpQviVDXr179bvO7ZS+JnxtIoA/FMwyPsXeukN7 sjpJ604oESprMnQ3/+nCmIjrDRQGlL+2vkz2H6KBdX7hI2m9n7C36rKlahC5CeMt2dhk 8QIQVeGlRoqRNerpJVqP3h6lUinS8plp3Wz2CALBao0IADMN8sJ9aZuZJNdvI/S5dR+4 X+T2phvWU89srbpXV1Od19ocuI3L946vzvgDoKZxd3nP1XNn3RgEBEhFMHIn/7hcWQ2F ukCdihHbWUgHbXkcT1owIZpAeSIYWiTaXnso0RTFbdYpN9kFgMjvc5Iwb5Qy5kWY7xHT gqAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730623416; x=1731228216; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=P033CSp9jI/rJKfJGPKaAeHpUGW55ON6vXZa3C/Db7Q=; b=ZDVc3sUPs5opjrYSGIlIUAOOwpJ+rN5Raj53aQHcbwW+uNydwyehExnAdGDszyGNFq G8mDyaeVumRKddBg3iloWXzcBQ+uERzRsrQmGalyhuGPUo551ycRxDrfiDQhH0g2cXtb MDK1l5wLVGe29hrCQkbqjYd9o/3CyaMTfhEO+R/W/YvpetsUIvxdpdy6lfFrsl/TXj0K V5GwKUu6nlpNG0KkhR7DtpPTmCo92c5/WphXTomOxgJWcfxB4v8TzyFLxA97JcbcgqEu zKdiU5WLIhExpUg3KPMmFlEQZ3hV9589w6ay8l8lyqRbCYyePnI8koTnyx+3DqMmQWJn 54+Q== X-Gm-Message-State: AOJu0YxY2lWY0VnFUylTEbk89lx6DbCDRyU3yq7Jfpdhnk7IC+dSFkzt PoSMqpfNjtf0/ZY6vFhWOO7mpTA+yXfGq9bzv0E3WYeQYFI8nJpmmAcHXw== X-Google-Smtp-Source: AGHT+IG0f9c1ujktipkiSLq2oYVLyCfN2N3ekwkcHeje8VLwdgg2F+obmIiXWE0Aba0I7yVK5+AA/A== X-Received: by 2002:a17:907:31c3:b0:a9a:1918:c6c6 with SMTP id a640c23a62f3a-a9e3a574fedmr1698553566b.8.1730623416234; Sun, 03 Nov 2024 01:43:36 -0700 (PDT) Original-Received: from pro2 (pd9e36270.dip0.t-ipconnect.de. [217.227.98.112]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9e5668499esm397794466b.219.2024.11.03.01.43.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Nov 2024 01:43:35 -0700 (PDT) In-Reply-To: (Filippo Argiolas's message of "Sun, 3 Nov 2024 08:53:38 +0100") Received-SPF: pass client-ip=2a00:1450:4864:20::62d; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325052 Archived-At: Filippo Argiolas writes: > On Sat, Nov 2, 2024 at 10:13=E2=80=AFAM Gerd M=C3=B6llmann wrote: >> Works fine for me on macOS 15.1/tty with clangd 19.1 from Homebrew. >> Thanks, that's a nice feature! >> >> You said you are interested in feedback, so here's my wishlist :-). >> >> - I'd preferred a global minor mode to turn this on and off. >> Which would replace the manual adding to the Eglot hook. > > Thanks for the very welcome feedback! > My idea was to keep this local as it hooks into fontification and > wanted to limit any problems that may arise only to the buffers where > the mode is enabled. > This by the way was only possible with c-ts-mode as cc-mode chains > into the default function in its fontify-region hook, so if I want to > run my code after theirs it must be inherently global. > > Guess the same could be achieved by defining a global minor mode and > adding eglot/c mode hooks myself but I'd like to leave the control to > the user for now. Hm, okay. > >> - I think something is to be up with the faces? If I remove >> >> (clangd-inactive-regions-set-method "darken-foreground") >> (clangd-inactive-regions-set-opacity 0.55)) >> >> the inactive regions are not shown, I think. If I put them in, they >> are. > > Thanks, always had those in the init and never noticed. Should be > fixed now, could you test again? Yes, it works now.