From: "Gerd Möllmann" <gerd.moellmann@gmail.com>
To: Filippo Argiolas <filippo.argiolas@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [NonGNU ELPA] new package: clangd-inactive-regions
Date: Sun, 03 Nov 2024 09:43:34 +0100 [thread overview]
Message-ID: <m2bjywd7wp.fsf@gmail.com> (raw)
In-Reply-To: <CAOdrLGLX7N9o_8h0DVR77gSi8f5w7Q1rRFT9t=ec2TzibkdYOQ@mail.gmail.com> (Filippo Argiolas's message of "Sun, 3 Nov 2024 08:53:38 +0100")
Filippo Argiolas <filippo.argiolas@gmail.com> writes:
> On Sat, Nov 2, 2024 at 10:13 AM Gerd Möllmann <gerd.moellmann@gmail.com> wrote:
>> Works fine for me on macOS 15.1/tty with clangd 19.1 from Homebrew.
>> Thanks, that's a nice feature!
>>
>> You said you are interested in feedback, so here's my wishlist :-).
>>
>> - I'd preferred a global minor mode to turn this on and off.
>> Which would replace the manual adding to the Eglot hook.
>
> Thanks for the very welcome feedback!
> My idea was to keep this local as it hooks into fontification and
> wanted to limit any problems that may arise only to the buffers where
> the mode is enabled.
> This by the way was only possible with c-ts-mode as cc-mode chains
> into the default function in its fontify-region hook, so if I want to
> run my code after theirs it must be inherently global.
>
> Guess the same could be achieved by defining a global minor mode and
> adding eglot/c mode hooks myself but I'd like to leave the control to
> the user for now.
Hm, okay.
>
>> - I think something is to be up with the faces? If I remove
>>
>> (clangd-inactive-regions-set-method "darken-foreground")
>> (clangd-inactive-regions-set-opacity 0.55))
>>
>> the inactive regions are not shown, I think. If I put them in, they
>> are.
>
> Thanks, always had those in the init and never noticed. Should be
> fixed now, could you test again?
Yes, it works now.
next prev parent reply other threads:[~2024-11-03 8:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 9:02 [NonGNU ELPA] new package: clangd-inactive-regions Filippo Argiolas
2024-11-02 9:13 ` Gerd Möllmann
2024-11-03 7:53 ` Filippo Argiolas
2024-11-03 8:43 ` Gerd Möllmann [this message]
2024-11-02 21:52 ` Stefan Kangas
2024-11-02 22:35 ` Felician Nemeth
2024-11-03 1:21 ` Stefan Kangas
2024-11-03 8:08 ` Filippo Argiolas
2024-11-03 15:07 ` Stefan Kangas
2024-11-04 17:36 ` Felician Nemeth
2024-11-03 5:59 ` Eli Zaretskii
2024-11-04 17:40 ` Felician Nemeth
2024-11-03 5:46 ` Eli Zaretskii
2024-11-04 5:34 ` Richard Stallman
2024-11-04 7:17 ` Filippo Argiolas
2024-11-04 12:02 ` Philip Kaludercic
2024-11-05 0:42 ` Filippo Argiolas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2bjywd7wp.fsf@gmail.com \
--to=gerd.moellmann@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=filippo.argiolas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.