From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "O'Brien, Will" Newsgroups: gmane.emacs.bugs Subject: bug#74786: [PATCH] Add custom args to test compile step Date: Fri, 20 Dec 2024 16:14:54 +0000 Message-ID: References: <86wmg62pfs.fsf@gnu.org> <87wmg643g4.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29541"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Robert Pluim , 74786@debbugs.gnu.org, Eli Zaretskii , "J.P." To: Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 20 17:19:26 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tOfin-0007US-TX for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Dec 2024 17:19:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOfhU-0007yz-2F; Fri, 20 Dec 2024 11:18:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOfgW-0006mZ-Jw for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2024 11:17:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOfgW-0007jx-Ak for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2024 11:17:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=raFDBoFJfCUCRtVALfOf20ArOYQcA5XQ0x5cX/DgiHw=; b=qhpHGPZyYPLqGDFBcRFEfku4aeo/dXjBWrk1rh/ksVgBwlKdnhfwhZDRBXtkVIE21mMvEY7rG5CGKsQ3n2mcEQGApleLm0w0kBPV+rP0FVAY2GDiIpJUdu2h/KXlrOytUKRUaM7NLXVuDXL9TGapQJYAC0wxb5cdBc+9g/gNbAUAcpAffpMcgo6rI028XIQ4U7s5aGjn0ZQw7c57Yl6mZipXtj4ICDiToh865TOUzaq8p4nk1dXyvmJNyqPf4zVVB14btpji2NPjNgPmGjdcbdawOUrle4eVJ94Nl2wXZl4p/7ZwLfhOx490vS1MUFuiL71ZbRfWmMQJdZD/asv3gA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tOfgU-0000rG-4n for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2024 11:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "O'Brien, Will" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Dec 2024 16:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74786 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74786-submit@debbugs.gnu.org id=B74786.17347113663209 (code B ref 74786); Fri, 20 Dec 2024 16:17:02 +0000 Original-Received: (at 74786) by debbugs.gnu.org; 20 Dec 2024 16:16:06 +0000 Original-Received: from localhost ([127.0.0.1]:43750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOffa-0000ph-Fe for submit@debbugs.gnu.org; Fri, 20 Dec 2024 11:16:06 -0500 Original-Received: from mail-wr1-f41.google.com ([209.85.221.41]:58813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOffV-0000p4-VI for 74786@debbugs.gnu.org; Fri, 20 Dec 2024 11:16:05 -0500 Original-Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-385e3621518so1144940f8f.1 for <74786@debbugs.gnu.org>; Fri, 20 Dec 2024 08:16:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734711296; x=1735316096; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=raFDBoFJfCUCRtVALfOf20ArOYQcA5XQ0x5cX/DgiHw=; b=S38tW9F2eKVQKeaXCTUKcIYTM5Qq4Eiih2YgCAdQwuOdRv2OxEueXHNCqU0OquLXop L2nms1M5jjBJv3zIUhlC6bmSkFwT00fxHD4C5M72qkIlpP//8dgKfRLhHI6Cdck2YR2M wapi16eWeOdzBlbdgQSmHAnL+3NjTJo6AalJhZI6gWfOqg2vdTfRQ5T7ZNXt8pmZ2x+N zynTbkUgDfzYmFCEKibKizundZsPS4WmE7y6oSWnSvz3zgXmdwF0kmC5ZRMTGPu5Qt13 7w043ESLWq1nW9MrnxBvnbqKuqsaVSKcrb3p+LqDtj45JQx7LdQpmoqby4WKod0KUiWK NWDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734711296; x=1735316096; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=raFDBoFJfCUCRtVALfOf20ArOYQcA5XQ0x5cX/DgiHw=; b=NoKn/ybkZFgFTTFZP3AR4GXXpDR5GXu2mfA4DiapM6Yt6oHNU5r4rwMC5mkiv5h/Bq 89UGiKkeQkj2G+xOiXFbx4hmjXf1rFHL+qbUtzWZC5agekPk3CMMiBcrkFX2TZCBbo5H E0rSpwYhjoMM5bmVvtGK+/WaV9Y+wGiJd7RA5pj8tY8G42XpHoa7ErN25H5lrDXkdkVz te5NyTWP4MI4oTh0Cco6UpZwO1uLzVXMSmBCCN49y4zBvzoCj8fB/84Jmme/zD6oi82B VsSRPhXAjqJ6jon/BpkMYLVWNTa2ue4CJY0SWbBNUXd5afGW9WSNM6GdgkYyQ1NVslqg /PfQ== X-Forwarded-Encrypted: i=1; AJvYcCUwFrilUGcP9EDhBealMN4smCpnMYI6cuRtM/gypyYSl1KmtXwuSfSJeYrdXC4TPe79ButLVA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzfoN8SdD8nRoKYymxyptjVZbNXkBOkanCwZzYGXn5NJWnUr5Z/ hBqxQVG3U5QBChfE5xlMx7NWsBMp/illpKRpb2H5cDj1N1C/j3p7 X-Gm-Gg: ASbGnculmGS/HkLqsE5+PUOwcHjSe/QJK+UO03ZaUPl1llmi2gNBkDl1b7qEFAV9kzF fAu1LycQ/K8SEFa2doxxn5iAXApZPoRNH7xu0j/mCwxIkMCjBsNlrX4SVYo5qCWHAB6sz42n98Z 6oCQ2DbtjcoFJ/KuMTR15hNl5ecBi2eVjQ36/+EJ9dQcUxsSY1aAGGQXli1oszZfDKumdOUj9/7 cFKmNgSQhq29WDdmcws80mIM9FVvEFWKKfBPulycc4o3y4N8sqQ8PH1jJ2SjKfJY2Pfp7ay3t08 gig4FGB4IALdGvJPpY4= X-Google-Smtp-Source: AGHT+IE/B9oOOJU9UCELxe2d/obyMiSZ4Dd5HypeW0/o8Ek7n7PkW9ntFf4Dhrn/C0UN8njFqXBSPQ== X-Received: by 2002:a05:6000:4020:b0:385:e411:c894 with SMTP id ffacd0b85a97d-38a223f72c0mr3052391f8f.43.1734711295978; Fri, 20 Dec 2024 08:14:55 -0800 (PST) Original-Received: from Wills-MacBook-Pro.local ([2a00:23c7:253d:cd01:e1f5:b71:ad4c:a24b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c828ba0sm4323962f8f.14.2024.12.20.08.14.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Dec 2024 08:14:55 -0800 (PST) In-Reply-To: (Will O'Brien's message of "Thu, 19 Dec 2024 16:20:18 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297456 Archived-At: Hi, On Thu, Dec 19 2024 at 16:20, "O'Brien, Will" wrote: > I believe the attached patch should cover your suggestion, Randy, > as well as incorporating Robert's and J.P.'s suggestions. I think there's a further issue which I believe was pre-existing. The package test function looks like this: --8<---------------cut here---------------start------------->8--- (defun go-ts-mode-test-this-package () "Run all the unit tests under the current package." (interactive) (compile (format "go test -v %s -run %s" (go-ts-mode--get-build-tags-flag) default-directory))) --8<---------------cut here---------------end--------------->8--- The issue that the argument to the `-run` flag is a regex that should match any tests that will be execute. Passing a directory has slightly unexpected consequences, and although it seems to work, for me typically results tests not running. I think that we can remove the `-run` flag from this function. What do others think? Also, should this be a separate bug/patch (if indeed it is a bug) or I can incorporate this change into the current change set. best -- will