From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.devel Subject: Re: [sdl.web@gmail.com: Re: scroll-bar face gets changed in a new frame] Date: Sun, 04 Feb 2007 01:25:16 +0000 Message-ID: References: <878xfeoj3w.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1170552316 8133 80.91.229.12 (4 Feb 2007 01:25:16 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 4 Feb 2007 01:25:16 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 04 02:25:06 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HDW7t-0004SD-Sf for ged-emacs-devel@m.gmane.org; Sun, 04 Feb 2007 02:25:06 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HDW7u-0008OA-9j for ged-emacs-devel@m.gmane.org; Sat, 03 Feb 2007 20:25:06 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HDW7k-0008O4-2d for emacs-devel@gnu.org; Sat, 03 Feb 2007 20:24:56 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HDW7h-0008Ns-NP for emacs-devel@gnu.org; Sat, 03 Feb 2007 20:24:54 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HDW7h-0008Np-GY for emacs-devel@gnu.org; Sat, 03 Feb 2007 20:24:53 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1HDW7h-0006Ws-2C for emacs-devel@gnu.org; Sat, 03 Feb 2007 20:24:53 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1HDW7e-0000ZX-6C for emacs-devel@gnu.org; Sun, 04 Feb 2007 02:24:50 +0100 Original-Received: from sl392.st-edmunds.cam.ac.uk ([131.111.223.202]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 04 Feb 2007 02:24:50 +0100 Original-Received: from sdl.web by sl392.st-edmunds.cam.ac.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 04 Feb 2007 02:24:50 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 41 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: sl392.st-edmunds.cam.ac.uk Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAMFBMVEUaFRZLMy1dTENxVzKQ WiCrXQ97cmO/dSqSh3akjGTApXy5sJ7Sxo/Sz8Xo6eP9//xJbkruAAAAAWJLR0QAiAUdSAAAAAlw SFlzAAACxQAAAsUBidZ/7wAAAAd0SU1FB9cBBwMJOwHXewoAAAIBSURBVCjPVdNBiNNAFADQ6J4F x3hThHZBBC+WCFI8SS0iezRDcMHLHkLAg6gJH/fgYQ9xYlj2sLK4KHgqCgXFhda2Idmr4kkQPZQ0 nkQMbTypbMmMM2m7ZgYSmMef/5OZPwo7HFnx3uKPcmj0Dht1LWZJ+Hvr7dIFZXRUwl9VRTuuKDJ+ U44gjscknK4hhJaCkYRsWjmBtLqXlJAG2wipNe18OZJu1BBq1E8xafl4s6Jq2mUZGftU1y7CCxnp FVUDWJXx4C66BKBnErbuoaYNtoRTu6EZBsCbMn7W+5qOAR6WvxNOby9jHWC9hAf3n304CdiAByXs 3Nh9roLDkyb/sWV712vYwaLSAn8CPMHIAAzOPDKP2COAFm4Y4ODVWc6xG7KXsN7UeUJjjimx2uwd gCgNhr0i8C/xyCD5CiCKAMY3Bf5oDzx//w/fimscdcAZU2jv9sedx6+nYPPFIoWI/GK6QZ+EFGOR ErAjCnV3vPZ7XqlTIMbOLY7fLcvvmT7rXNWaGDexIY44N12TG2PDp7vqyl57dnCeuWwyNpnEURxk fTbDYeBnKRn4oejPYI4sH6WviBumEZ/GxX4X/x6EcURFZ7E071bjQGAxpcOAEOJuTiroDEea5Szv rVWLYfl7ZiQwSUToxrkux7OLixAWGz22+HIyWTRYcVfomOwvzusfjtVIGgLHf3MAAAAASUVORK5C YII= User-Agent: No Gnus v0.6, Emacs/22.0.93.4 (2007-02-04), Fedora 6 gnu/linux Cancel-Lock: sha1:j5Mhm2mVXxxIlhlX/1YPFvTGyZ4= X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:65839 Archived-At: On 2007-02-04, Chong Yidong said: > Richard Stallman writes: > >> Would someone please investigate this and DTRT? > > The problem is in face-set-after-frame-default. The function merges > in the X resources, then initializes attributes from frame parameters. > However, if there is a scroll-bar X resource present, the call to > make-face-x-resource-internal will chang the scroll-bar-* frame > parameters in the process of changing the scroll-bar face. Therefore, > any previously-applied frame parameters are lost. > > I think one fix is for face-set-after-frame-default to first construct > a list of frame parameters to be applied (based on the new frame's > frame-parameters and/or the face's value for new frames), then wait > until after the call to make-face-x-resource-internal before applying > these changes. See the attached patch. > > By the way, the symbol inhibit-default-face-x-resources seems to be a > no-op; it is called as > > (when (not (equal face 'default)) > ... > (when (and (memq window-system '(x w32 mac)) > (or (not (boundp 'inhibit-default-face-x-resources)) > (not (eq face 'default)))) > (make-face-x-resource-internal face frame))) > > However, since face is never `default' inside the `when' form, the > enclosing `or' statement is always t, regardless of whether or not > inhibit-default-face-x-resources is bound. I think this symbol was > introduced to solve a similar problem, and it can be removed if the > proposed fix is applied. > [patch] I confirm it fixes the bug. -- Leo (GPG Key: 9283AA3F)