multiline description list, partial patch

multiline description list, partial patch

[Eric Schulte]

Hi,

I've noticed that the bold face isn't applied to multiline description
lists.  This patch [1] partially fixes the problem, but for some reason
I keep losing the bold.  Any thoughts/ideas?

On a related topic, I'd like to consistently indent my decision list
text, rather than sometimes moving back to the depth of the bold
portion, does anyone else feel similarly and is this supported?

thanks -- Eric

Footnotes: 
[1]  
diff --git a/lisp/org.el b/lisp/org.el
index 39ef466..ed8d776 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -4703,7 +4703,7 @@ between words."
 	       '("\\[\\([0-9]*%\\)\\]\\|\\[\\([0-9]*\\)/\\([0-9]*\\)\\]"
 		 (0 (org-get-checkbox-statistics-face) t)))
 	   ;; Description list items
-	   '("^[ \t]*\\([-+*]\\|[0-9]+[.)]\\) +\\(.*? ::\\)"
+	   '("^[ \t]*\\([-+*]\\|[0-9]+[.)]\\) +\\(.*?\n?.*? ::\\)"
 	     2 'bold prepend)
 	   ;; ARCHIVEd headings
 	   (list (concat "^\\*+ \\(.*:" org-archive-tag ":.*\\)")
@@ -16272,7 +16272,7 @@ which make use of the date at the cursor."
 	  (setq column (current-column)))
        ((org-in-item-p)
 	(org-beginning-of-item)
-	(looking-at "[ \t]*\\(\\S-+\\)[ \t]*\\(\\[[- X]\\][ \t]*\\|.*? :: \\)?")
+	(looking-at "[ \t]*\\(\\S-+\\)[ \t]*\\(\\[[- X]\\][ \t]*\\|.*?\n?.*? :: \\)?")
 	(setq bpos (match-beginning 1) tpos (match-end 0)
 	      bcol (progn (goto-char bpos) (current-column))
 	      tcol (progn (goto-char tpos) (current-column))
@@ -16372,7 +16372,7 @@ In particular, this makes sure hanging paragraphs for hand-formatted lists
 work correctly."
   (cond ((looking-at "#[ \t]+")
 	 (match-string 0))
-	((looking-at "[ \t]*\\([-*+] .*? :: \\)")
+	((looking-at "[ \t]*\\([-*+] .*?\n?.*? :: \\)")
 	 (save-excursion
 	   (if (> (match-end 1) (+ (match-beginning 1)
 				   org-description-max-indent))

Re: multiline description list, partial patch

[Carsten Dominik]

On Sep 9, 2009, at 9:59 PM, Eric Schulte wrote:

> Hi,
>
> I've noticed that the bold face isn't applied to multiline description
> lists.

What exactly do you mean here?

>  This patch [1] partially fixes the problem, but for some reason
> I keep losing the bold.  Any thoughts/ideas?

Maybe you need to add a fontilock-multiline text property?

>
> On a related topic, I'd like to consistently indent my decision list
> text, rather than sometimes moving back to the depth of the bold
> portion, does anyone else feel similarly and is this supported?

Have you had a look at the variable org-description-max-indent ?
But maybe I am again not clearly understanding what you mean?

- Carsten

>
> thanks -- Eric
>
> Footnotes:
> [1]
> diff --git a/lisp/org.el b/lisp/org.el
> index 39ef466..ed8d776 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -4703,7 +4703,7 @@ between words."
> 	       '("\\[\\([0-9]*%\\)\\]\\|\\[\\([0-9]*\\)/\\([0-9]*\\)\\]"
> 		 (0 (org-get-checkbox-statistics-face) t)))
> 	   ;; Description list items
> -	   '("^[ \t]*\\([-+*]\\|[0-9]+[.)]\\) +\\(.*? ::\\)"
> +	   '("^[ \t]*\\([-+*]\\|[0-9]+[.)]\\) +\\(.*?\n?.*? ::\\)"
> 	     2 'bold prepend)
> 	   ;; ARCHIVEd headings
> 	   (list (concat "^\\*+ \\(.*:" org-archive-tag ":.*\\)")
> @@ -16272,7 +16272,7 @@ which make use of the date at the cursor."
> 	  (setq column (current-column)))
>        ((org-in-item-p)
> 	(org-beginning-of-item)
> -	(looking-at "[ \t]*\\(\\S-+\\)[ \t]*\\(\\[[- X]\\][ \t]*\\|.*? :: \ 
> \)?")
> +	(looking-at "[ \t]*\\(\\S-+\\)[ \t]*\\(\\[[- X]\\][ \t]*\\|.*? 
> \n?.*? :: \\)?")
> 	(setq bpos (match-beginning 1) tpos (match-end 0)
> 	      bcol (progn (goto-char bpos) (current-column))
> 	      tcol (progn (goto-char tpos) (current-column))
> @@ -16372,7 +16372,7 @@ In particular, this makes sure hanging  
> paragraphs for hand-formatted lists
> work correctly."
>   (cond ((looking-at "#[ \t]+")
> 	 (match-string 0))
> -	((looking-at "[ \t]*\\([-*+] .*? :: \\)")
> +	((looking-at "[ \t]*\\([-*+] .*?\n?.*? :: \\)")
> 	 (save-excursion
> 	   (if (> (match-end 1) (+ (match-beginning 1)
> 				   org-description-max-indent))
>
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: multiline description list, partial patch

[Sebastian Rose]

Hi Eric,


I think long descriptions are _very_ unusual (it's called "definition
list" (<dl>) in HTML and "definition term" (<dt>).

I used to do this here, before those lists were supported directly in
Org-mode:

  - *Bold longish term* \\
    Description of the bold longish term.


I bound this function to a key:


(defun sr-insert-org-dd-item ()
  (interactive)
  (let  ( (in (read-from-minibuffer "Definition list DT item: ")) )
    (newline-and-indent)
    (insert (concat "+ *" in "* \\\\"))
    (newline-and-indent)))




I remember I had to set `org-plain-list-ordered-item-terminator' to `t'
to make this work correctly.


This was added in 2008-02-25 and removed, when Carsten added the support
for the definition lists. And I never missed it.



  Sebastian

Re: multiline description list, partial patch

[Carsten Dominik]

Hi Eric,

I am assuming you are trying to do something like this:

  - a very long
    description item :: here is the explanation

This is not going to work properly with export.

- Carsten

On Sep 9, 2009, at 9:59 PM, Eric Schulte wrote:

> Hi,
>
> I've noticed that the bold face isn't applied to multiline description
> lists.  This patch [1] partially fixes the problem, but for some  
> reason
> I keep losing the bold.  Any thoughts/ideas?
>
> On a related topic, I'd like to consistently indent my decision list
> text, rather than sometimes moving back to the depth of the bold
> portion, does anyone else feel similarly and is this supported?
>
> thanks -- Eric
>
> Footnotes:
> [1]
> diff --git a/lisp/org.el b/lisp/org.el
> index 39ef466..ed8d776 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -4703,7 +4703,7 @@ between words."
> 	       '("\\[\\([0-9]*%\\)\\]\\|\\[\\([0-9]*\\)/\\([0-9]*\\)\\]"
> 		 (0 (org-get-checkbox-statistics-face) t)))
> 	   ;; Description list items
> -	   '("^[ \t]*\\([-+*]\\|[0-9]+[.)]\\) +\\(.*? ::\\)"
> +	   '("^[ \t]*\\([-+*]\\|[0-9]+[.)]\\) +\\(.*?\n?.*? ::\\)"
> 	     2 'bold prepend)
> 	   ;; ARCHIVEd headings
> 	   (list (concat "^\\*+ \\(.*:" org-archive-tag ":.*\\)")
> @@ -16272,7 +16272,7 @@ which make use of the date at the cursor."
> 	  (setq column (current-column)))
>        ((org-in-item-p)
> 	(org-beginning-of-item)
> -	(looking-at "[ \t]*\\(\\S-+\\)[ \t]*\\(\\[[- X]\\][ \t]*\\|.*? :: \ 
> \)?")
> +	(looking-at "[ \t]*\\(\\S-+\\)[ \t]*\\(\\[[- X]\\][ \t]*\\|.*? 
> \n?.*? :: \\)?")
> 	(setq bpos (match-beginning 1) tpos (match-end 0)
> 	      bcol (progn (goto-char bpos) (current-column))
> 	      tcol (progn (goto-char tpos) (current-column))
> @@ -16372,7 +16372,7 @@ In particular, this makes sure hanging  
> paragraphs for hand-formatted lists
> work correctly."
>   (cond ((looking-at "#[ \t]+")
> 	 (match-string 0))
> -	((looking-at "[ \t]*\\([-*+] .*? :: \\)")
> +	((looking-at "[ \t]*\\([-*+] .*?\n?.*? :: \\)")
> 	 (save-excursion
> 	   (if (> (match-end 1) (+ (match-beginning 1)
> 				   org-description-max-indent))
>
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: multiline description list, partial patch

[Eric Schulte]

Carsten Dominik <carsten.dominik@gmail.com> writes:

> Hi Eric,
>
> I am assuming you are trying to do something like this:
>
>  - a very long
>    description item :: here is the explanation
>
> This is not going to work properly with export.
>

Exactly, when description items line-wrap I'd like to preserve their
bold face, but your export point is well take.

also, thanks for pointing out the `org-description-max-indent' variable,
that will greatly help my sense of org-aesthetic. Thanks -- Eric

Re: multiline description list, partial patch

[Carsten Dominik]

On Sep 11, 2009, at 8:03 AM, Eric Schulte wrote:

> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
>> Hi Eric,
>>
>> I am assuming you are trying to do something like this:
>>
>> - a very long
>>   description item :: here is the explanation
>>
>> This is not going to work properly with export.
>>
>
> Exactly, when description items line-wrap I'd like to preserve their
> bold face, but your export point is well take.
>
> also, thanks for pointing out the `org-description-max-indent'  
> variable,
> that will greatly help my sense of org-aesthetic. Thanks -- Eric

The easiest fix for the export problem would be modifying
auto-fill-inhibit-regexp to include lines are description
items.  But it is also a hack....

- Carsten