Re: defadvice question.

[Michal <rabbitko@tenbit.pl>]

Hallo Kevin.
Thank You very much for the answer.
Unfortunately I have problems with both solutions.

Did You check if it works on YOur site, or this is rather Your suggestion?

Kevin Rodgers <kevin.d.rodgers@gmail.com> writes:

>
> (defadvice cvs-checkout (before minibuffer-history)
>   "Add CVSROOT environment variable to `minibuffer-history'."
>   (interactive (let ((minibuffer-history
> 		      (cons (getenv "CVSROOT") minibuffer-history)))
> 		 ...)))
>
> The tricky part is the "...".  You could copy the entire interactive form from
> cvs-checkout source in pcvs.el, but that defeats the whole purpose of using
> advice.  You might be able to work around it like this:

I C-u M-x cvs-checkout

call-interactively: Symbol's value as variable is void: \.\.\.


>
> (defvar cvs-checkout-interactive-form
>   (interactive-form 'cvs-checkout))
>
> (defadvice cvs-checkout (before minibuffer-history)
>   "Add CVSROOT environment variable to `minibuffer-history'."
>   (interactive (let ((minibuffer-history
> 		      (cons (getenv "CVSROOT") minibuffer-history)))
> 		 (call-interactively `(lambda (&rest cvs-checkout-args)
> 					,cvs-checkout-interactive-form
> 					cvs-checkout-args)))))

While this does not produce any error message, but my cvs root is not
put to minibuffer history.

best regards