From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#12159: 24.1.50; vc-dir: Need a way to hide unregistered files Date: Sun, 12 Aug 2012 12:02:56 +0200 Message-ID: References: <87pq71i7fy.fsf@gmail.com> <87d3312p4f.fsf@gmail.com> <871ujdpbqp.fsf@gmail.com> <87boigj2ti.fsf@gmail.com> <87pq6we8jk.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1344765822 8122 80.91.229.3 (12 Aug 2012 10:03:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 12 Aug 2012 10:03:42 +0000 (UTC) Cc: 12159@debbugs.gnu.org To: Jambunathan K Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 12 12:03:42 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T0V1K-0005yJ-2H for geb-bug-gnu-emacs@m.gmane.org; Sun, 12 Aug 2012 12:03:42 +0200 Original-Received: from localhost ([::1]:51137 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0V1J-0003PC-7R for geb-bug-gnu-emacs@m.gmane.org; Sun, 12 Aug 2012 06:03:41 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0V1G-0003Op-99 for bug-gnu-emacs@gnu.org; Sun, 12 Aug 2012 06:03:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T0V1E-0007Hd-1d for bug-gnu-emacs@gnu.org; Sun, 12 Aug 2012 06:03:38 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0V1D-0007HU-Ul for bug-gnu-emacs@gnu.org; Sun, 12 Aug 2012 06:03:35 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1T0V9N-0005Qj-L1 for bug-gnu-emacs@gnu.org; Sun, 12 Aug 2012 06:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Aug 2012 10:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12159 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12159-submit@debbugs.gnu.org id=B12159.134476628820833 (code B ref 12159); Sun, 12 Aug 2012 10:12:01 +0000 Original-Received: (at 12159) by debbugs.gnu.org; 12 Aug 2012 10:11:28 +0000 Original-Received: from localhost ([127.0.0.1]:50619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T0V8p-0005Px-8C for submit@debbugs.gnu.org; Sun, 12 Aug 2012 06:11:28 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.10]:43310) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T0V8n-0005Pp-7v for 12159@debbugs.gnu.org; Sun, 12 Aug 2012 06:11:26 -0400 Original-Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3WvwcK61ZBz3hhTR; Sun, 12 Aug 2012 12:02:56 +0200 (CEST) X-Auth-Info: vUIRWg/1ZxJ6Mb8DDDZYlKYOLLzmBvl//JypkHG4X+8= Original-Received: from igel.home (ppp-93-104-139-122.dynamic.mnet-online.de [93.104.139.122]) by mail.mnet-online.de (Postfix) with ESMTPA id 3WvwcJ4tsRzbcpp; Sun, 12 Aug 2012 12:02:56 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 501) id 55682CA2A4; Sun, 12 Aug 2012 12:02:56 +0200 (CEST) X-Yow: Now KEN is having a MENTAL CRISIS because his "R.V." PAYMENTS are OVER-DUE!! In-Reply-To: <87pq6we8jk.fsf@gmail.com> (Jambunathan K.'s message of "Sun, 12 Aug 2012 15:28:23 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:63064 Archived-At: Jambunathan K writes: > Andreas Schwab writes: > >> Jambunathan K writes: >> >>> +(defcustom vc-dir-hide-these-states '("up-to-date") >>> + "States hidden by `vc-dir-hide-some-states'." >>> + :type '(choice >>> + (const :tag "None") >>> + (set :tag "Choices" >>> + (string :tag "VC State" "added") >> >> Why a string? Using the symbol would be more natural. > > There is a note up in the thread, which reads: > > ,---- > | 2. Magnus' changes assumes that states are just elisp symbols. This > | may not be true. In case of locked states - designated as USER in > | `vc-state' - the state could actually be a string. > `---- There is nothing wrong with using a string where the state is a string. But if the user name happens to match the name of one of the state symbols it becomes ambigous. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."