From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.bugs Subject: bug#12051: 24.1; rcirc-send-message doesn't take multibyte into account. Date: Thu, 16 Aug 2012 11:16:04 +0800 Message-ID: References: <87boj3byqy.fsf@acerpad.localdomain> <83k3x1jx3p.fsf@gnu.org> <874no4apau.fsf@acerpad.localdomain> <83628kkgjw.fsf@gnu.org> <831uj8jdl3.fsf@gnu.org> <83d32rv9bn.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1345087044 15258 80.91.229.3 (16 Aug 2012 03:17:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 Aug 2012 03:17:24 +0000 (UTC) Cc: 12051@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 16 05:17:21 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T1qaF-0004Ao-EA for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Aug 2012 05:17:19 +0200 Original-Received: from localhost ([::1]:39251 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1qaE-0007BX-8i for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Aug 2012 23:17:18 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1qaC-0007BQ-CQ for bug-gnu-emacs@gnu.org; Wed, 15 Aug 2012 23:17:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1qaB-0003RW-FR for bug-gnu-emacs@gnu.org; Wed, 15 Aug 2012 23:17:16 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50520) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1qaB-0003RS-C6 for bug-gnu-emacs@gnu.org; Wed, 15 Aug 2012 23:17:15 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1T1qif-0005zc-Ug for bug-gnu-emacs@gnu.org; Wed, 15 Aug 2012 23:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Aug 2012 03:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12051-submit@debbugs.gnu.org id=B12051.134508750922976 (code B ref 12051); Thu, 16 Aug 2012 03:26:01 +0000 Original-Received: (at 12051) by debbugs.gnu.org; 16 Aug 2012 03:25:09 +0000 Original-Received: from localhost ([127.0.0.1]:60066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1qhp-0005yX-Av for submit@debbugs.gnu.org; Wed, 15 Aug 2012 23:25:09 -0400 Original-Received: from mail-pb0-f44.google.com ([209.85.160.44]:34708) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1qhn-0005yQ-JR for 12051@debbugs.gnu.org; Wed, 15 Aug 2012 23:25:08 -0400 Original-Received: by pbbrr4 with SMTP id rr4so990075pbb.3 for <12051@debbugs.gnu.org>; Wed, 15 Aug 2012 20:16:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=FnHkudfVxcw5Ol3rr0Zkf8bz874YQO75ucKeKSXrzWc=; b=GemU46PjSwRAQV/nCtTltMExbf3VLX1nmGSiHAn8jTfQBq7AmuupgwsFEh5ktCVTUf 2NEsD2Nh5Tu5iUUvjnbAPW8u8FZ2GDMvQ+c5Y2QxSVDO6UyfNQhD2KMgeDhVPhi4WJtk 6FxrD+MdtjigL/BS3USiv2hbIW/h+zWby3W3+JgV60Mssv+e4/L0M84tF5IOraZY/6jx N0v53gYsNTW9V2QQzNUknrLVnFnc5AlURBEmtM2SRVSVbwX6imB3K95uumyl4AjR7IaI CMP6qZdgIJ6ewQB0bm4LklqTwCiTYxCalN07dRHgrFtVQ5NbnYs+k2TRf0GNGFPbjsS6 uooQ== Original-Received: by 10.68.242.228 with SMTP id wt4mr169051pbc.89.1345086978681; Wed, 15 Aug 2012 20:16:18 -0700 (PDT) Original-Received: from localhost ([119.255.41.67]) by mx.google.com with ESMTPS id hr1sm1684237pbc.23.2012.08.15.20.16.15 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 15 Aug 2012 20:16:17 -0700 (PDT) In-Reply-To: <83d32rv9bn.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Aug 2012 05:50:52 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (OS X 10.8) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:63213 On 2012-08-16 10:50 +0800, Eli Zaretskii wrote: >> By worst expansion, do you mean assuming each char to be 5 bytes? > > Yes. The will split English text at the boundary of 84 chars which seems sub-optimal. In the current implementation of rcirc-split-message, the inner loop might not be run if the encoding is utf-8, which we can assume to be 90% of the cases. So my suggestion is to leave it alone until we hit a real case of inefficiency. What do you think? Leo