* bug#24722: 26.0.50; incorrect Edebug spec for ert-with-test-buffer
@ 2016-10-17 23:15 Gemini Lasswell
2017-02-04 11:20 ` Eli Zaretskii
0 siblings, 1 reply; 2+ messages in thread
From: Gemini Lasswell @ 2016-10-17 23:15 UTC (permalink / raw)
To: 24722
[-- Attachment #1: Type: text/plain, Size: 268 bytes --]
To reproduce, starting at the root of the Emacs source tree:
1. emacs -Q
2. M-x edebug-all-defs RET
3. C-x C-f test/lisp/jit-lock-tests.el RET
4. M-x eval-buffer RET
Result: invalid-read-syntax "Failed matching" (form)
Here's a one line patch that fixes it for me:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-the-Edebug-spec-for-ert-with-test-buffer.patch --]
[-- Type: text/x-patch, Size: 870 bytes --]
From 721683d1f83b342504f25cc6fcb7363509f1c464 Mon Sep 17 00:00:00 2001
From: gazally <gazally@users.noreply.github.com>
Date: Mon, 17 Oct 2016 15:57:43 -0700
Subject: [PATCH] Fix the Edebug spec for ert-with-test-buffer
---
lisp/emacs-lisp/ert-x.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/emacs-lisp/ert-x.el b/lisp/emacs-lisp/ert-x.el
index 2a2418f..16ba560 100644
--- a/lisp/emacs-lisp/ert-x.el
+++ b/lisp/emacs-lisp/ert-x.el
@@ -97,7 +97,7 @@ ert--call-with-test-buffer
buffer is killed; if there is an error, the test buffer is kept
around on error for further inspection. Its name is derived from
the name of the test and the result of NAME-FORM."
- (declare (debug ((form) body))
+ (declare (debug ((":name" form) body))
(indent 1))
`(ert--call-with-test-buffer ,name-form (lambda () ,@body)))
--
2.10.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#24722: 26.0.50; incorrect Edebug spec for ert-with-test-buffer
2016-10-17 23:15 bug#24722: 26.0.50; incorrect Edebug spec for ert-with-test-buffer Gemini Lasswell
@ 2017-02-04 11:20 ` Eli Zaretskii
0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2017-02-04 11:20 UTC (permalink / raw)
To: Gemini Lasswell; +Cc: 24722-done
> From: Gemini Lasswell <gazally@runbox.com>
> Date: Mon, 17 Oct 2016 16:15:55 -0700
>
> To reproduce, starting at the root of the Emacs source tree:
>
> 1. emacs -Q
> 2. M-x edebug-all-defs RET
> 3. C-x C-f test/lisp/jit-lock-tests.el RET
> 4. M-x eval-buffer RET
>
> Result: invalid-read-syntax "Failed matching" (form)
>
> Here's a one line patch that fixes it for me:
Thanks, pushed.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-04 11:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-17 23:15 bug#24722: 26.0.50; incorrect Edebug spec for ert-with-test-buffer Gemini Lasswell
2017-02-04 11:20 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.