* bug#29557: lookup_basic_face: Should we add VERTICAL_BORDER_FACE_ID?
@ 2017-12-04 1:59 Keith David Bershatsky
2017-12-04 15:45 ` Eli Zaretskii
0 siblings, 1 reply; 2+ messages in thread
From: Keith David Bershatsky @ 2017-12-04 1:59 UTC (permalink / raw)
To: 29557
I had assumed that VERTICAL_BORDER_FACE_ID was a basic face (see dispextern.h at line 1750). However, it is not identified as such within lookup_basic_face. Is this something that should be added? Without it, Emacs will throw an error if someone tries to look it up and its not there.
case VERTICAL_BORDER_FACE_ID: name = Qvertical_border; break;
Thanks,
Keith
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#29557: lookup_basic_face: Should we add VERTICAL_BORDER_FACE_ID?
2017-12-04 1:59 bug#29557: lookup_basic_face: Should we add VERTICAL_BORDER_FACE_ID? Keith David Bershatsky
@ 2017-12-04 15:45 ` Eli Zaretskii
0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2017-12-04 15:45 UTC (permalink / raw)
To: Keith David Bershatsky; +Cc: 29557-done
> Date: Sun, 03 Dec 2017 17:59:34 -0800
> From: Keith David Bershatsky <esq@lawlist.com>
>
> I had assumed that VERTICAL_BORDER_FACE_ID was a basic face (see dispextern.h at line 1750). However, it is not identified as such within lookup_basic_face. Is this something that should be added? Without it, Emacs will throw an error if someone tries to look it up and its not there.
Yes, it's an omission (and a very old one).
Fixed on the master branch. Thanks for reporting this.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-04 15:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-04 1:59 bug#29557: lookup_basic_face: Should we add VERTICAL_BORDER_FACE_ID? Keith David Bershatsky
2017-12-04 15:45 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.