From: Robert Pluim <rpluim@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: emacs-devel@gnu.org
Subject: Re: search-default-mode char-fold-to-regexp and Greek Extended block characters
Date: Thu, 25 Jul 2019 10:46:12 +0200 [thread overview]
Message-ID: <m2a7d2mrhn.fsf@gmail.com> (raw)
In-Reply-To: <87blxj3u4e.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 25 Jul 2019 02:12:01 +0300")
>>>>> On Thu, 25 Jul 2019 02:12:01 +0300, Juri Linkov <juri@linkov.net> said:
Juri> This is an interesting case like (upcase "ß") => "SS" that required
Juri> adding (?ß "ss") to pass the tests. So I guess we need to add (?ι "ΐ")
Juri> for the tests to pass:
This is OK
Juri> diff --git a/test/lisp/char-fold-tests.el b/test/lisp/char-fold-tests.el
Juri> index e519435ef0..3819f3919d 100644
Juri> --- a/test/lisp/char-fold-tests.el
Juri> +++ b/test/lisp/char-fold-tests.el
Juri> @@ -166,6 +165,7 @@ char-fold--test-with-customization
Juri> (let* ((char-fold-include
Juri> '(
Juri> (?ß "ss") ;; de
Juri> + (?ι "ΐ") ;; el
Juri> (?o "ø") ;; da no nb nn
Juri> (?l "ł") ;; pl
Juri> ))
Juri> @@ -184,9 +184,7 @@ char-fold--test-with-customization
Juri> '(
Juri> ("e" "ℯ" "ḗ" "ë" "ë")
Juri> ("е" "ё" "ё")
Juri> - ("ι" "ί" "ί"
Juri> - ;; FIXME: "ΐ"
Juri> - )
Juri> + ("ι" "ί" "ί" "ΐ")
Juri> ("ß" "ss")
Juri> ("o" "ø")
Juri> ("l" "ł")
Juri> But this is only for char-fold--test-with-customization. OTOH, for
Juri> char-fold--test-without-customization we need also to change the default
Juri> value in char-fold.el like:
Juri> diff --git a/lisp/char-fold.el b/lisp/char-fold.el
Juri> index f379229e6c..c4add03bd9 100644
Juri> --- a/lisp/char-fold.el
Juri> +++ b/lisp/char-fold.el
Juri> @@ -27,7 +27,8 @@
Juri> (defconst char-fold--default-include
Juri> '((?\" """ "“" "”" "”" "„" "⹂" "〞" "‟" "‟" "❞" "❝" "❠" "“" "„" "〝" "〟" "🙷" "🙶" "🙸" "«" "»")
Juri> (?' "❟" "❛" "❜" "‘" "’" "‚" "‛" "‚" "" "❮" "❯" "‹" "›")
Juri> - (?` "❛" "‘" "‛" "" "❮" "‹")))
Juri> + (?` "❛" "‘" "‛" "" "❮" "‹")
Juri> + (?ι "ΐ")))
Juri> (defconst char-fold--default-exclude nil)
Juri> (defconst char-fold--default-symmetric nil)
Juri> (defconst char-fold--previous (list char-fold--default-include
But this one I donʼt understand. Searching for iota (capital or small)
in a buffer containing ΐ ΐ or Ϊ́ already works with
char-fold-to-regexp, so why is this needed?
Robert
next prev parent reply other threads:[~2019-07-25 8:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 14:18 search-default-mode char-fold-to-regexp and Greek Extended block characters Robert Pluim
2019-07-19 14:37 ` Eli Zaretskii
2019-07-19 16:03 ` Robert Pluim
2019-07-19 18:13 ` Eli Zaretskii
2019-07-21 11:03 ` Robert Pluim
2019-07-22 18:39 ` Robert Pluim
2019-07-23 14:57 ` Eli Zaretskii
2019-07-23 17:43 ` Robert Pluim
2019-07-23 20:29 ` Juri Linkov
2019-07-24 7:56 ` Robert Pluim
2019-07-24 7:59 ` Robert Pluim
2019-07-24 9:04 ` Robert Pluim
2019-07-24 23:12 ` Juri Linkov
2019-07-25 0:18 ` Basil L. Contovounesios
2019-07-25 18:40 ` Juri Linkov
2019-07-25 20:44 ` search-default-mode char-fold-to-regexp and Greek Extended block characters, " Robert Pluim
2019-07-25 21:35 ` Juri Linkov
2019-07-26 11:09 ` Robert Pluim
2019-07-26 18:38 ` Juri Linkov
2019-07-29 8:32 ` Robert Pluim
2019-07-29 18:09 ` Juri Linkov
2019-07-30 8:09 ` Robert Pluim
2019-07-30 10:15 ` Eli Zaretskii
2019-07-25 2:36 ` Eli Zaretskii
2019-07-25 8:59 ` Robert Pluim
2019-07-25 12:53 ` Eli Zaretskii
2019-07-25 8:46 ` Robert Pluim [this message]
2019-07-25 18:46 ` Juri Linkov
2019-07-26 6:04 ` Eli Zaretskii
2019-07-26 18:40 ` Juri Linkov
2019-07-26 19:13 ` Eli Zaretskii
2019-07-19 18:53 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2a7d2mrhn.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.