From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 39865@debbugs.gnu.org, viniciusjl@gmail.com
Subject: bug#39865: 28.0.50; Emacs crash
Date: Fri, 13 Mar 2020 16:09:25 +0100 [thread overview]
Message-ID: <m2a74ke1ga.fsf@gmail.com> (raw)
In-Reply-To: <83ftec8hyg.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 13 Mar 2020 16:09:27 +0200")
>>>>> On Fri, 13 Mar 2020 16:09:27 +0200, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Fri, 13 Mar 2020 10:35:14 +0100
>> Cc: 39865@debbugs.gnu.org
>>
>> Eli, the patch as it stands is not suitable for pushing to emacs-27,
>> since it breaks the macOS build, which doesnʼt have a
>> gui_default_font_parameter function. As far as I can tell (and have
>> tested :-) ), we can get away with a dummy one, since there is only
>> one font backend on macOS.
Eli> I'm okay with doing that. However, ...
>> If you agree, this is what the complete patch looks like:
Eli> ... this is not how we introduce terminal-dependent methods. We don't
Eli> define different versions of gui_SOMETHING functions in each
Eli> terminal-specific back-end. Instead, we add a member to 'struct
Eli> redisplay_interface', and then assign a different value to it in each
Eli> back-end. See how x_redisplay_interface, w32_redisplay_interface,
Eli> etc. are defined in the respective *term.[cm] files, and how they are
Eli> used via the FRAME_RIF macro.
OK, I can rework it using that.
Robert
next prev parent reply other threads:[~2020-03-13 15:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 1:39 bug#39865: 28.0.50; Emacs crash Vinicius José Latorre
2020-03-02 8:11 ` Eli Zaretskii
2020-03-05 1:03 ` Vinicius José Latorre
2020-03-05 22:21 ` Vinicius José Latorre
2020-03-06 7:18 ` Eli Zaretskii
2020-03-06 17:20 ` Vinicius José Latorre
2020-03-06 17:24 ` Vinicius José Latorre
2020-03-06 17:53 ` Eli Zaretskii
2020-03-10 14:29 ` Robert Pluim
2020-03-10 14:52 ` Eli Zaretskii
2020-03-10 14:54 ` Vinicius José Latorre
2020-03-10 15:20 ` Robert Pluim
2020-03-10 19:03 ` Vinicius José Latorre
2020-03-11 7:33 ` Robert Pluim
2020-03-11 20:45 ` Vinicius José Latorre
2020-03-12 9:39 ` Robert Pluim
2020-03-10 15:15 ` Robert Pluim
2020-03-11 16:58 ` Eli Zaretskii
2020-03-12 9:33 ` Robert Pluim
2020-03-12 10:25 ` Robert Pluim
2020-03-13 0:44 ` Vinicius José Latorre
2020-03-13 9:35 ` Robert Pluim
2020-03-13 14:09 ` Eli Zaretskii
2020-03-13 15:09 ` Robert Pluim [this message]
2020-03-17 10:16 ` Robert Pluim
2020-03-17 15:15 ` Eli Zaretskii
2020-03-17 16:06 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2a74ke1ga.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=39865@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=viniciusjl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.