From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Alex Ott Newsgroups: gmane.emacs.devel Subject: Re: pull requests Date: Fri, 17 Apr 2020 10:11:01 +0200 Organization: Alex Ott's Consulting Message-ID: References: <23160F4A-188A-4ADA-9EC4-B4C416CF7363@zjp.codes> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="51997"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (darwin) To: Zach Pearson , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 17 10:11:50 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jPM6H-000DPi-3W for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Apr 2020 10:11:49 +0200 Original-Received: from localhost ([::1]:43616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPM6G-0002BM-6O for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Apr 2020 04:11:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43226) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPM5d-0001if-W8 for emacs-devel@gnu.org; Fri, 17 Apr 2020 04:11:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jPM5c-0000t0-GH for emacs-devel@gnu.org; Fri, 17 Apr 2020 04:11:09 -0400 Original-Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:42934) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jPM5c-0000sd-9y for emacs-devel@gnu.org; Fri, 17 Apr 2020 04:11:08 -0400 Original-Received: by mail-pl1-x630.google.com with SMTP id v2so688382plp.9 for ; Fri, 17 Apr 2020 01:11:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:organization:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=poxKaaK4E712U/jAW4jv081YcfYWHooE2w5aOS4ASX4=; b=BVj8XhQ0k5PKBRfpqdzJ/pMUjCsJSGkowSKTKlN05WYxQ8k0GjLA9n6jw7LpHy2sMy VoLnoLA2721Dp/jOscUFuNVOfYXgcirhL/yCK44bBakRmm56ygZQuJAJSNF47P2pgWT7 bb2foo4jyV4YFkuRC/EaDTo9NvhdtyvUL1J7OQixAvd1W7yIie0lReRsgjkliD+/3TQi Jvre64l8zXcxDRsBhDrozmHEygRjk3btgcVl1hwtQzb2taQ0gB72urTctL3iXR6hUZ+/ GwvL8Jd4+sKpPusMCL+wu8UjD7uAtDXmv9KAI0STQoF+32Jo1LZL9iIGjnasJye4e0pH 243Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=poxKaaK4E712U/jAW4jv081YcfYWHooE2w5aOS4ASX4=; b=dGokezDEIJ435v6RDa1U2hcwpWAfmeNn8UXDmHB7A29JBZ5Dpbq34wjoZEgCjFNy67 wwmpUNStcv8zdIpcQk5AE81qjjobSHttBXQOmM6lapSzOocowWGdAcdTPkS8xMfBT8s4 6QH4kjcyXhjV+wnZ3lSzYRRO8+tiGITZXkqhnfoOsMqamUAVprshx8F1Np1Vm5zSPdL+ wMV7zA9aFA61P1GoB3DSuyIXzJGoQTJiAAfvQAOOGzVNpWU2Fle+L8fMvb3Bwz8JOYAw cRW0ES4obWlzNUy86yiBYwlgqnI8JXTs6BLCUCY4yME+JyPeKnVF/LGdTGzXHporPhSU /CpA== X-Gm-Message-State: AGi0PuaIMAMY9LrvQO8h39MXznm7NFr81ZUOSC592aEa6NdicnZM+e9x 49myiVyEwv+bjw/9vRxI583Zain2rw4= X-Google-Smtp-Source: APiQypII3+jLwDoYnYsrXrhmSEiVK37yiZBcbywGBIHrpBy3zBbr7NzdrWy4ZLwch4/fmeH+M16Nng== X-Received: by 2002:a17:902:5999:: with SMTP id p25mr2415128pli.189.1587111066234; Fri, 17 Apr 2020 01:11:06 -0700 (PDT) Original-Received: from thorium.local ([2a02:908:2210:9940:2060:7d90:733:713f]) by smtp.gmail.com with ESMTPSA id 127sm4091669pfz.128.2020.04.17.01.11.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2020 01:11:04 -0700 (PDT) In-Reply-To: <23160F4A-188A-4ADA-9EC4-B4C416CF7363@zjp.codes> (Zach Pearson's message of "Thu, 16 Apr 2020 23:24:56 -0500") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::630 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:247157 Archived-At: For GitHub there is https://hub.github.com/ - command line tool that allows to create a new PR, pull PR into your tree to review, look into issues, change issues, etc. It's integrated with Emacs tools, like, Magit (via https://github.com/vermiculus/magithub) Github also announced recently another tool with similar functionality: https://github.com/cli/cli, but I haven't try it. Zach Pearson at "Thu, 16 Apr 2020 23:24:56 -0500" wrote: ZP> I=E2=80=99m pretty sure GitHub will also let you open a pull request v= ia the command line if you ZP> want. Additionally, it emails PR threads to users that subscribe to th= em (initially ZP> maintainers) =E2=80=94 so if you=E2=80=99ve got write access and would= strongly prefer to keep your email ZP> based workflow it is known that it=E2=80=99s possible to keep it. >> On Apr 16, 2020, at 10:55 PM, Dmitry Gutov wrote: >>=20 >> =EF=BB=BFHi Richard, >>=20 >> Sorry for the late reply. I'll try to make a good description. >>=20 >>>>> On 02.04.2020 05:39, Richard Stallman wrote: >>> [[[ To any NSA and FBI agents reading my email: please consider ]]] >>> [[[ whether defending the US Constitution against all enemies, ]]] >>> [[[ foreign or domestic, requires you to follow Snowden's example. ]]] >>> I have never seen what a pull request is like to use. I do not use >>> the systems which support them. In trying to think about their >>> implications, I have to go by the descriptions people have sent me >>> in this discussion. >>> Unfortunately, the descriptions I've reaceived seen to conflict. >>> Perhaps people were describing different ways that different projects >>> or different platforms handle pull requests, but I did not know that >>> when I read them. >>=20 >> AFAIK, there are basically two different things that are called a "pull= request". >>=20 >> The first is basically an email with details about the repository and t= he branch you >> want code "pulled" from. There are more details here: >> https://www.kernel.org/doc/html/latest/maintainer/pull-requests.html, b= ut this is >> largely irrelevant to this discussion because a) we can do this already= (and don't need >> any help with that), b) our developers and contributors don't use this = approach. So it's >> not what we've been discussing. >>=20 >> The second one (which is what we're considering) has been popularized b= y the proprietary >> code forge called GitHub. In there, users can make 'forks' of the origi= nal repository, >> where a fork is basically a copy of the original repository that belong= s to the user's >> account (and its URL has the user's username in it). The said user can = create a new >> branch, push some changesets into it, and then propose the said branch = to the original >> repository and its developers for merging. By creating a "pull request". >>=20 >> It's a "thing": Github, as well as similar forges such as Gitlab, have = a dedicated type >> of issue (*) that's called a "pull request". It has all the features of= an "issue" >> (which generally means people can leave comments in it), as well as ext= ra features: it >> shows the author, the source branch, a multi-line description that the = author usually >> has to fill, the proposed commits, it can show the combined diff of tho= se commits, users >> can leave comments associated with individual lines of that diff (and t= he UI displays >> that neatly), they can lead threaded discussions on said commits (which= get semi-hidden >> as soon as the related code has changed), and the PR tracks the source = branch closely, >> so as soon as the user pushes some new changes to the branch, the infor= mation in the PR >> updates automatically. The PR web page can show the status of the CI bu= ild for the >> proposed branch. The main repository's maintainers can merge the PR wit= h just a couple >> of clicks with the mouse (this works best with small contributions). Th= ere are other >> features. >>=20 >> Overall, a lot of developers are used to this workflow and would never = choose patch >> submission over email. Of course, not everybody. Some people just don't= like web >> interfaces, for example. >>=20 >> (*) Issues are basically bug reports, but people can use them for discu= ssions, support questions, and so on. --=20 With best wishes, Alex Ott http://alexott.net/ Twitter: alexott_en (English), alexott (Russian)