bug#44386: 28.0.50; icomplete-mode with arg t stopped working

bug#44386: 28.0.50; icomplete-mode with arg t stopped working

[Pankaj Jangid]

I have this in my startup file:

--8<---------------cut here---------------start------------->8---
(add-hook 'emacs-startup-hook
	  (lambda ()
	    (icomplete-mode t)))
--8<---------------cut here---------------end--------------->8---

Till yesterday, it was working. In today's build it is
not. `icomplete-mode' is not active after startup.

Later, I found this in the docstring,

--8<---------------cut here---------------start------------->8---
If called from Lisp, toggle the mode if ARG is ‘toggle’.  Enable the
mode if ARG is nil, omitted, or is a positive number.  All other
values will disable the mode.
--8<---------------cut here---------------end--------------->8---

And setting `t' to `+1' worked. But I am just curious if this is a
recent change that even a truth value `t' is not enabling the mode.



In GNU Emacs 28.0.50 (build 1, x86_64-apple-darwin19.6.0, NS appkit-1894.60 Version 10.15.7 (Build 19H2))
 of 2020-11-02 built on mb2.local
Repository revision: 5ab5504def63ebdfba08169f24a5829353bff137
Repository branch: master
Windowing system distributor 'Apple', version 10.3.1894
System Description:  Mac OS X 10.15.7

Configured using:
 'configure LDFLAGS=-L/usr/local/opt/ruby/lib
 CPPFLAGS=-I/usr/local/opt/ruby/include
 PKG_CONFIG_PATH=:/usr/local/opt/sqlite/lib/pkgconfig:/usr/local/opt/libxml2/lib/pkgconfig:/usr/local/opt/openssl/lib/pkgconfig:/usr/local/opt/libffi/lib/pkgconfig:/usr/local/opt/ruby/lib/pkgconfig'

Configured features:
JPEG TIFF GIF PNG RSVG DBUS GLIB NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB
TOOLKIT_SCROLL_BARS NS MODULES THREADS JSON PDUMPER LCMS2

Important settings:
  value of $LC_CTYPE: UTF-8
  value of $LANG: en_IN.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml easymenu mml-sec epa derived epg epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode elisp-mode lisp-mode prog-mode register page
tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse
jit-lock font-lock syntax facemenu font-core term/tty-colors frame
minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite charscript charprop case-table epa-hook jka-cmpr-hook help
simple abbrev obarray cl-preloaded nadvice button loaddefs faces
cus-face macroexp files window text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind kqueue cocoa ns lcms2 multi-tty
make-network-process emacs)

Memory information:
((conses 16 52040 8207)
 (symbols 48 6730 0)
 (strings 32 17861 2630)
 (string-bytes 1 607105)
 (vectors 16 12402)
 (vector-slots 8 168740 8308)
 (floats 8 21 47)
 (intervals 56 205 0)
 (buffers 992 11))

-- 
Pankaj

bug#44386: 28.0.50; icomplete-mode with arg t stopped working

[Andreas Schwab]

See commit 2a4b0da28c.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

bug#44386: 28.0.50; icomplete-mode with arg t stopped working

[Lars Ingebrigtsen]

Pankaj Jangid <pankaj@codeisgreat.org> writes:

> I have this in my startup file:
>
> (add-hook 'emacs-startup-hook
> 	  (lambda ()
> 	    (icomplete-mode t)))

This has been fixed on the trunk; closing.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44386: 28.0.50; icomplete-mode with arg t stopped working

[Pankaj Jangid]

Lars Ingebrigtsen <larsi@gnus.org> writes:

>> I have this in my startup file:
>>
>> (add-hook 'emacs-startup-hook
>> 	  (lambda ()
>> 	    (icomplete-mode t)))
>
> This has been fixed on the trunk; closing.

Just tested it. The behaviour is still the same. Working with
`(icomplete-mode +1)' but not with `(icomplete-mode t)'.

commit 5cea77af41b59ba6f6386264812c36ec31ba2efc

bug#44386: 28.0.50; icomplete-mode with arg t stopped working

[Lars Ingebrigtsen]

Pankaj Jangid <pankaj@codeisgreat.org> writes:

> Just tested it. The behaviour is still the same. Working with
> `(icomplete-mode +1)' but not with `(icomplete-mode t)'.

Have you tried a "make bootstrap"?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44386: 28.0.50; icomplete-mode with arg t stopped working

[Pankaj Jangid]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Pankaj Jangid <pankaj@codeisgreat.org> writes:
>
>> Just tested it. The behaviour is still the same. Working with
>> `(icomplete-mode +1)' but not with `(icomplete-mode t)'.
>
> Have you tried a "make bootstrap"?

Now I did that. It is working fine. Sorry about that.

Because only few lines where changed I just did `make' instead of full
`make bootstrap'. Probably I should do it everytime.

bug#44386: 28.0.50; icomplete-mode with arg t stopped working

[Andreas Schwab]

On Nov 02 2020, Pankaj Jangid wrote:

> Because only few lines where changed I just did `make' instead of full
> `make bootstrap'. Probably I should do it everytime.

Since the few lines changed a macro, it can spill into a lot of files.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."