From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id cDPuHck17WQLYQEAauVa8A:P1 (envelope-from ) for ; Tue, 29 Aug 2023 02:03:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id cDPuHck17WQLYQEAauVa8A (envelope-from ) for ; Tue, 29 Aug 2023 02:03:21 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 36AC054D59 for ; Tue, 29 Aug 2023 02:03:21 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=me.com header.s=1a1hai header.b=XNxzbjVu; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=quarantine) header.from=me.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693267401; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=3qGsca/H6trFZQRODUhcU+Aj/Jy7EWzn4igWAxn4fA8=; b=ryXse7D+vbPUFsr1mcrkiNv0keP3EKdFS0U9JEaASwJLg7q2L/wDwvqMuFPRBaY98m+loT tAO80B8Z9EEOWwnubmfJboctVjSa1ANNNNgh0uQDzwQprXqAWp6DXw/xDC+jdodOT2cart 7iVE8pCNYtFZSeJGristGlOnCOusKvq2UySVTnKJd+Rbc+6Va2jPcs98wRVvc5hyTmW7uo kKa33iSQ8ec8B75tLYQCuHmgND5PLJ3UgqHsc9KLas7Lh+Ayvpn0rl0HyeXfPr9oiPe82i H0/3HfkUuoTYHlCVx5At3VWNpYaAK9Id3veBDk+WGlgaL6rFjnCc4O4bsuGBXg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=me.com header.s=1a1hai header.b=XNxzbjVu; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=quarantine) header.from=me.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693267401; a=rsa-sha256; cv=none; b=pm6++37szYjBz4m+OJv3JFPD4tJcY2hifshTReK6QRnYLxTuV/poemXupZhzdYtOkRX8rr YRGxxLzO+d/DjOr87kJGmy2d1uYIHoKQX9ccm3RUK2/pXLJoDaV68HMZBNltHk7YQOXs21 1YbSHFigkXX4+jqywjpkRVx60+G8hE5GP02qw+rTR0Z/LawVDv1sCVk0s6dQJZOQdyyk/O s+EFL3qLEf3Gg+jocHJMH180az5gY+SXRU+xzC0ef7MaPtoY9aIEcjD8NY08nl8p1EEU2H 7nSuyS3clbIEEqWtqAksFEpYBQcC1FPByZRHbbAQvoGleGgQLS6VJXfu6DdqnA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qamBp-0006ZD-6g; Mon, 28 Aug 2023 20:02:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qamBo-0006Yo-0z for emacs-orgmode@gnu.org; Mon, 28 Aug 2023 20:02:36 -0400 Received: from pv50p00im-ztdg10012101.me.com ([17.58.6.49]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qamBl-0001un-OG for emacs-orgmode@gnu.org; Mon, 28 Aug 2023 20:02:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1693267350; bh=3qGsca/H6trFZQRODUhcU+Aj/Jy7EWzn4igWAxn4fA8=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=XNxzbjVuHgepOTK59NKswq9QCv9DCBDZfWzhnPihS4EE3X4vWTVClwhOkDYtbCYCo TtLCY9g2TpNTMsC37YhIRILbi5fkQB68zCKB8uysjPqKBEuVGsvqVbN4Wfc1VDrrle /ksI+vfb2UWkOKXZqV0R2Si+MuE43SAlLaBvTuE5kk2WQ2XjGuIOIsQmKagZPG+eq2 4WA0nltcL3/UuXYfGcFHkoqIGedggfHs2Z05fOGMrTH9dvre3/Fk5iOCB7rN5/QBTp zDUCPDTrdELo5OkASOb+2ezjMHl8eGyX7HSKXSehLLlxypHE1xQun6nPkWDzEZTyEx h7kvLxd/uavGA== Received: from Rudolfs-MacBook-Air.local (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-ztdg10012101.me.com (Postfix) with ESMTPSA id 39F1C740150; Tue, 29 Aug 2023 00:02:27 +0000 (UTC) From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Fix a possibly problematic string comparison In-Reply-To: <878r9v4kt4.fsf@localhost> References: <20230827214320.46754-1-salutis@me.com> <878r9v4kt4.fsf@localhost> Date: Tue, 29 Aug 2023 02:02:24 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: WMGFznCN97CVKFD5GUAFpk_ldrODu3Jj X-Proofpoint-ORIG-GUID: WMGFznCN97CVKFD5GUAFpk_ldrODu3Jj X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.517,18.0.883,17.0.605.474.0000000_definitions?= =?UTF-8?Q?=3D2022-06-21=5F08:2022-06-21=5F01,2022-06-21=5F08,2020-01-23?= =?UTF-8?Q?=5F02_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 spamscore=0 clxscore=1015 adultscore=0 mlxscore=0 mlxlogscore=848 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2308280206 Received-SPF: pass client-ip=17.58.6.49; envelope-from=salutis@me.com; helo=pv50p00im-ztdg10012101.me.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: -6.68 X-Spam-Score: -6.68 X-Migadu-Queue-Id: 36AC054D59 X-TUID: 1gPNunXUBwQz Ihor Radchenko writes: > This is not as trivial. Applying this patch will break tests. > One needs to carefully examine the org-table logic to fix this > particular warning. Wow! You are right. How is that even possible? In other words, what value (of 'elements') can possibly be object-equal to a literal "" but not string-equal to the same literal "" or vice versa? Rudy --=20 "Logic is a science of the necessary laws of thought, without which no employment of the understanding and the reason takes place." -- Immanuel Kant, 1785 Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25 84103 Bratislava Slovakia