From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: Question about child frames + menu bar Date: Tue, 17 Sep 2024 12:47:24 +0200 Message-ID: References: <082cd34e-0b45-4376-a6db-eee7e016bb4a@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21003"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Emacs Devel To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 17 12:48:32 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sqVl1-0005L7-RI for ged-emacs-devel@m.gmane-mx.org; Tue, 17 Sep 2024 12:48:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqVkE-0006kA-BZ; Tue, 17 Sep 2024 06:47:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVk4-0006Pt-Dr for emacs-devel@gnu.org; Tue, 17 Sep 2024 06:47:33 -0400 Original-Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sqVk0-00017O-VF for emacs-devel@gnu.org; Tue, 17 Sep 2024 06:47:31 -0400 Original-Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-a8d24f98215so608683266b.1 for ; Tue, 17 Sep 2024 03:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726570046; x=1727174846; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=wtI6LgkuXJWhMnxCUBGHsy7uYHmjwxk3OLZ/h35N9ec=; b=iVEJdd/A1aECmXC134D/YFzbE+C/BRDAHKYPf4eNLqfdWx+Z8T9rLAvj5/JZ0L8lR9 70lb0u0uPW7gTlrecgbI+VzoBSgzkuTKZyyTqHJn7DOKDGXFPiNM0qotmaYWAg61Jf2R GlwRM344xsaXaYmWA56b+lC4w5EOmKlefFV0YiZJFXcqPLMGCknUP3Xw/WenQGAkR6bD UdO2LQO2h0eXINE+SHFKlLeeVYxiOyxdVw4hCP304gBk5exQXuPolnlwcgQDH2a5WvEm rB2fW7lKAuooHDN8EbYWRpcKW8V2nT1DR5uYGXijmwbwmOehzfo2JOJZZZskk10sPCQN t8zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726570046; x=1727174846; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wtI6LgkuXJWhMnxCUBGHsy7uYHmjwxk3OLZ/h35N9ec=; b=oWR/Z8ZeYgH23Vv5B2pBXbW62MymV7jToled3heQ/BtYQY8r5PVfxlFALtNnnLtcn3 1xs3OBse8rjqu6yIqRNSSetQ7J9E+Ks24l1f41E0sBO8ztdhu2MZSAIoXL74Gb7YiOVY 9Juws+7qHqtMFLo3TH8xsk5gW4i2Z3wRvDWxDyqzM59FbSFVXduLmmyFu26IVCFljlqN dYpp3EcLqQWTOi0yfTGCBHYmQ/02BiwM4O+3tEnWhClvYwYyZT1XoRDLYENfQ/fuXGRM h6LuAO5Qn4RhnbtNBgnTBzBDUlb5gcUs1YJsQYSVjLie/YFl9OM/j6N9u5Dy4fLrUQHi cDxg== X-Gm-Message-State: AOJu0Yyu5Wl2LgLvwjwyoAFLZKpsCIBF9xJv7EVa+W9BL1EJz0DYJ+Mk iqnapk9HNc3xch7vPVmDcuyNB2bFVfwyWyGRIL843roUZ7fx2nPKexpUiA== X-Google-Smtp-Source: AGHT+IGTsUa9Y8CGlgdrGUrUG1bQx+G1jr6V7PIBeuBYYRUKtOuVtsmc+E575z9UdqbBaxs8m3pOGw== X-Received: by 2002:a17:907:3fa7:b0:a86:812a:d2ca with SMTP id a640c23a62f3a-a9047ca9912mr1702874166b.25.1726570046005; Tue, 17 Sep 2024 03:47:26 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e3629f.dip0.t-ipconnect.de. [217.227.98.159]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a90612e5617sm434963166b.177.2024.09.17.03.47.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Sep 2024 03:47:25 -0700 (PDT) In-Reply-To: <082cd34e-0b45-4376-a6db-eee7e016bb4a@gmx.at> (martin rudalics's message of "Tue, 17 Sep 2024 12:20:29 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323687 Archived-At: martin rudalics writes: >> Do you perhaps remember what this change was about? I read the bug that >> the commit message references but couldn't figure out how this bug is >> related. Or, maybe, is there something special about menu bars on child >> frames, like they may not have a menu bar, or something? > > As far as this change for the selected frame case > > - update_menu_bar (sf, true, false); > + > + if (!FRAME_PARENT_FRAME (sf)) > + update_menu_bar (sf, true, false); > > is concerned, I can only guess that when I tried to fix the bug above I > noticed that we did call update_menu_bar for the case that the selected > frame is a child frame and tried to avoid that. The rationale was that > when I implemented child frames, I noticed that menu bars don't work > with child frames under X while they worked well on MS Windows. Now at > that time there was a strict policy that we were not allowed to > implement features that worked on non-free systems only. So I switched > off menu bars in child frames everywhere and made the change above to be > on the safe side. Thanks, that explains it, I guess, although on macOS child frames seem to support menus, heaven knows how that works. > If you want to implement menu bars on TTY child frames, you probably > will have to special case that here and maybe in other places as well. Hm, not sure what I should do. On one hand, I could suppress the menu bar on chlid frames in some way, which would hopefully be easy (haven't looked, but maybe not accepting menu-bar-lines changes to non-zero. Or I could make the condition "!PARENT_FRAME || on tty" plus fix the menu position bug. Should also not be too difficult I guess, but a bit more work. Any preferences, anyone?