all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Gerd Möllmann" <gerd.moellmann@gmail.com>
To: Fejfighter <fejfighter@gmail.com>
Cc: 74224@debbugs.gnu.org
Subject: bug#74224: [PATCH][scratch/igc] pgtk: fix crashing bug in atimer used for checking scaling
Date: Wed, 06 Nov 2024 09:56:18 +0100	[thread overview]
Message-ID: <m2a5ecwxjh.fsf@gmail.com> (raw)
In-Reply-To: <CALohuRCR+4zRd+7Y2mZxTMoN2Tk8B0nRP0JkaryqUW8iUFjwRA@mail.gmail.com> (fejfighter@gmail.com's message of "Wed, 6 Nov 2024 19:04:42 +1100")

Fejfighter <fejfighter@gmail.com> writes:

> This patch marks 2 outstanding ambiguous roots and appears to solve
> crashing bugs I had been experiencing with igc/mps and pgtk.
>
> I have run this locally today, and I would have normally faced crashes
> at timer expiration, this appears to be holding up.

Thanks for the report, Jeff! Nice to see that someone besides me is
using this :-).

I think I see why the change in atimer.c is necessary: pgtk stores a
struct frame * as client_data in an atimer structure. That's a Lisp
object that can move during GC. Understood.

The other change in pgtkterm.c I don't understand. AFAICS, x_id_name of
the display_info structure is indeed only used as a character buffer
into which characters from Lisp strings are memcpy'd. Could you please
explain that one? (I'm macOS only, so I don't know anything about pgtk,
if that matters.)





  reply	other threads:[~2024-11-06  8:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-06  8:04 bug#74224: [PATCH][scratch/igc] pgtk: fix crashing bug in atimer used for checking scaling Fejfighter
2024-11-06  8:56 ` Gerd Möllmann [this message]
2024-11-06  9:30   ` Jeff Walsh
2024-11-06 10:34     ` Gerd Möllmann
2024-11-06 10:36     ` Gerd Möllmann
2024-11-06 10:44       ` Jeff Walsh
2024-11-06 10:49         ` Gerd Möllmann
2024-11-06 13:17           ` Eli Zaretskii
2024-11-06 13:39             ` Gerd Möllmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2a5ecwxjh.fsf@gmail.com \
    --to=gerd.moellmann@gmail.com \
    --cc=74224@debbugs.gnu.org \
    --cc=fejfighter@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.