From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: Jason Rumney <jasonr@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: No calc in pretest?
Date: 02 Jul 2002 22:46:36 +0100
Sender: emacs-devel-admin@gnu.org
Message-ID: <m28z4tx0oz.fsf@nyaumo.btinternet.com>
References: <200207022038.g62KcQs19292@d-ip-129-15-78-125.cs.ou.edu>
NNTP-Posting-Host: localhost.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: main.gmane.org 1025720691 3120 127.0.0.1 (3 Jul 2002 18:24:51 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Wed, 3 Jul 2002 18:24:51 +0000 (UTC)
Cc: storm@cua.dk (Kim F. Storm),
	Emacs Devel Mailing List <emacs-devel@gnu.org>
Return-path: <emacs-devel-admin@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by main.gmane.org with esmtp (Exim 3.33 #1 (Debian))
	id 17Poo7-0000oD-00
	for <emacs-devel@main.gmane.org>; Wed, 03 Jul 2002 20:24:51 +0200
Original-Received: from fencepost.gnu.org ([199.232.76.164])
	by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian))
	id 17Potj-0000AW-00
	for <emacs-devel@quimby.gnus.org>; Wed, 03 Jul 2002 20:30:40 +0200
Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org)
	by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian))
	id 17PonN-0007zn-00; Wed, 03 Jul 2002 14:24:05 -0400
Original-Received: from rhenium.btinternet.com ([194.73.73.93])
	by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian))
	id 17Polk-0007uS-00
	for <emacs-devel@gnu.org>; Wed, 03 Jul 2002 14:22:25 -0400
Original-Received: from host62-7-114-29.in-addr.btopenworld.com ([62.7.114.29] helo=nyaumo.btinternet.com)
	by rhenium.btinternet.com with esmtp (Exim 3.22 #8)
	id 17Polc-0006yc-00; Wed, 03 Jul 2002 19:22:17 +0100
Original-Received: from nyaumo.btinternet.com (nyaumo.btinternet.com [127.0.0.1])
	by nyaumo.btinternet.com (Postfix) with ESMTP
	id 26A0E4AE67; Tue,  2 Jul 2002 22:46:36 +0100 (BST)
Original-To: Jon Cast <jcast@ou.edu>
In-Reply-To: <200207022038.g62KcQs19292@d-ip-129-15-78-125.cs.ou.edu>
Original-Lines: 19
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
Errors-To: emacs-devel-admin@gnu.org
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.0.11
Precedence: bulk
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Post: <mailto:emacs-devel@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
List-Id: Emacs development discussions. <emacs-devel.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel/>
Xref: main.gmane.org gmane.emacs.devel:5408
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:5408

Jon Cast <jcast@ou.edu> writes:

> storm@cua.dk (Kim F. Storm) wrote:
> <snip>
> > It uses high-numbered "minor-minor" numbers (which I think is a good
> > idea), but the "minor" number of the pretest is plain wrong!
> 
> > The pretest has the same minor number as the previous release, so
> > code cannot test emacs-minor-version for any practical purpose.
> 
> Don't test emacs-minor-version.  Do a lexicographic test on
> emacs-version, comparing against 21.3.90.  That'll ensure you've got
> any non-CVS release containing the features of 21.4.

Even better, test for features, not for version numbers.

> > I don't know any code which breaks because of this though.

Probably because in most cases code does the above.