* [patch] bug-reference.el
@ 2012-07-19 12:14 Arne Jørgensen
2012-09-17 6:37 ` Arne Jørgensen
0 siblings, 1 reply; 2+ messages in thread
From: Arne Jørgensen @ 2012-07-19 12:14 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 358 bytes --]
Hi,
I think bug-reference.el is missing a "(provide 'bug-reference)".
And I would suggest changing `bug-reference-bug-regexp' from a constant
to a variable and marking it as safe-local-variable for
`string-or-null-p'. This way it is possible to bind it in .dir-locals.el
like it is already possible to bind `bug-reference-url-format'.
Kind regards,
Arne
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: bug-reference.patch --]
[-- Type: text/x-patch, Size: 817 bytes --]
--- bug-reference.el-OLD 2012-07-19 14:09:15.000000000 +0200
+++ bug-reference.el 2012-07-19 14:07:17.000000000 +0200
@@ -61,10 +61,13 @@
(and (symbolp s)
(get s 'bug-reference-url-format)))))
-(defconst bug-reference-bug-regexp
+(defvar bug-reference-bug-regexp
"\\([Bb]ug ?#\\|[Pp]atch ?#\\|RFE ?#\\|PR [a-z-+]+/\\)\\([0-9]+\\(?:#[0-9]+\\)?\\)"
"Regular expression which matches bug references.")
+;;;###autoload
+(put 'bug-reference-bug-regexp 'safe-local-variable 'string-or-null-p)
+
(defun bug-reference-set-overlay-properties ()
"Set properties of bug reference overlays."
(put 'bug-reference 'evaporate t)
@@ -154,4 +157,6 @@
(widen)
(bug-reference-unfontify (point-min) (point-max)))))
+(provide 'bug-reference)
+
;;; bug-reference.el ends here
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] bug-reference.el
2012-07-19 12:14 [patch] bug-reference.el Arne Jørgensen
@ 2012-09-17 6:37 ` Arne Jørgensen
0 siblings, 0 replies; 2+ messages in thread
From: Arne Jørgensen @ 2012-09-17 6:37 UTC (permalink / raw)
To: emacs-devel
Arne Jørgensen <arne@arnested.dk> writes:
> And I would suggest changing `bug-reference-bug-regexp' from a constant
> to a variable and marking it as safe-local-variable for
> `string-or-null-p'. This way it is possible to bind it in .dir-locals.el
> like it is already possible to bind `bug-reference-url-format'.
Glenn Morris committed a similar solution in 109739.
Thanks.
Arne
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-17 6:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-19 12:14 [patch] bug-reference.el Arne Jørgensen
2012-09-17 6:37 ` Arne Jørgensen
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.