From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Keith David Bershatsky Newsgroups: gmane.emacs.bugs Subject: bug#15189: 24.3.50; display-buffer does not work well with custom frames. Date: Tue, 27 Aug 2013 15:30:09 -0700 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (generated by - "") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1377642676 29976 80.91.229.3 (27 Aug 2013 22:31:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 27 Aug 2013 22:31:16 +0000 (UTC) Cc: 15189@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 28 00:31:19 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VERnC-0004Hs-In for geb-bug-gnu-emacs@m.gmane.org; Wed, 28 Aug 2013 00:31:18 +0200 Original-Received: from localhost ([::1]:59024 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VERnC-0006ku-6S for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Aug 2013 18:31:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VERn3-0006kU-Gt for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2013 18:31:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VERmx-0004My-Mp for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2013 18:31:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37447) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VERmx-0004Mi-GX for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2013 18:31:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VERmw-0003Gr-H3 for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2013 18:31:03 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Keith David Bershatsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Aug 2013 22:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15189-submit@debbugs.gnu.org id=B15189.137764261712506 (code B ref 15189); Tue, 27 Aug 2013 22:31:02 +0000 Original-Received: (at 15189) by debbugs.gnu.org; 27 Aug 2013 22:30:17 +0000 Original-Received: from localhost ([127.0.0.1]:59995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VERmC-0003Fa-6p for submit@debbugs.gnu.org; Tue, 27 Aug 2013 18:30:17 -0400 Original-Received: from cobb.liquidweb.com ([50.28.13.150]:37686) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VERm7-0003FQ-Qy for 15189@debbugs.gnu.org; Tue, 27 Aug 2013 18:30:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lawlist.com; s=default; h=Content-Type:MIME-Version:Cc:Subject:To:From:Message-ID:Date; bh=zcrVy+lYW9FtHdxmpZ839VbFVoyMe5lyIeaZbUSITXw=; b=69yN6+zOwlvim5P7H/lWlyfHneWhh+r09F6pJK/fS0Pe69W5TiOTQT52igpnTXbRTh0uFwPvIqhMy/Ts9oGQuPWCkkvTNknHDLRQMD6DwZkiUN1bkykxqQdB7PmS2dZc; Original-Received: from cpe-75-85-5-102.socal.res.rr.com ([75.85.5.102]:52324 helo=MP.local) by cobb.liquidweb.com with esmtp (Exim 4.80.1) (envelope-from ) id 1VERm5-00039C-IM; Tue, 27 Aug 2013 18:30:09 -0400 User-Agent: / () / () APEL/10.8 Emacs/24.3.50 (x86_64-apple-darwin10.8.0) MULE/6.0 (HANACHIRUSATO) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cobb.liquidweb.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lawlist.com X-Get-Message-Sender-Via: cobb.liquidweb.com: acl_c_relayhosts_text_entry: lawlist|lawlist.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:77775 Archived-At: Thank you for the suggestions and examples -- greatly appreciated !!! Here is the revised code that appears to be working correctly for both types of situations -- i.e., file-visiting buffers, and nofile-visiting buffers. Keith ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; EXAMPLE ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; (defun example () (interactive) (custom-find-file "*bar*") (set-frame-position (selected-frame) 0 0) (minibuffer-message "\*bar\* appears in frame name SYSTEM.") (sit-for 3) (custom-find-file "foo.txt") (set-frame-position (selected-frame) 100 100) (minibuffer-message "\"foo.txt\" appears in frame name MAIN.") (sit-for 3) (custom-find-file "doe.org") (set-frame-position (selected-frame) 200 200) (minibuffer-message "\"doe.org\" appears in frame name ORG.") (sit-for 3) (custom-find-file "*undefined*") (set-frame-position (selected-frame) 300 300) (minibuffer-message "\*undefined\* appears in frame name MISCELLANEOUS.") (sit-for 3) (display-buffer (get-buffer-create "*example*")) (other-window 1) (minibuffer-message "display-buffer-alist controls where \*example\* is displayed.") (sit-for 3) (kill-buffer "*bar*") (kill-buffer "foo.txt") (kill-buffer "doe.org") (kill-buffer "*undefined*") (kill-buffer "*example*") (make-frame) (delete-frame (get-frame "SYSTEM")) (delete-frame (get-frame "MAIN")) (delete-frame (get-frame "ORG")) (delete-frame (get-frame "MISCELLANEOUS"))) ;;;;;;;;;;;;;;;;;;;;;;;;;;;;; FILE-VISITING BUFFER ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; (defvar lawlist-regexp-frame-names "^\\(?:MAIN\\|SYSTEM\\|ORG\\|MISCELLANEOUS\\)$" "Regexp matching frames with specific names.") (defvar lawlist-system-buffer-regexp nil "Regexps matching `buffer-filename` for frame name `SYSTEM`.") (setq lawlist-system-buffer-regexp '("*scratch*" "*bar*")) (defvar lawlist-main-buffer-regexp nil "Regexps matching `buffer-filename` for frame name `MAIN`.") (setq lawlist-main-buffer-regexp '("\\.txt" "\\.tex" "\\.el" "\\.yasnippet")) (defvar lawlist-org-buffer-regexp nil "Regexps matching `buffer-filename` for frame name `ORG`.") (setq lawlist-org-buffer-regexp '("[*]todo-list[*]" "\\.org_archive" "\\.org")) (defvar buffer-filename nil) (defun custom-find-file (&optional buffer-filename) "Locate or create a specific frame, and then open the file." (interactive) (unless buffer-filename (setq buffer-filename (read-file-name "Select File: "))) (if buffer-filename (progn (setq display-buffer-function 'lawlist-display-buffer-function) (display-buffer (find-file-noselect buffer-filename)) (setq display-buffer-function nil) ))) (defun lawlist-display-buffer-function (&optional buffer flag) (if buffer-filename (progn (cond ((lawlist-regexp-match-p lawlist-org-buffer-regexp buffer-filename) (if (frame-exists "ORG") (switch-to-frame "ORG") ;; If unnamed frame exists, then take control of it. (catch 'break (dolist (frame (frame-list)) (if (not (string-match lawlist-regexp-frame-names (frame-parameter frame 'name))) (throw 'break (progn (switch-to-frame (frame-parameter frame 'name)) (set-frame-name "ORG")))))) ;; If dolist found no unnamed frame, then create / name it. (if (not (frame-exists "ORG")) (progn (make-frame) (set-frame-name "ORG"))) )) ((lawlist-regexp-match-p lawlist-main-buffer-regexp buffer-filename) (if (frame-exists "MAIN") (switch-to-frame "MAIN") ;; If unnamed frame exists, then take control of it. (catch 'break (dolist (frame (frame-list)) (if (not (string-match lawlist-regexp-frame-names (frame-parameter frame 'name))) (throw 'break (progn (switch-to-frame (frame-parameter frame 'name)) (set-frame-name "MAIN")))))) ;; If dolist found no unnamed frame, then create / name it. (if (not (frame-exists "MAIN")) (progn (make-frame) (set-frame-name "MAIN"))) )) ((lawlist-regexp-match-p lawlist-system-buffer-regexp buffer-filename) (if (frame-exists "SYSTEM") (switch-to-frame "SYSTEM") ;; If unnamed frame exists, then take control of it. (catch 'break (dolist (frame (frame-list)) (if (not (string-match lawlist-regexp-frame-names (frame-parameter frame 'name))) (throw 'break (progn (switch-to-frame (frame-parameter frame 'name)) (set-frame-name "SYSTEM")))))) ;; If dolist found no unnamed frame, then create / name it. (if (not (frame-exists "SYSTEM")) (progn (make-frame) (set-frame-name "SYSTEM"))) )) ((and (not (lawlist-regexp-match-p lawlist-org-buffer-regexp buffer-filename)) (not (lawlist-regexp-match-p lawlist-main-buffer-regexp buffer-filename)) (not (lawlist-regexp-match-p lawlist-system-buffer-regexp buffer-filename)) ) (if (frame-exists "MISCELLANEOUS") (switch-to-frame "MISCELLANEOUS") ;; If unnamed frame exists, then take control of it. (catch 'break (dolist (frame (frame-list)) (if (not (string-match lawlist-regexp-frame-names (frame-parameter frame 'name))) (throw 'break (progn (switch-to-frame (frame-parameter frame 'name)) (set-frame-name "MISCELLANEOUS")))))) ;; If dolist found no unnamed frame, then create / name it. (if (not (frame-exists "MISCELLANEOUS")) (progn (make-frame) (set-frame-name "MISCELLANEOUS"))))) (t (display-buffer-same-window))) (switch-to-buffer (get-file-buffer buffer-filename)) ))) ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; DISPLAY BUFFER NO FILE ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; (defvar system-nofile-regexp nil "Regexps matching `buffer-name buffer` for frame name `SYSTEM`.") (setq system-nofile-regexp '("\\(\\*Metahelp\\*\\|\\*Help\\*\\)")) (defvar main-nofile-regexp nil "Regexps matching `buffer-name buffer` for frame name `MAIN`.") (setq main-nofile-regexp '("\\*example\\*")) (defvar org-nofile-regexp nil "Regexps matching `buffer-name buffer` for frame name `ORG`.") (setq org-nofile-regexp '("\\*Org Agenda\\*")) (setq display-buffer-alist '((lawlist-p . (nofile-display-buffer-pop-up-frame)))) (defun lawlist-p (buffer action) (let ((buffer (get-buffer buffer))) (or (lawlist-regexp-match-p org-nofile-regexp (buffer-name buffer)) (lawlist-regexp-match-p main-nofile-regexp (buffer-name buffer)) (lawlist-regexp-match-p system-nofile-regexp (buffer-name buffer)) ))) (defun nofile-display-buffer-pop-up-frame (buffer alist) (cond ((lawlist-regexp-match-p org-nofile-regexp (buffer-name buffer)) (if (frame-exists "ORG") (switch-to-frame "ORG") ;; If unnamed frame exists, then take control of it. (catch 'break (dolist (frame (frame-list)) (if (not (string-match lawlist-regexp-frame-names (frame-parameter frame 'name))) (throw 'break (progn (switch-to-frame (frame-parameter frame 'name)) (set-frame-name "ORG")))))) ;; If dolist found no unnamed frame, then create / name it. (if (not (frame-exists "ORG")) (progn (make-frame) (set-frame-name "ORG"))) )) ((lawlist-regexp-match-p main-nofile-regexp (buffer-name buffer)) (if (frame-exists "MAIN") (switch-to-frame "MAIN") ;; If unnamed frame exists, then take control of it. (catch 'break (dolist (frame (frame-list)) (if (not (string-match lawlist-regexp-frame-names (frame-parameter frame 'name))) (throw 'break (progn (switch-to-frame (frame-parameter frame 'name)) (set-frame-name "MAIN")))))) ;; If dolist found no unnamed frame, then create / name it. (if (not (frame-exists "MAIN")) (progn (make-frame) (set-frame-name "MAIN"))) )) ((lawlist-regexp-match-p system-nofile-regexp (buffer-name buffer)) (if (frame-exists "SYSTEM") (switch-to-frame "SYSTEM") ;; If unnamed frame exists, then take control of it. (catch 'break (dolist (frame (frame-list)) (if (not (string-match lawlist-regexp-frame-names (frame-parameter frame 'name))) (throw 'break (progn (switch-to-frame (frame-parameter frame 'name)) (set-frame-name "SYSTEM")))))) ;; If dolist found no unnamed frame, then create / name it. (if (not (frame-exists "SYSTEM")) (progn (make-frame) (set-frame-name "SYSTEM"))) )) ((and (not (lawlist-regexp-match-p org-nofile-regexp (buffer-name buffer))) (not (lawlist-regexp-match-p main-nofile-regexp (buffer-name buffer))) (not (lawlist-regexp-match-p system-nofile-regexp (buffer-name buffer))) ) (if (frame-exists "MISCELLANEOUS") (switch-to-frame "MISCELLANEOUS") ;; If unnamed frame exists, then take control of it. (catch 'break (dolist (frame (frame-list)) (if (not (string-match lawlist-regexp-frame-names (frame-parameter frame 'name))) (throw 'break (progn (switch-to-frame (frame-parameter frame 'name)) (set-frame-name "MISCELLANEOUS")))))) ;; If dolist found no unnamed frame, then create / name it. (if (not (frame-exists "MISCELLANEOUS")) (progn (make-frame) (set-frame-name "MISCELLANEOUS"))))) (t (display-buffer-same-window))) ) ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; GENERIC REGEXP FUNCTION ;;;;;;;;;;;;;;;;;;;;;;;;;;;;; (defun lawlist-regexp-match-p (regexps string) (catch 'matched (dolist (regexp regexps) (if (string-match regexp string) (throw 'matched t))))) ;;;;;;;;;;;;;;;;;;;;;;;;;;; GENERIC BUFFER / FRAME UTILITIES ;;;;;;;;;;;;;;;;;;;;;;;; (defun frame-exists (frame-name) (not (eq nil (get-frame frame-name)))) (defun get-frame-name (&optional frame) "Return the string that names FRAME (a frame). Default is selected frame." (unless frame (setq frame (selected-frame))) (if (framep frame) (cdr (assq 'name (frame-parameters frame))) (error "Function `get-frame-name': Argument not a frame: `%s'" frame))) (defun get-frame (frame) "Return a frame, if any, named FRAME (a frame or a string). If none, return nil. If FRAME is a frame, it is returned." (cond ((framep frame) frame) ((stringp frame) (catch 'get-a-frame-found (dolist (fr (frame-list)) (when (string= frame (get-frame-name fr)) (throw 'get-a-frame-found fr))) nil)) (t (error "Function `get-frame-name': Arg neither a string nor a frame: `%s'" frame)))) (defun switch-to-frame (frame-name) (let ((frames (frame-list))) (catch 'break (while frames (let ((frame (car frames))) (if (equal (frame-parameter frame 'name) frame-name) (throw 'break (select-frame-set-input-focus frame)) (setq frames (cdr frames)))))))) ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; At Tue, 27 Aug 2013 08:47:19 +0200, martin rudalics wrote: > > > Using your suggestion of find-file-noselect works well with the initial example, and then just adding (switch-to-buffer (get-file-buffer buffer-filename)) to the tail end of the lawlist-display-buffer-function. > > If you want to show a file-visiting buffer in the selected window, yes. > I'd rather add a rule that calls `display-buffer-same-window' and rewrite > the code > > (when (lawlist-regexps-match-p ...) > ...) > (when (lawlist-regexps-match-p ...) > ...) > > as > > (cond > ((lawlist-regexps-match-p ...) > ...) > ((lawlist-regexps-match-p ...) > ...) > (t > (display-buffer-same-window ...))) > > BTW you should also make code like > > (if (and > (not (equal "MAIN" (frame-parameter frame 'name))) > (not (equal "SYSTEM" (frame-parameter frame 'name))) > (not (equal "ORG" (frame-parameter frame 'name))) > (not (equal "WANDERLUST" (frame-parameter frame 'name))) > (not (equal "MISCELLANEOUS" (frame-parameter frame 'name))) ) > > more readable by defining a variable like > > (defvar my-regexp "^\\(?:MAIN\\|SYSTEM\\|ORG\\|WANDERLUST\\| MISCELLANEOUS\\)$" > "My doc-string.") > > and using > (not (string-match my-regexp (frame-parameter frame 'name))) > > instead. > > martin