all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: John Wiegley <johnw@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 29450@debbugs.gnu.org
Subject: bug#29450: 26.0.90; No check for nil in some filenotify functions
Date: Sun, 04 Feb 2018 22:48:39 -0800	[thread overview]
Message-ID: <m28tc8lyns.fsf@newartisans.com> (raw)
In-Reply-To: <87fu7chi6w.fsf@gmx.de> (Michael Albinus's message of "Thu, 11 Jan 2018 10:13:11 +0100")

>>>>> "MA" == Michael Albinus <michael.albinus@gmx.de> writes:

MA> I have the feeling that it isn't the return value of
MA> `find-file-name-handler' being nil, but rather the
MA> `file-notify--watch-directory' call.

I've had file-notify back on for a few days now, and this has not happened
again, so I'm fine with closing this issue.

However -- and this is a separate bug -- I had to disable it again because it
was stalling out Emacs regularly. I'd ran an operation that changed the state
of the disk, and then Emacs would be locked up for minutes at a time until I
hit C-g repeatedly. Finally, I ran Instruments to see what was going on, and
it was stuck in a busy loop reading directories, spending 92% of its time
calling delq over and over again.

But that's a separate issue, and disabling file-notify cured the performance
problem.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2





  reply	other threads:[~2018-02-05  6:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-26  6:18 bug#29450: 26.0.90; No check for nil in some filenotify functions John Wiegley
2017-11-26 15:39 ` Eli Zaretskii
2018-01-10  0:28   ` Glenn Morris
2018-01-10 23:56     ` John Wiegley
2018-01-11  9:13       ` Michael Albinus
2018-02-05  6:48         ` John Wiegley [this message]
2018-02-05  7:45           ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m28tc8lyns.fsf@newartisans.com \
    --to=johnw@gnu.org \
    --cc=29450@debbugs.gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.