all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 35507@debbugs.gnu.org, Andy Moreton <andrewjmoreton@gmail.com>
Subject: bug#35507: Gnus mojibakifies UTF-8 text/x-patch attachments from	Thunderbird
Date: Thu, 02 May 2019 18:29:52 +0200	[thread overview]
Message-ID: <m28svo4y67.fsf@gmail.com> (raw)
In-Reply-To: <83ftpwq270.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 02 May 2019 18:57:23 +0300")

>>>>> On Thu, 02 May 2019 18:57:23 +0300, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Andy Moreton <andrewjmoreton@gmail.com> Date: Thu, 02 May
    >> 2019 16:43:31 +0100
    >> 
    >> > So yes, I think Noam is right, and 'undecided' is a better
    >> alternative here.
    >> 
    >> That is arguing for the existing code, which does not work
    >> correctly.

    Eli> No, the existing code simply uses the undecoded string.

    Eli> What I argue for is to do this:

    >diff --git a/lisp/gnus/mm-view.el b/lisp/gnus/mm-view.el
    >index 1e1d264b99..173ebfab48 100644
    >--- a/lisp/gnus/mm-view.el
    >+++ b/lisp/gnus/mm-view.el
    >@@ -475,7 +475,7 @@ mm-display-inline-fontify
    > 		    (charset
    > 		     (mm-decode-string text charset))
    > 		    (t
    >- text)))
    >+ (mm-decode-string text 'undecided))))
    >       (let ((font-lock-verbose nil) ; font-lock is a bit too verbose.
    > 	    (enable-local-variables nil))
    >         ;; We used to set font-lock-mode-hook to nil to avoid enabling

That fixes things for me, thanks (I tested against Paul's original
message).

I donʼt see any need for it to be configurable, but thatʼs up to you.

Robert





  parent reply	other threads:[~2019-05-02 16:29 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-30 19:20 bug#35507: Gnus mojibakifies UTF-8 text/x-patch attachments from Thunderbird Paul Eggert
2019-05-01  0:35 ` Andy Moreton
2019-05-01 15:22   ` Robert Pluim
2019-05-01 15:45     ` Andy Moreton
2019-05-01 16:42       ` Andy Moreton
2019-05-01 17:36         ` Eli Zaretskii
2019-05-01 23:54           ` Andy Moreton
2019-05-02  3:07           ` Noam Postavsky
2019-05-02  7:17             ` Andy Moreton
2019-05-02 11:04               ` Eli Zaretskii
2019-05-02 15:43                 ` Andy Moreton
2019-05-02 15:57                   ` Eli Zaretskii
2019-05-02 16:08                     ` Andy Moreton
2019-05-02 16:50                       ` Eli Zaretskii
2019-05-02 17:13                       ` Eric Abrahamsen
2019-05-02 17:45                         ` Andy Moreton
2019-05-02 16:10                     ` Basil L. Contovounesios
2019-05-02 16:50                       ` Eli Zaretskii
2019-05-02 17:20                         ` Eli Zaretskii
2019-05-03 13:55                           ` Basil L. Contovounesios
2019-05-02 16:29                     ` Robert Pluim [this message]
2019-05-02 16:53                       ` Eli Zaretskii
2019-05-02 12:01               ` Noam Postavsky
2019-05-02 15:40                 ` Eli Zaretskii
2019-05-03 14:02                   ` Basil L. Contovounesios
2019-05-03 15:14                     ` Eli Zaretskii
2019-05-03 15:20                       ` Basil L. Contovounesios
2019-05-01 17:34     ` Eli Zaretskii
2019-05-02  6:35       ` Robert Pluim
2019-05-01 17:33   ` Eli Zaretskii
2019-05-01 17:32 ` Eli Zaretskii
2019-05-01 18:26   ` Paul Eggert
2019-05-01 19:05     ` Eli Zaretskii
2019-05-01 19:47       ` Andreas Schwab
2019-05-01 19:57         ` Eli Zaretskii
2019-05-02 23:24 ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m28svo4y67.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=35507@debbugs.gnu.org \
    --cc=andrewjmoreton@gmail.com \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.