From: Robert Pluim <rpluim@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 43003@debbugs.gnu.org, Stephen Berman <stephen.berman@gmx.net>
Subject: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive
Date: Tue, 01 Sep 2020 17:40:19 +0200 [thread overview]
Message-ID: <m28sdtec9o.fsf@gmail.com> (raw)
In-Reply-To: <875z8xcz91.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 01 Sep 2020 17:06:50 +0200")
>>>>> On Tue, 01 Sep 2020 17:06:50 +0200, Lars Ingebrigtsen <larsi@gnus.org> said:
Lars> Robert Pluim <rpluim@gmail.com> writes:
>> >> - (string-match comint-password-prompt-regexp string))
>> >> + (string-match comint-password-prompt-regexp
>> >> + (replace-regexp-in-string "\r" "" string)))
>>
Lars> Yes, that makes sense to me.
>>
>> Done in 2e3ec40293
Lars> One thought -- just as a precaution, would it make sense to do this
Lars> replacement only if the \r is at the start of a line, and it's not
Lars> followed by a \n? I'm just slightly worried that there may be
Lars> repercussions on systems that use \r\n as end-of-line markers... it
Lars> probably makes no difference here, but...
Iʼm finding it hard to come up with a case where stripping the \r
fails (famous last words).
Robert
next prev parent reply other threads:[~2020-09-01 15:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 21:26 bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive Stephen Berman
2020-08-24 12:27 ` Lars Ingebrigtsen
2020-08-26 10:10 ` Stephen Berman
2020-08-27 13:02 ` Lars Ingebrigtsen
2020-08-27 15:09 ` Stephen Berman
2020-08-28 14:08 ` Lars Ingebrigtsen
2020-08-28 14:53 ` Stephen Berman
2020-08-30 13:41 ` Lars Ingebrigtsen
2020-08-31 9:26 ` Stephen Berman
2020-08-31 10:11 ` Robert Pluim
2020-08-31 12:05 ` Stephen Berman
2020-09-01 14:28 ` Lars Ingebrigtsen
2020-09-01 15:03 ` Robert Pluim
2020-09-01 15:06 ` Lars Ingebrigtsen
2020-09-01 15:40 ` Robert Pluim [this message]
2020-09-01 16:46 ` Lars Ingebrigtsen
2020-09-01 17:44 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m28sdtec9o.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=43003@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.