From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#75275: 30.0.92; `make-thread` bug on macOS 15.2 Date: Thu, 02 Jan 2025 18:46:25 +0100 Message-ID: References: <86frm1jgpq.fsf@gnu.org> <86bjwpjfle.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38534"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 75275@debbugs.gnu.org, Eli Zaretskii , stefankangas@gmail.com To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 02 18:47:21 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTPI0-0009u1-E8 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Jan 2025 18:47:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTPHk-0001So-GJ; Thu, 02 Jan 2025 12:47:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTPHi-0001Re-Fp for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 12:47:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tTPHi-0001mf-7o for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 12:47:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=t4pgCdhdx1mmdkcCgJA6uMlsHq1Z1e38+wIVxZXsIbk=; b=g0pgc/HmxoDghZM+0+Jpd2cYV+aK9zCsw/FRppZODMMs+PUBPqqWhL0VV5/pvBYF1sTXjQe6Sr1tjPhGRMzjuefOoeizeasiGbKgBqm8xhnMyUV3Cn6tWo2b07lqToPqoHB9hkkLJFGgW387deI9z5n/SCdof7K5ay13CUFefN8VKbUiK4v2zSLEvcTPTKDoaP7Pgc5PivQKf+fiDrtNgVrIUeUiL3nW8MQoIo8xtMQzTavRslJdqhHZMgnYv6kEmN2M2+V8ZqL+ooEvT1ACn3NXAxy0uH907ILFTKmR39qjTdfQWFr6/1hdriegr5M4jVwaWgKB+6m/r6tEC138cg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tTPHh-0005jc-QX for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 12:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Jan 2025 17:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75275 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 75275-submit@debbugs.gnu.org id=B75275.173583999522002 (code B ref 75275); Thu, 02 Jan 2025 17:47:01 +0000 Original-Received: (at 75275) by debbugs.gnu.org; 2 Jan 2025 17:46:35 +0000 Original-Received: from localhost ([127.0.0.1]:46499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTPHH-0005io-5V for submit@debbugs.gnu.org; Thu, 02 Jan 2025 12:46:35 -0500 Original-Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:45123) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tTPHE-0005iN-PW for 75275@debbugs.gnu.org; Thu, 02 Jan 2025 12:46:34 -0500 Original-Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-385e1fcb0e1so6366803f8f.2 for <75275@debbugs.gnu.org>; Thu, 02 Jan 2025 09:46:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735839986; x=1736444786; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t4pgCdhdx1mmdkcCgJA6uMlsHq1Z1e38+wIVxZXsIbk=; b=VkJlSeNiMbUN8erE/DzEnKjsctq69dA0YiHmlz27wIHy3LLzaGxspqdJwuZfP3BRdp lO28E9TxC/5oEKI6g8qvuktnzoWzZWg/yy+JsE29Cya/fQ6dNeQLuo2WlSHxvrdTJekZ J8WRvP6l6vRwsFHhXLvJLE+XWlEkMIkJfqD6Y4V5mYEcoxixXz2auq5eCtHz6fX5F60V +rVcXNWJmRGr5TTPqjU4ym2eOd30yccHVguJMwziCH79/8xhzLjaRMhsQC6D1c6HqXq+ PS9xpLXvkxn3yvXbosFyDV66lZd3M49DuTghlMpwOMZX4bLyrdtM8iEVuEKjQvgm1B/5 GzaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735839986; x=1736444786; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=t4pgCdhdx1mmdkcCgJA6uMlsHq1Z1e38+wIVxZXsIbk=; b=DQgEWhb1VIVmUQGJ3q9dsO6TeNwYVt/UcFTnlNRxRR6RhsznLPKBmsy2Qconp0ATpK dbpnMvpUxoqzIUThGi9fbiigIfnod3e2mhT3gFxdjYtEbMpUsYGx35laqkeZ9SSsv5ZN nOxl7C3880uepkKi+BWZyBpFuijBgpcH/EI+UuK6FOQZNeqzL6LS7fjLNEENbdbL6PcA Y8Xo8+n7I2JN0usZl0hXG8NG33YpTCMJvlA3S8IN9r5m/a8kjc69ohycZWDKMqwugmKq qyoqaESHtG+dFU7m3CM8zOEsProHkvkovOxji8IVkccMWEQ/uuG9EpotochWz0Kx5JPK TbUA== X-Forwarded-Encrypted: i=1; AJvYcCVYF+eEbf/YEuSaCPT3180egcbFFWgwq9VG6tcVOOTaFp2BkBGgRYU2zbipWh9kT3HqXMaJng==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyE+ugacytR6inPo/h+SNVGM00/qUo+dIVXsdusDNCgvLiP/xtG lEY8/xnLMbvK+6a1sHIO5bfc5JZC7b9LGaapHnz+dFaBrBaD25B9lCS4vQ== X-Gm-Gg: ASbGncv3h13fv0ZXCL14HNnM2IeB68T6ZswgEsdXxWWYJn9nEuRCr74pUceK/ue2c47 b6pVx4zn/+nYhcor0D7cC684XqSjPLE0c3eMIngXmpLMRANLpj2ifbrE/2lGJsc9LTQ9NlTamdy c0hfSBE9Xazz/3JMNTbGs4fNOekPeKCWp8jBuHziMy2RdTgOdoNI2x7lmAqfXXmN4Ka8z8F8GUw 5paCj21JmvrehjsqcHtsK0BB9jCAOfH8k8QgkWZH2YinPUHTFyQvLZYoW4ahwjviBmqXipgXbQa tEofnRwEHIR9NvzULIAhDciQkFI8YtTg6cl26dcx01mEv+hPqkK45QrsIbsjbInT X-Google-Smtp-Source: AGHT+IEqF0kkwJbkUt2oshvf76GwJH9JqWWWC8QGmlSEG8YnFg0pptQXyVNyizbJ5YyC2/FIe3vSSQ== X-Received: by 2002:a5d:584b:0:b0:386:373f:47c4 with SMTP id ffacd0b85a97d-38a224053d8mr40698456f8f.49.1735839986134; Thu, 02 Jan 2025 09:46:26 -0800 (PST) Original-Received: from pro2 (p200300e0b7290d009d701914d6a76d9d.dip0.t-ipconnect.de. [2003:e0:b729:d00:9d70:1914:d6a7:6d9d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8a636asm39650305f8f.88.2025.01.02.09.46.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2025 09:46:25 -0800 (PST) In-Reply-To: (Alan Third's message of "Thu, 2 Jan 2025 17:37:36 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298209 Archived-At: Alan Third writes: > On Thu, Jan 02, 2025 at 07:22:21PM +0200, Eli Zaretskii wrote: >> > From: Gerd M=C3=B6llmann >> > Cc: Alan Third , stefankangas@gmail.com, >> > 75275@debbugs.gnu.org >> > Date: Thu, 02 Jan 2025 18:09:46 +0100 >> >=20 >> > Eli Zaretskii writes: >> >=20 >> > >> Date: Thu, 2 Jan 2025 16:06:25 +0000 >> > >> From: Alan Third >> > >> Cc: Gerd M=C3=B6llmann , >> > >> 75275@debbugs.gnu.org, Eli Zaretskii >> > >>=20 >> > >> On Thu, Jan 02, 2025 at 09:19:36AM -0600, Stefan Kangas wrote: >> > >> > That patch fixes it for me, indeed. Thanks! >> > >>=20 >> > >> Hi Stefan, any chance you could check this version? >> > >>=20 >> > >> I have a suspicion that Gerd's will break C-g again. >> > > >> > > Did C-g work before Gerd's commit back in March? If not, this is not >> > > a regression. If it did work, can you explain how the change Gerd >> > > proposed now will break C-g? >> >=20 >> > It's different. I made the change because Emacs freezed and C-g did >> > nothing. With my change, Emacs freezed and I could get out with C-g, at >> > least sometimes. >>=20 >> Your change included 2 hunks, and the suggestion is to revert only >> one of them. My question is whether this is likely to reintroduce >> some regression. > > Perhaps I'm wrong. Gerd, can you remember, did your change for C-g > require ns_select to run the NS runloop, or did it just require the > clearing out of the input queue? I'm just concerned because this > change will reintroduce situations where it won't run the runloop. > > The more I think about it the more I think I'm wrong... AFAIR my theory went like: - [NSApp run] + key event handler put C-g in the hold queue - ns_select_1 calls "run" (it did before my change). - I couldn't find how input events from the hold queue come to Emacs in the whole process, so I added that - The "call run in all threads" was then a mistake Seemed to work, to a degree.