From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Wolfgang Jenkner Newsgroups: gmane.emacs.devel Subject: Re: conf-space-mode Date: Tue, 12 Sep 2006 07:32:42 +0200 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1158116878 25144 80.91.229.2 (13 Sep 2006 03:07:58 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 13 Sep 2006 03:07:58 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 13 05:07:56 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GNL6K-0002xp-TD for ged-emacs-devel@m.gmane.org; Wed, 13 Sep 2006 05:07:49 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GNL6K-0006IM-Fm for ged-emacs-devel@m.gmane.org; Tue, 12 Sep 2006 23:07:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GN0xm-0002B0-TW for emacs-devel@gnu.org; Tue, 12 Sep 2006 01:37:38 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GN0xk-00028u-0E for emacs-devel@gnu.org; Tue, 12 Sep 2006 01:37:37 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GN0xj-00028k-Lt for emacs-devel@gnu.org; Tue, 12 Sep 2006 01:37:35 -0400 Original-Received: from [62.99.145.2] (helo=mx.inode.at) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1GN0z9-0007LX-Su for emacs-devel@gnu.org; Tue, 12 Sep 2006 01:39:04 -0400 Original-Received: from [62.99.161.223] (port=7485 helo=gaston.none) by smartmx-02.inode.at with esmtp (Exim 4.50) id 1GN0xg-0006FU-Fa for emacs-devel@gnu.org; Tue, 12 Sep 2006 07:37:33 +0200 Original-To: emacs-devel@gnu.org User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-Mailman-Approved-At: Tue, 12 Sep 2006 23:07:38 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:59750 Archived-At: Richard Stallman writes: > The way you state this suggests that perhaps you forgot that I > actually sent a patch? > > I saw your patch but decided to fix the problem a different way. Not very different, though. > You didn't address the problematic use of `current-prefix-arg'. > > Yes I did, in the second change. I'm afraid we are not talking of the same problem here. I think what you call the `second change' is making C-u C-c SPC work. I meant the part where I remarked that, e.g., `find-file-at-point' uses `current-prefix-arg'. A call to `conf-space-mode' while 'find-file-at-point' is being executed may still see the same prefix argument which was passed to `find-file-at-point'. I gave a rather surprising example of this situation, where the user might not be aware of some config file being inserted in a buffer. That example is slightly bogus however since it actually works correctly with 'ffap-bindings'. Here is something that should ahem... not work: (ffap-bindings) (setq ffap-require-prefix t) Place point after the colon of ftp.foo.bar: and do C-u C-x C-f My patch makes `conf-space-mode' heed the prefix argument only if it is the actual command being executed. I think this is enough since you can always visit a config file and then do C-u C-c SPC to adjust `conf-space-keywords'. But then again, I never use this feature. > The first one fixes the other problem you mentioned, that of asking > for confirmation twice. You used the words "by design" and I took > that to mean you thought this was a feature, so I assumed you had > not tried to change this. You assumed? > But I considered it a bug. So the first thing I did was fix this. The imenu stuff is slightly broken now (given my test file x, try C-x C-f x y and observe that `imenu-generic-expression' has two "Parameters" entries).