From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#11082: 24.0.94; u.glyphless member in struct glyph does not fit in 32 bits Date: Sat, 24 Mar 2012 09:54:09 +0100 Message-ID: References: <83zkb6trdb.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1332579318 4787 80.91.229.3 (24 Mar 2012 08:55:18 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 24 Mar 2012 08:55:18 +0000 (UTC) Cc: 11082@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 24 09:55:16 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SBMki-0001eS-Uj for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Mar 2012 09:55:13 +0100 Original-Received: from localhost ([::1]:54845 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBMki-0001Qm-6C for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Mar 2012 04:55:12 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBMke-0001Oi-Nh for bug-gnu-emacs@gnu.org; Sat, 24 Mar 2012 04:55:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SBMkc-0002P0-W1 for bug-gnu-emacs@gnu.org; Sat, 24 Mar 2012 04:55:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBMkc-0002NO-Sn for bug-gnu-emacs@gnu.org; Sat, 24 Mar 2012 04:55:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SBNEY-0007x1-9k for bug-gnu-emacs@gnu.org; Sat, 24 Mar 2012 05:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Mar 2012 09:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11082 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11082-submit@debbugs.gnu.org id=B11082.133258113530527 (code B ref 11082); Sat, 24 Mar 2012 09:26:02 +0000 Original-Received: (at 11082) by debbugs.gnu.org; 24 Mar 2012 09:25:35 +0000 Original-Received: from localhost ([127.0.0.1]:36231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SBNE6-0007wE-9T for submit@debbugs.gnu.org; Sat, 24 Mar 2012 05:25:35 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.9]:40959) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SBNDh-0007vk-3B for 11082@debbugs.gnu.org; Sat, 24 Mar 2012 05:25:28 -0400 Original-Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3VFFm21gMVz4Kh1w; Sat, 24 Mar 2012 09:54:10 +0100 (CET) Original-Received: from linux.local (ppp-88-217-102-246.dynamic.mnet-online.de [88.217.102.246]) by mail.mnet-online.de (Postfix) with ESMTPA id 3VFFm214dGz4KK2w; Sat, 24 Mar 2012 09:54:10 +0100 (CET) Original-Received: by linux.local (Postfix, from userid 501) id 792E91E5309; Sat, 24 Mar 2012 09:54:09 +0100 (CET) X-Yow: --``I love KATRINKA because she drives a PONTIAC. We're going away now. I fed the cat. - Zippy'' In-Reply-To: <83zkb6trdb.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 24 Mar 2012 09:01:04 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:58071 Archived-At: Eli Zaretskii writes: >> The member `u.glyphless' above requires at least 33 bits and does not >> fit in the size (32 bits) of `u.val' on many environments. As a >> result, equality with respect to the `u.val' member (e.g., used in >> GLYPH_EQUAL_P) does not necessarily mean the equality of glyphless >> glyphs. This is broken since GLYPHLESS_GLYPH was added. > ?? Isn't the size of a union defined by its widest member? The size of u.val is defined by the size of unsigned. > If so, we just end up wasting some storage here, but we should never > truncate a bit field. It's not about truncation, but about ignored bits in GLYPH_EQUAL_P. > I would actually suggest to use 22-bit for this field, to avoid > confusion in the future. Making the struct exactly 32 bits may be better since it can make access to the ch member simpler. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."