From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: John Wiegley Newsgroups: gmane.emacs.devel Subject: Re: Suspicious code in align.el Date: Sat, 02 Jan 2016 14:18:22 -0800 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1451773129 18073 80.91.229.3 (2 Jan 2016 22:18:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 2 Jan 2016 22:18:49 +0000 (UTC) Cc: emacs-devel To: Artur Malabarba Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 02 23:18:42 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aFUVT-0002RS-1g for ged-emacs-devel@m.gmane.org; Sat, 02 Jan 2016 23:18:39 +0100 Original-Received: from localhost ([::1]:39899 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aFUVP-0002eN-79 for ged-emacs-devel@m.gmane.org; Sat, 02 Jan 2016 17:18:35 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aFUVL-0002e3-Pb for emacs-devel@gnu.org; Sat, 02 Jan 2016 17:18:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aFUVH-0005bZ-Mi for emacs-devel@gnu.org; Sat, 02 Jan 2016 17:18:31 -0500 Original-Received: from mail-pa0-x22f.google.com ([2607:f8b0:400e:c03::22f]:33845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aFUVH-0005bC-HB for emacs-devel@gnu.org; Sat, 02 Jan 2016 17:18:27 -0500 Original-Received: by mail-pa0-x22f.google.com with SMTP id uo6so157000679pac.1 for ; Sat, 02 Jan 2016 14:18:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mail-followup-to:mime-version:content-type; bh=5StaawTixsvv32vtds2/uPzn+tygpThBos7sFQAIKG8=; b=P4enA+dxRUQ5gnRGRLjfbveZzNnXaU7uKobC9fC5eWhVjsobONtXN67uTKkOWguhHG pRJahlido1CroMRoiRSET9nGIAZ3OQA1exziJgYywvpj9rKZ/q0wIx34fOysxmDbQMnZ lHHByB/Q6CCBpikPTnMnMCiGWHGC4arNYBqFnVI/jyDqbONAy6mocdTPTLh4nYXCBXMU PrMk6TBvgTz6eBD8A8WuEhC6gbppEP3OCLoI8jcfNWrhKmUUYimx7OsxW1cmp+bBZ3yG pi2/9XjO0C3N5mG71sgW3iz3kQnlymTt7h8BORsxVHjT5vonq+htFsVcF9oYbHaKeUCu /Qnw== X-Received: by 10.66.252.6 with SMTP id zo6mr49641096pac.154.1451773106898; Sat, 02 Jan 2016 14:18:26 -0800 (PST) Original-Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id 2sm67852653pft.5.2016.01.02.14.18.26 (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 02 Jan 2016 14:18:26 -0800 (PST) X-Google-Original-From: "John Wiegley" Original-Received: by Vulcan.local (Postfix, from userid 501) id 6FBE211FAF604; Sat, 2 Jan 2016 14:18:25 -0800 (PST) In-Reply-To: (Artur Malabarba's message of "Fri, 1 Jan 2016 19:47:34 +0000") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.5 (darwin) Mail-Followup-To: Artur Malabarba , emacs-devel X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c03::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:197386 Archived-At: >>>>> Artur Malabarba writes: > In line 890 of this file, there's a call to align-regexp that looks like > this... Nice catch, Artur, the code at least is wrong. The 3rd argument should be shifted forward to become the 5th argument. I wonder what fixing this will break... :) -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2