From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: John Wiegley Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] fix conv_lisp_to_sockaddr for AF_INET6 addresses Date: Sun, 07 Feb 2016 12:52:02 -0500 Message-ID: References: Reply-To: John Wiegley NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1454867872 13814 80.91.229.3 (7 Feb 2016 17:57:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 7 Feb 2016 17:57:52 +0000 (UTC) Cc: emacs-devel@gnu.org To: David Edmondson Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 07 18:57:45 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aSTai-0003Mw-Fd for ged-emacs-devel@m.gmane.org; Sun, 07 Feb 2016 18:57:44 +0100 Original-Received: from localhost ([::1]:36819 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSTah-0005Ao-Sx for ged-emacs-devel@m.gmane.org; Sun, 07 Feb 2016 12:57:43 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSTad-00059b-Tr for emacs-devel@gnu.org; Sun, 07 Feb 2016 12:57:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSTaa-00042F-ND for emacs-devel@gnu.org; Sun, 07 Feb 2016 12:57:39 -0500 Original-Received: from mail-io0-x22c.google.com ([2607:f8b0:4001:c06::22c]:36783) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSTaa-00042B-IG for emacs-devel@gnu.org; Sun, 07 Feb 2016 12:57:36 -0500 Original-Received: by mail-io0-x22c.google.com with SMTP id g73so175600960ioe.3 for ; Sun, 07 Feb 2016 09:57:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:reply-to:mail-followup-to:mime-version:content-type; bh=do1HwrBXtbI2r8Si0IgJiPplv4V8lizU6H/w2JWoceA=; b=kAflokly7pZd23A1sw6IJfSaFCoJCN+dj1cOED4lVJYgphayF7uKKne+TqMmkgYvYa 5gwqi+1xXzAYqjeM479gHRCdc/TykiQy4ZTIojBthaRT1qQwCWNXwRmXSPOYB0/mOObS Rl5FQFlElL53LqzHfrKZ3kQXYttS1248d7D2ifgWHwtRkaPBqiwMxT9qn7XgsxgELYoT 9hlwTBsJ/AHYG6y8UypvS7EkopzxHFGGWhafDp1/YfXDWVXc9zcOg4Gf2SlbSnnaHw7B xNCN4YRSe2xCgqa1IYUtqvBZN6CwfEyUN0VXlut8QIkIYiXbMaEwtiuBVGX0+YetGSZ5 tubQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:in-reply-to:date:message-id :references:user-agent:reply-to:mail-followup-to:mime-version :content-type; bh=do1HwrBXtbI2r8Si0IgJiPplv4V8lizU6H/w2JWoceA=; b=FISI5Jg82sIoSt2QHqPChvu9bwxOWQXQrAz5yjISCo3wn3mcPOeZnk+A6lApIzckMV RD1xRVnePiXC7eC9EHHBuHwPgRZhb1F6t5lPw8PWoJR0OpXpMcY7+MqixUQllLbZ4fKp NG4hB3jErqv0M/4nODfLKlgjvRnVE11/3dC4s7x7reQlvxjpdwT+ZWF0S2RF2m+gZ5sN /VnOxfbBbRXfvbxM0/u8NpBfaujCbu3wMryadnb5JDu74R83XcaDSvHZE7x6gySpTcIM K52+s/s6SjDhBVzYaZaF+liZPGnHy0wE0VZEgmeS0iXoFK61MHAbDXp5mC3hY8rPDocq PkvQ== X-Gm-Message-State: AG10YOTQAuUXoxt/fp1auZ+pbZ9/nzs0VxBHTUDphzZGU8NM3VsL+n4NVKCy+bfQR47Xfw== X-Received: by 10.107.148.69 with SMTP id w66mr22763058iod.183.1454867855913; Sun, 07 Feb 2016 09:57:35 -0800 (PST) Original-Received: from Hermes.local (mail.johnwiegley.com. [208.82.103.192]) by smtp.gmail.com with ESMTPSA id ee9sm3715571igb.7.2016.02.07.09.57.33 (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 07 Feb 2016 09:57:34 -0800 (PST) X-Google-Original-From: "John Wiegley" Original-Received: by Hermes.local (Postfix, from userid 501) id 7B5EC4DD0FB4; Sun, 7 Feb 2016 12:57:31 -0500 (EST) In-Reply-To: (David Edmondson's message of "Sat, 06 Feb 2016 16:06:17 +0000") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.5 (darwin) Mail-Followup-To: David Edmondson , emacs-devel@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4001:c06::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:199451 Archived-At: >>>>> David Edmondson writes: > When trying to test Lars' async-dns changes I encountered memory corruption > whenever the addresses returned for a host included IPv6 addresses. This > turns out to be a bug in the mainline code which is just more likely to be > tickled by the async-dns changes because they convert addresses to lisp > objects whenever `make-network-process' is called (the current code doesn't > do that). Lars, it's the discovery of bugs like this that lead me to conclude two things: 1. I'd like much more testing of this feature before we consider it for release. 2. We need a suite of tests for this feature, because it makes a rather fundamental change, and I'd like some coverage to ensure that others working in similar areas won't break it in future. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2