From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andrew Hyatt Newsgroups: gmane.emacs.bugs Subject: bug#5440: 23.1; buffer-file-format encoding temp buffers not reentrant Date: Mon, 25 Jul 2016 21:13:14 -0400 Message-ID: References: <87sk9z3vt2.fsf@blah.blah> <838twvysl2.fsf@gnu.org> <83twfft8ny.fsf@gnu.org> <83shuxu142.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1469495667 22438 80.91.229.3 (26 Jul 2016 01:14:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Jul 2016 01:14:27 +0000 (UTC) Cc: 5440@debbugs.gnu.org, user42@zip.com.au To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 26 03:14:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bRqwp-0008M2-20 for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Jul 2016 03:14:15 +0200 Original-Received: from localhost ([::1]:36534 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRqwo-0000qI-EK for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Jul 2016 21:14:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRqwf-0000pB-HV for bug-gnu-emacs@gnu.org; Mon, 25 Jul 2016 21:14:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bRqwc-0008Sk-9D for bug-gnu-emacs@gnu.org; Mon, 25 Jul 2016 21:14:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRqwc-0008SN-55 for bug-gnu-emacs@gnu.org; Mon, 25 Jul 2016 21:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bRqwb-0008Hq-Tk for bug-gnu-emacs@gnu.org; Mon, 25 Jul 2016 21:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrew Hyatt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Jul 2016 01:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 5440-submit@debbugs.gnu.org id=B5440.146949560731801 (code B ref 5440); Tue, 26 Jul 2016 01:14:01 +0000 Original-Received: (at 5440) by debbugs.gnu.org; 26 Jul 2016 01:13:27 +0000 Original-Received: from localhost ([127.0.0.1]:37378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bRqw3-0008Gq-3Y for submit@debbugs.gnu.org; Mon, 25 Jul 2016 21:13:27 -0400 Original-Received: from mail-qt0-f174.google.com ([209.85.216.174]:35384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bRqvz-0008Gc-Nv for 5440@debbugs.gnu.org; Mon, 25 Jul 2016 21:13:25 -0400 Original-Received: by mail-qt0-f174.google.com with SMTP id x25so109245018qtx.2 for <5440@debbugs.gnu.org>; Mon, 25 Jul 2016 18:13:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Tb3I8MGtROj5hbv077g6ZVKFC4zeX4OINd+AQB3Ay6w=; b=Kr1ytFvWSaNxCU0mAmBtgpE9CfNUVcTCKr6CjJNa+nnID4kiOqZRS6dXKFobDwV6d3 thK+ewozM1eE2j9/Khq4KkqfPS6369sDsdFQCZnpg5zV3c4hiQKo/cWCwYo4e2dpbPd/ l0mAME9rdWmkxBv2Pe1NhxnAIgm5CvcUqNp7kETkybmqfKnsdBMXIBFE8Eq0Pg1s5g47 xXF94EimTpMEHsFO7YVmQajohRCv4EwlTkHi9SRCyyCniWIqTH4JvU9smGv+/YiI4G0H CKn+bOo50mfnZLlr5nxuTAiCXyxRDiAqc3y9CHJR34L/tEcQLTysW70S3E57v9W19BQF fGTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Tb3I8MGtROj5hbv077g6ZVKFC4zeX4OINd+AQB3Ay6w=; b=Q+vy+ZvT3NAxxCaCBGyjQ8ddUyOTH0xvKLpKXnfw1otIQrzqhVbHbq5JSrmFW6fMSR uElSwl1rXZAq4TtVT4kPlzdZCsV1v2MMafdVJglzhyAfdaNDYON8cm8dLc/02BSgRiZE YZCIOENrNyXoanlvMPEPdQrw5dQLbfl8SvxC+4W8QULJ0FF7Jbw1nOprzYyApmduWN7B QEEZRe/WQpw5P1vh0oenrCoafrQh30dQCD8GD5XFmJPiKGKHboyEX1m2FbLA09OT4g8W OLtckfGkRriDe25w6svIRmTq1TIMCcCBpt0UQGIUwahXZkMSIsdRQakwl90na35U6eIt LQOA== X-Gm-Message-State: AEkoouvQC+ccBOu2qGAEOjUghl3Fog9zojc1s39Puq99UcVV3JyTVw70fgAyhqpvRbzaoA== X-Received: by 10.200.48.112 with SMTP id g45mr34754494qte.70.1469495598313; Mon, 25 Jul 2016 18:13:18 -0700 (PDT) Original-Received: from Andrews-MacBook-Pro.local.ahyatt-laptop (cpe-74-73-128-199.nyc.res.rr.com. [74.73.128.199]) by smtp.gmail.com with ESMTPSA id 73sm17403062qtc.16.2016.07.25.18.13.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Jul 2016 18:13:16 -0700 (PDT) In-Reply-To: <83shuxu142.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 25 Jul 2016 19:35:41 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (darwin) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121543 Archived-At: Eli Zaretskii writes: >> From: Andrew Hyatt >> Cc: user42@zip.com.au, 5440@debbugs.gnu.org >> Date: Mon, 25 Jul 2016 00:07:50 -0400 >> >> diff --git a/doc/lispref/files.texi b/doc/lispref/files.texi >> index f3650a4..5763380 100644 >> --- a/doc/lispref/files.texi >> +++ b/doc/lispref/files.texi > > Thanks. A couple of comments: > >> @@ -3238,7 +3238,9 @@ Format Conversion Round-Trip >> >> One responsibility of @var{from-fn} is to make sure that the beginning >> of the file no longer matches @var{regexp}. Otherwise it is likely to >> -get called again. >> +get called again. Also, @var{from-fn} must not involve other buffers or >> +files other than the one being decoded > > One of these 2 "others" should be deleted, I think. Done > >> or else formatting may happen >> +during formatting, leading to incorrect results. > > I would say something like > > otherwise the internal buffer used for formatting might be > overwritten. Done > >> +@var{to-fn} must not involve other buffers or files other than the one >> +being encoded, or else formatting may happen during formatting, >> +leading to incorrect results. > > Same here. Done. Thanks for the suggestions. I'll submit this and close out the bug.