From: Andrew Hyatt <ahyatt@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 5440@debbugs.gnu.org, user42@zip.com.au
Subject: bug#5440: 23.1; buffer-file-format encoding temp buffers not reentrant
Date: Mon, 25 Jul 2016 21:13:14 -0400 [thread overview]
Message-ID: <m27fc9fbh1.fsf@Andrews-MacBook-Pro.local> (raw)
In-Reply-To: <83shuxu142.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 25 Jul 2016 19:35:41 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Andrew Hyatt <ahyatt@gmail.com>
>> Cc: user42@zip.com.au, 5440@debbugs.gnu.org
>> Date: Mon, 25 Jul 2016 00:07:50 -0400
>>
>> diff --git a/doc/lispref/files.texi b/doc/lispref/files.texi
>> index f3650a4..5763380 100644
>> --- a/doc/lispref/files.texi
>> +++ b/doc/lispref/files.texi
>
> Thanks. A couple of comments:
>
>> @@ -3238,7 +3238,9 @@ Format Conversion Round-Trip
>>
>> One responsibility of @var{from-fn} is to make sure that the beginning
>> of the file no longer matches @var{regexp}. Otherwise it is likely to
>> -get called again.
>> +get called again. Also, @var{from-fn} must not involve other buffers or
>> +files other than the one being decoded
>
> One of these 2 "others" should be deleted, I think.
Done
>
>> or else formatting may happen
>> +during formatting, leading to incorrect results.
>
> I would say something like
>
> otherwise the internal buffer used for formatting might be
> overwritten.
Done
>
>> +@var{to-fn} must not involve other buffers or files other than the one
>> +being encoded, or else formatting may happen during formatting,
>> +leading to incorrect results.
>
> Same here.
Done.
Thanks for the suggestions. I'll submit this and close out the bug.
prev parent reply other threads:[~2016-07-26 1:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 23:03 bug#5440: 23.1; buffer-file-format encoding temp buffers not reentrant Kevin Ryde
2016-07-21 4:33 ` Andrew Hyatt
2016-07-21 14:27 ` Eli Zaretskii
2016-07-24 5:06 ` Andrew Hyatt
2016-07-24 14:25 ` Eli Zaretskii
2016-07-25 4:07 ` Andrew Hyatt
2016-07-25 16:35 ` Eli Zaretskii
2016-07-26 1:13 ` Andrew Hyatt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m27fc9fbh1.fsf@Andrews-MacBook-Pro.local \
--to=ahyatt@gmail.com \
--cc=5440@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=user42@zip.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.