all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#25784: 25.2; mouse-1 binding in debbugs-gnu.el
@ 2017-02-18 11:20 Charles A. Roelli
  2017-02-18 13:43 ` Andreas Schwab
  0 siblings, 1 reply; 7+ messages in thread
From: Charles A. Roelli @ 2017-02-18 11:20 UTC (permalink / raw)
  To: 25784

`mouse-1' is bound in debbugs-gnu.el, which means that a nil value of
`mouse-1-click-follows-link' is not respected.  The following patch is
needed:

--- debbugs-0.12/debbugs-gnu.el.~2~     2017-02-17 17:54:15.000000000 +0100
+++ debbugs-0.12/debbugs-gnu.el        	2017-02-18 12:07:56.000000000 +0100
@@ -909,7 +909,6 @@
 	(menu-map (make-sparse-keymap)))
     (set-keymap-parent map tabulated-list-mode-map)
     (define-key map "\r" 'debbugs-gnu-select-report)
-    (define-key map [mouse-1] 'debbugs-gnu-select-report)
     (define-key map [mouse-2] 'debbugs-gnu-select-report)
     (define-key map "g" 'debbugs-gnu-rescan)
     (define-key map "R" 'debbugs-gnu-show-all-blocking-reports)
@@ -1587,7 +1586,6 @@
   (let ((map (make-sparse-keymap)))
     (set-keymap-parent map tabulated-list-mode-map)
     (define-key map "\r" 'debbugs-gnu-select-usertag)
-    (define-key map [mouse-1] 'debbugs-gnu-select-usertag)
     (define-key map [mouse-2] 'debbugs-gnu-select-usertag)
     map))

There already was a ChangeLog entry to this effect in the past:

2012-12-23  Lars Ingebrigtsen  <larsi@gnus.org>

	Don't explicitly bind mouse-1.

	As Michael Heerdegen <michael_heerdegen@web.de> says:

	However, also binding mouse-1 is not necessary.	 Depending on the 
	setting of `mouse-1-click-follows-link', which is non-nil by default, 
	mouse-1 already follows links - see its doc.  We should leave it up to 
	the user if he wants to use mouse-1 for following or not.

But the change does not seem to have been made, or maybe it was reverted
at some point.





^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2017-02-20 19:40 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-18 11:20 bug#25784: 25.2; mouse-1 binding in debbugs-gnu.el Charles A. Roelli
2017-02-18 13:43 ` Andreas Schwab
2017-02-19 11:22   ` Charles A. Roelli
2017-02-20  8:16     ` Michael Albinus
2017-02-20  8:55       ` Charles A. Roelli
2017-02-20 12:32         ` Michael Albinus
2017-02-20 19:40           ` Charles A. Roelli

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.