From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.bugs Subject: bug#21778: 24.5; python mode: fill-paragraph with raw docstring ignores python-fill-docstring-style Date: Wed, 16 Aug 2017 17:05:12 +0200 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1502895994 20969 195.159.176.226 (16 Aug 2017 15:06:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 16 Aug 2017 15:06:34 +0000 (UTC) To: John Palmieri , 21778-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 16 17:06:24 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhztj-0004kw-4N for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Aug 2017 17:06:19 +0200 Original-Received: from localhost ([::1]:52671 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhztp-0008F4-Bz for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Aug 2017 11:06:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46009) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhztZ-00087x-Mw for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2017 11:06:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhztS-0000Rp-Hb for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2017 11:06:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60847) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dhztS-0000Ri-Bg for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2017 11:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dhztS-0003Gs-5I for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2017 11:06:02 -0400 Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Aug 2017 15:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 21778 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 21778@debbugs.gnu.org, charles@aurox.ch, jhpalmieri64@gmail.com Original-Received: via spool by 21778-done@debbugs.gnu.org id=D21778.150289593912540 (code D ref 21778); Wed, 16 Aug 2017 15:06:01 +0000 Original-Received: (at 21778-done) by debbugs.gnu.org; 16 Aug 2017 15:05:39 +0000 Original-Received: from localhost ([127.0.0.1]:41293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhzt4-0003GB-Ik for submit@debbugs.gnu.org; Wed, 16 Aug 2017 11:05:38 -0400 Original-Received: from sinyavsky.aurox.ch ([37.35.109.145]:34538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhzt3-0003Fz-8Q for 21778-done@debbugs.gnu.org; Wed, 16 Aug 2017 11:05:37 -0400 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 782E9224F7 for <21778-done@debbugs.gnu.org>; Wed, 16 Aug 2017 14:59:45 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= content-transfer-encoding:content-type:content-type:mime-version :references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1502895583; x=1503759584; bh=TQyp/83cobAVK udUYm0+ELzoaswtITZWeokqPB/wtP4=; b=TN95tYFgwYGSew3kJaqiWuFzRLjbK IFuisNLEzx0zY3l2ic8ahp3aCz3oWZSZufmborzxuVJs6eb51sWGTCIuEh7IYUI6 ed4N804HkBOvDBCkGiaCoHPybBlo1pqz9kMslFP+UClstQeT5Y2DYeIoi2qj3JKt THzZlkX2ywKfpQ= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id LnJgxOOKbvHZ for <21778-done@debbugs.gnu.org>; Wed, 16 Aug 2017 14:59:43 +0000 (UTC) Original-Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id EE601224D7; Wed, 16 Aug 2017 14:59:41 +0000 (UTC) In-reply-to: (message from John Palmieri on Wed, 16 Aug 2017 07:56:46 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135816 Archived-At: Thanks, closing the bug. > From: John Palmieri > Date: Wed, 16 Aug 2017 07:56:46 -0700 > > > Yes, thank you very much, it looks like the bug has been fixed in Emacs 25. > > On Wed, Aug 16, 2017 at 2:09 AM, Charles A. Roelli wrote: > > Looks like this was fixed with the following commit: > > commit deea36f0ece7b1b14afe2a833b6a0f66d59f4459 > Author: Fabián Ezequiel Gallina > Date: Sun Apr 5 23:58:13 2015 -0300 > > python.el: Enhance docstring detection following PEP-257. > > * lisp/progmodes/python.el (python-docstring-at-p): Remove function. > (python-info-assignment-statement-p): New function. > (python-info-assignment-continuation-line-p): Use it. > (python-info-docstring-p): New function. > (python-font-lock-syntactic-face-function) > (python-fill-string): Use it. > > * test/automated/python-tests.el (python-info-assignment-statement-p-1) > (python-info-assignment-statement-p-2) > (python-info-assignment-statement-p-3, python-info-docstring-p-1) > (python-info-docstring-p-2, python-info-docstring-p-3) > (python-info-docstring-p-4, python-info-docstring-p-5) > (python-info-docstring-p-6): New tests. > > which is present in Emacs 25. Does the fix work for you? > > > Resent-From: John Palmieri > > Original-Sender: "Debbugs-submit" > > Resent-CC: bug-gnu-emacs@gnu.org > > Resent-Sender: help-debbugs@gnu.org > > X-Spam-Status: No, score=0.3 required=5.0 tests=BAYES_40, > > FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,HTML_MESSAGE,T_DKIM_INVALID > > autolearn=disabled version=3.3.2 > > Date: Wed, 28 Oct 2015 12:16:20 -0700 > > From: John Palmieri > > Content-Type: multipart/alternative; boundary=001a113fe84e88f40805232f076f > > > > > > To recreate the bug, in Python mode, type > > > > def f(): > > r""" > > This is the docstring for my function. > > > > It's a raw docstring because I want to type \t here, and maybe \n, > > for example in LaTeX code like \tau or \nu. > > > > More docstring here. > > """ > > pass > > > > Now with the cursor in the first sentence of the docstring, running > > fill-paragraph ignores the setting of python-fill-docstring-style, I think > > because Emacs doesn't detect that r""" is the start of the docstring. > > Similarly, running fill-paragraph in the last sentence behaves badly. Also > > similarly, I think that it should be valid to begin a docstring with b""" > > or u""" (and possibly some combination of b, r, u, before """, although I'm > > not sure), and these also don't behave correctly. > > > > > > > > In GNU Emacs 24.5.1 (x86_64-apple-darwin13.4.0, NS apple-appkit-1265.21) > > of 2015-04-10 on builder10-9.porkrind.org > > Windowing system distributor `Apple', version 10.3.1348 > > Configured using: > > `configure --with-ns '--enable-locallisppath=/Library/Application > > Support/Emacs/${version}/site-lisp:/Library/Application > > Support/Emacs/site-lisp'' > > > > Important settings: > > value of $LANG: C > > locale-coding-system: utf-8-unix > > > > Major mode: Outline > > > > Minor modes in effect: > > goto-address-mode: t > > TeX-PDF-mode: t > > tooltip-mode: t > > electric-indent-mode: t > > mouse-wheel-mode: t > > tool-bar-mode: t > > menu-bar-mode: t > > file-name-shadow-mode: t > > global-font-lock-mode: t > > font-lock-mode: t > > auto-composition-mode: t > > auto-encryption-mode: t > > auto-compression-mode: t > > buffer-read-only: t > > line-number-mode: t > > auto-fill-function: do-auto-fill > > transient-mark-mode: t > > view-mode: t > > -- > John H. Palmieri >