From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build Date: Tue, 18 Dec 2018 09:23:05 +0100 Message-ID: References: <20181214085417.15440.18845@vcs0.savannah.gnu.org> <20181214085418.6616820538@vcs0.savannah.gnu.org> <831s6kgrtj.fsf@gnu.org> <83pnu4f45d.fsf@gnu.org> <225c3958-7adf-ce9a-f7f5-c4531b8b6058@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1545121280 18471 195.159.176.226 (18 Dec 2018 08:21:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Dec 2018 08:21:20 +0000 (UTC) Cc: Eli Zaretskii , ari.roponen@gmail.com, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 18 09:21:15 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZAcs-0004fi-Gk for ged-emacs-devel@m.gmane.org; Tue, 18 Dec 2018 09:21:14 +0100 Original-Received: from localhost ([::1]:52487 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZAez-00065g-6J for ged-emacs-devel@m.gmane.org; Tue, 18 Dec 2018 03:23:25 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZAeq-00064C-SB for emacs-devel@gnu.org; Tue, 18 Dec 2018 03:23:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZAen-0007Mq-EM for emacs-devel@gnu.org; Tue, 18 Dec 2018 03:23:16 -0500 Original-Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:41636) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZAem-0007LS-VN; Tue, 18 Dec 2018 03:23:13 -0500 Original-Received: by mail-wr1-x435.google.com with SMTP id x10so14899295wrs.8; Tue, 18 Dec 2018 00:23:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=UryvTd/1ZhoDQYBaB/Wzd2f2QkJF/WLuPY97+YqvEVk=; b=RHYc1WBOHtOo8XdAPAKmVCSz+IYFyWvkCkirFVgKxxh5PZ8f+66sL/c4la5D+mskqo PhBhDi9xY0aBzOIkzV4isNCyb/ZJJL8YMjMvjPamIHuIyKuInTeSYaSkzFbtTcMfesBk AnPWEFLgxzRsXwHzi5JiXNObKPtoFBIfxnJfFP9Sh7T20XvZS/IfIph+DbW0VSum1bXj 1m1h0Ys1zc9vlsj+9kICxOlYzbIr5d+F1ez5PHcHZxt8ndFtElzOLGhPqfEtYXLg1f6n RksKitMeqmx1XveSuhrjfMETlZFxaHZKnVKw/zVlntu9Ke71MdDwho53ZkvY54iyTfgx L8JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :mime-version; bh=UryvTd/1ZhoDQYBaB/Wzd2f2QkJF/WLuPY97+YqvEVk=; b=pKmQbHDzszNyiiVMl3gdhSR9G1+tE2EKGFcVUxjxS1+T6e8+wytLa0Woc6DvKKcLtM SoojWaTOAz18NAH8sqzQ0UtmOkiEQfDUQ6d43jSeA+Kumc8WgR3EcpLbCutVjiqTMt8y 2YjU8ASg1oa5B1eFfaQEkXi293rom0Ftn4gZVcNHUE5eKMQv2xR9w1heX914db7Za1iy XUeDWp+aHFS5zoAxtu6n3+X6BLDo+Zz5TaTCzceXbg9/UJRI5rOABfgAl72eD7/nCLOL XvZypRdfgWlMSZxIbVBqVuo0YWa/Elh7u8/1cXPqry0v+KmibFIqIylZQQ+WlBQrOfHG 5M3A== X-Gm-Message-State: AA+aEWaCZlCa5RT+mByZT93fl1q1DvFlF9WWE7QdhZKeizJrOLb3G+qC yORJ81znYOuR/sSf/63joJqsxa5k X-Google-Smtp-Source: AFSGD/WH5vWrPx8c+6YH5tF0NqRyR2AP8jn/ntDZezuUrWPKfoWPlASrzjdeslTe9G1Ed6h5kFPmNg== X-Received: by 2002:adf:fe11:: with SMTP id n17mr13259612wrr.329.1545121389921; Tue, 18 Dec 2018 00:23:09 -0800 (PST) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id w80sm1469699wme.38.2018.12.18.00.23.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Dec 2018 00:23:06 -0800 (PST) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <225c3958-7adf-ce9a-f7f5-c4531b8b6058@cs.ucla.edu> (Paul Eggert's message of "Mon, 17 Dec 2018 13:49:33 -0800") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::435 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231900 Archived-At: Paul Eggert writes: > Thanks, looks good to me too. One minor point: > > On 12/17/18 4:41 AM, Robert Pluim wrote: >> +#ifdef HAVE_XFT >> +#include >> +#include >> +#endif >> +#ifdef USE_CAIRO >> +#include >> +#endif > > Please indent the include directives by using "# include" (with a > space after "#"). Fixed. Robert