From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#37221: 27.0.50; gnus fails to open connection post-NSM update Date: Wed, 04 Sep 2019 17:25:12 +0200 Message-ID: References: <87k1avgbb8.fsf@gmail.com> <871rwxfd7w.fsf@gmail.com> <87sgpcdx0p.fsf@gmail.com> <87ftlcdvxh.fsf@gnus.org> <87h85sduuw.fsf@gmail.com> <87v9u8cdck.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="265359"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37221@debbugs.gnu.org, Lars Ingebrigtsen To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 04 17:26:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i5XAj-0016sR-HC for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Sep 2019 17:26:13 +0200 Original-Received: from localhost ([::1]:34314 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5XAh-0004XT-U6 for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Sep 2019 11:26:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59727) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5XAb-0004XK-Jv for bug-gnu-emacs@gnu.org; Wed, 04 Sep 2019 11:26:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i5XAa-0001Dm-Ia for bug-gnu-emacs@gnu.org; Wed, 04 Sep 2019 11:26:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53593) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i5XAa-0001De-EU for bug-gnu-emacs@gnu.org; Wed, 04 Sep 2019 11:26:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i5XAX-00059o-Me; Wed, 04 Sep 2019 11:26:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Wed, 04 Sep 2019 15:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37221 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 37221-submit@debbugs.gnu.org id=B37221.156761073119786 (code B ref 37221); Wed, 04 Sep 2019 15:26:01 +0000 Original-Received: (at 37221) by debbugs.gnu.org; 4 Sep 2019 15:25:31 +0000 Original-Received: from localhost ([127.0.0.1]:34180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i5XA2-000594-V0 for submit@debbugs.gnu.org; Wed, 04 Sep 2019 11:25:31 -0400 Original-Received: from mail-wm1-f41.google.com ([209.85.128.41]:38380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i5XA1-00058r-4u for 37221@debbugs.gnu.org; Wed, 04 Sep 2019 11:25:29 -0400 Original-Received: by mail-wm1-f41.google.com with SMTP id o184so4280906wme.3 for <37221@debbugs.gnu.org>; Wed, 04 Sep 2019 08:25:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=+B/JrpDQmnOp2PXM30SnFAw1oVJ/b18usm13zw81rSw=; b=Vy7ZcP+I/7Uzh8ZNdk0yCOUKq3pXMRq0/PkC99CXHv1P/i2pm4pNjmYMIkiAx3cwk8 j3yXpVwN6RTjKUiKOwLrQhGLUjuEFk/XZQG4WItVS78t190h6jpvkQFjv79B6CEh2EHu uFT9o3AAkUw2w8oQZd4cliQme998Wv8eApAK5eqT1J/A0Ll/NngnOxwA59gDW/zm1LJc vmhPDlz9gkJT6A3iP78C70XDwWx3+Y9uka9+QWICSY7Wwe30Wb8iWSOuxEV9St8n1mTV Xc6ktNIthFHJ8purDYKdS7x6ObezlId9dRLdAM7Z1o4oejogWvxgagUqyM36Q4UElF7e diDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=+B/JrpDQmnOp2PXM30SnFAw1oVJ/b18usm13zw81rSw=; b=VqvdzSNeASqchf+ep5+lHcuemKJykZ2+MZL52lHQbcECmQzz1Us4Uyfeq9r3K8OCRs S9Rk0bZHGCT3SLazaWi04n3rzPyizVOVg6CRXgCOV6F9gjZHw51BeSA6LtCKs+rV1jLY 9HowGJXmHefACURAfELKinzMsfhZTHtkWtvGQNKmHZ8LjUm1ms3K9a3L3FEXfTrDKOsE 5WEUL/x3DtmTRCsO33yzzHnJsAOy6SbazCCb10Ao13ow1GxzZYh2qUQ/yxG3mpwPQK58 gZFuEn68oCRP4VWCWrupaTZujqxVrqoYkhg1ZEnomj9m3ztqf/rigur07QeMbbSyiS92 HXow== X-Gm-Message-State: APjAAAUIjaAdk2Y29s8JCy36HwjgMbcgA2wKM8pwowIHroi6fiIwL5eC oOGlByuYpqdAJEHKP8oQ98zpbQtG X-Google-Smtp-Source: APXvYqy3Qf97kY1P2Wvk2Le7yC/3+eOKSP5u/v6GFPoyVzfMqfKYNwxKrHkJ7MveP/KDoPvg91TRfQ== X-Received: by 2002:a05:600c:2056:: with SMTP id p22mr4464636wmg.159.1567610722843; Wed, 04 Sep 2019 08:25:22 -0700 (PDT) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id m62sm5694965wmm.35.2019.09.04.08.25.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2019 08:25:22 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <87v9u8cdck.fsf@gmail.com> (Alex Branham's message of "Wed, 04 Sep 2019 10:04:11 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166207 Archived-At: >>>>> On Wed, 04 Sep 2019 10:04:11 -0500, Alex Branham said: Alex> On Wed 04 Sep 2019 at 16:56, Robert Pluim wrot= e: >> I=CA=BCve spotted one possible problem: nsm-query runs even when the >> connection is unencrypted, which ends up doing (insert nil), which >> aborts the connection. Does the following help? (Lars, why is nsm >> prompting for unencrypted connections?) >>=20 >> diff --git a/lisp/net/nsm.el b/lisp/net/nsm.el >> index 5e8381075b..7243ae8822 100644 >> --- a/lisp/net/nsm.el >> +++ b/lisp/net/nsm.el >> @@ -788,7 +788,8 @@ nsm-check-plain-connection >> (defun nsm-query (host port status what problems message) >> ;; If there is no user to answer queries, then say `no' to everythin= g. >> (if (or noninteractive >> - nsm-noninteractive) >> + nsm-noninteractive >> + (not status)) >> nil >> (let ((response >> (condition-case nil Alex> nsm-query gets skipped now but the process is still killed (same Alex> message, etc). Oh right, because now nsm-save-host doesn=CA=BCt get called. This should work instead of the previous patch (but is not the right solution, I think). You should get prompted by nsm now. diff --git a/lisp/net/nsm.el b/lisp/net/nsm.el index 5e8381075b..8750c19267 100644 --- a/lisp/net/nsm.el +++ b/lisp/net/nsm.el @@ -823,7 +823,7 @@ nsm-query-user ;; First format the certificate and warnings. (with-current-buffer-window buffer nil nil - (insert (nsm-format-certificate status)) + (when status (insert (nsm-format-certificate status))) (insert message) (goto-char (point-min)) ;; Fill the first line of the message, which usually