From: Robert Pluim <rpluim@gmail.com>
To: Alex Branham <alex.branham@gmail.com>
Cc: 37221@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>
Subject: bug#37221: 27.0.50; gnus fails to open connection post-NSM update
Date: Wed, 04 Sep 2019 17:25:12 +0200 [thread overview]
Message-ID: <m27e6oozhj.fsf@gmail.com> (raw)
In-Reply-To: <87v9u8cdck.fsf@gmail.com> (Alex Branham's message of "Wed, 04 Sep 2019 10:04:11 -0500")
>>>>> On Wed, 04 Sep 2019 10:04:11 -0500, Alex Branham <alex.branham@gmail.com> said:
Alex> On Wed 04 Sep 2019 at 16:56, Robert Pluim <rpluim@gmail.com> wrote:
>> Iʼve spotted one possible problem: nsm-query runs even when the
>> connection is unencrypted, which ends up doing (insert nil), which
>> aborts the connection. Does the following help? (Lars, why is nsm
>> prompting for unencrypted connections?)
>>
>> diff --git a/lisp/net/nsm.el b/lisp/net/nsm.el
>> index 5e8381075b..7243ae8822 100644
>> --- a/lisp/net/nsm.el
>> +++ b/lisp/net/nsm.el
>> @@ -788,7 +788,8 @@ nsm-check-plain-connection
>> (defun nsm-query (host port status what problems message)
>> ;; If there is no user to answer queries, then say `no' to everything.
>> (if (or noninteractive
>> - nsm-noninteractive)
>> + nsm-noninteractive
>> + (not status))
>> nil
>> (let ((response
>> (condition-case nil
Alex> nsm-query gets skipped now but the process is still killed (same
Alex> message, etc).
Oh right, because now nsm-save-host doesnʼt get called. This should
work instead of the previous patch (but is not the right
solution, I think). You should get prompted by nsm now.
diff --git a/lisp/net/nsm.el b/lisp/net/nsm.el
index 5e8381075b..8750c19267 100644
--- a/lisp/net/nsm.el
+++ b/lisp/net/nsm.el
@@ -823,7 +823,7 @@ nsm-query-user
;; First format the certificate and warnings.
(with-current-buffer-window
buffer nil nil
- (insert (nsm-format-certificate status))
+ (when status (insert (nsm-format-certificate status)))
(insert message)
(goto-char (point-min))
;; Fill the first line of the message, which usually
next prev parent reply other threads:[~2019-09-04 15:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 16:56 bug#37221: 27.0.50; gnus fails to open connection post-NSM update Alex Branham
2019-09-02 9:33 ` Robert Pluim
2019-09-03 18:26 ` Alex Branham
2019-09-03 20:16 ` Robert Pluim
2019-09-04 13:13 ` Alex Branham
2019-09-04 13:37 ` Lars Ingebrigtsen
2019-09-04 14:00 ` Alex Branham
2019-09-04 14:16 ` Lars Ingebrigtsen
2019-09-04 14:24 ` Alex Branham
2019-09-04 14:35 ` Lars Ingebrigtsen
2019-09-04 14:51 ` Alex Branham
2019-09-04 14:56 ` Robert Pluim
2019-09-04 14:59 ` Lars Ingebrigtsen
2019-09-04 15:04 ` Robert Pluim
2019-09-04 15:04 ` Alex Branham
2019-09-04 15:25 ` Robert Pluim [this message]
2019-09-04 15:55 ` Alex Branham
2019-09-04 17:00 ` Robert Pluim
2019-09-04 17:06 ` Lars Ingebrigtsen
2019-09-04 17:21 ` Robert Pluim
2019-09-04 17:24 ` Lars Ingebrigtsen
2019-09-04 19:30 ` Robert Pluim
2019-09-04 19:37 ` Lars Ingebrigtsen
2019-09-04 20:37 ` Robert Pluim
2019-09-04 20:41 ` Lars Ingebrigtsen
2019-09-04 21:49 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m27e6oozhj.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=37221@debbugs.gnu.org \
--cc=alex.branham@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.