From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 094eb04: Fix MS-Windows build with mingw.org's MinGW
Date: Wed, 27 Nov 2019 11:57:05 +0100 [thread overview]
Message-ID: <m27e3lk2ny.fsf@gmail.com> (raw)
In-Reply-To: 83zhgiqvpa.fsf@gnu.org
>>>>> On Tue, 26 Nov 2019 21:33:21 +0200, Eli Zaretskii <eliz@gnu.org> said:
>> Date: Tue, 26 Nov 2019 20:50:48 +0200
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: emacs-devel@gnu.org
>>
>> > GetAdaptersAddresses returns wchar_t* for the description field, which
>> > means (I hope), that thereʼs some api for converting it appropriately.
>>
>> We can use wcsstr instead.
Eli> Alternatively, convert to ASCII with pWideCharToMultiByte (see
Eli> filename_to_ansi for an example), and then use strstr.
Does the following work for you? I have neither a wireless card
nor a pre-Vista Windows install.
diff --git a/src/w32.c b/src/w32.c
index cb82d51fb9..c5d9a62925 100644
--- a/src/w32.c
+++ b/src/w32.c
@@ -9540,8 +9540,23 @@ network_interface_list (bool full, unsigned short match)
switch (adapter->IfType)
{
case IF_TYPE_ETHERNET_CSMACD:
- ifmt_idx = ETHERNET;
- if_num = eth_count++;
+ /* Windows before Vista reports wireless adapters as
+ Ethernet. Work around by looking at the Description
+ string. */
+ {
+ char description[MAX_UTF8_PATH];
+ if (filename_from_utf16 (adapter->Description, description) == 0
+ && strstr (description, "Wireless "))
+ {
+ ifmt_idx = WLAN;
+ if_num = wlan_count++;
+ }
+ else
+ {
+ ifmt_idx = ETHERNET;
+ if_num = eth_count++;
+ }
+ }
break;
case IF_TYPE_ISO88025_TOKENRING:
ifmt_idx = TOKENRING;
next prev parent reply other threads:[~2019-11-27 10:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191126171403.25928.6996@vcs0.savannah.gnu.org>
[not found] ` <20191126171404.9DBBC20B21@vcs0.savannah.gnu.org>
2019-11-26 18:25 ` master 094eb04: Fix MS-Windows build with mingw.org's MinGW Robert Pluim
2019-11-26 18:50 ` Eli Zaretskii
2019-11-26 19:33 ` Eli Zaretskii
2019-11-27 10:57 ` Robert Pluim [this message]
2019-11-27 15:58 ` Eli Zaretskii
2019-11-28 8:43 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m27e3lk2ny.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.